commit 75da6df96b004220cf5baf25027827ef861d2839
Author: Travis Reitter <travis.reitter@collabora.co.uk>
Date: Wed Feb 22 14:18:23 2012 -0800
Release version 0.6.7
configure.ac | 10 +++++-----
folks/postal-address-details.vala | 2 +-
folks/role-details.vala | 2 +-
3 files changed, 7 insertions(+), 7 deletions(-)
commit 7c824b4baed19420bdd1eebca774aaf9cc5c4f6e
Author: Travis Reitter <travis.reitter@collabora.co.uk>
Date: Wed Feb 22 15:50:26 2012 -0800
Temporarily disable troublesome tests due to bgo#668415
tests/eds/Makefile.am | 28 ++++++++++++++++++----------
1 files changed, 18 insertions(+), 10 deletions(-)
commit c0003918e4be83e13e8823e0801486f05e66227d
Author: Travis Reitter <travis.reitter@collabora.co.uk>
Date: Mon Jan 30 11:23:26 2012 -0800
Cut invalid overly-specific type cast
The Vala compiler now correctly warns that typeof(Foo<Bar>)
is invalid,
so this stops pretending we can be that specific.
(The generated C code can't make a GValue as specific as the
above Vala
code fragment suggests; historically, the compiler would let you get
away with this, likely with the false assumption that the generic type
would ever be considered again.)
folks/individual-aggregator.vala | 2 +-
tests/eds/add-persona.vala | 12 ++++++------
tests/eds/link-personas.vala | 10 +++++-----
tests/tracker/add-persona.vala | 14 +++++++-------
tests/tracker/duplicated-emails.vala | 4 ++--
tests/tracker/duplicated-phones.vala | 4 ++--
tests/tracker/link-personas.vala | 4 ++--
tests/tracker/match-email-addresses.vala | 4 ++--
tests/tracker/match-im-addresses.vala | 4 ++--
tests/tracker/match-known-emails.vala | 4 ++--
tests/tracker/match-phone-number.vala | 4 ++--
tests/tracker/remove-persona.vala | 2 +-
tests/tracker/set-duplicate-email.vala | 2 +-
13 files changed, 35 insertions(+), 35 deletions(-)
commit 55539ee4accd29d89d28d23e6ef76ad2ab023724
Author: Colin Walters <walters@verbum.org>
Date: Fri Jan 20 14:46:14 2012 -0500
Build with vala 0.15
NEWS | 1 +
backends/key-file/kf-persona-store.vala | 13 +++----------
configure.ac | 2 +-
folks/backend-store.vala | 16 ++++++++--------
folks/object-cache.vala | 6 +++---
tests/folks/backend-loading.vala | 6 +++---
tests/lib/eds/backend.vala | 2 +-
tests/libsocialweb/aggregation.vala | 10 ++++------
tools/inspect/inspect.vala | 2 +-
9 files changed, 25 insertions(+), 33 deletions(-)
commit 22159d44ec6e516f4d0266b8d1efec7273ef1db8
Author: Travis Reitter <travis.reitter@collabora.co.uk>
Date: Fri Feb 17 15:03:17 2012 -0800
Note fix for bgo#670196 in NEWS
NEWS | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
commit ee8e0871a53e0209aa081342990a200d328aee48
Author: Marek Černocký <marek@manet.cz>
Date: Fri Feb 17 11:28:42 2012 +0100
Updated Czech translation
po/cs.po | 160
++++++++++++++++++++++++++++++++-----------------------------
1 files changed, 84 insertions(+), 76 deletions(-)
commit c231159f4206322dabf510f938a2e3979cf4fa4e
Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Date: Thu Feb 16 10:02:49 2012 +0100
add missing config.h includes
https://bugzilla.gnome.org/show_bug.cgi?id=670196
tests/lib/telepathy/contactlist/conn.c | 3 +++
.../telepathy/contactlist/contact-list-manager.c | 2 ++
2 files changed, 5 insertions(+), 0 deletions(-)
commit a062e90a17c303c20063b4aa912779860f2e2de0
Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Date: Thu Feb 16 10:02:13 2012 +0100
Disable glib deprecated warnings
We need GValueArray for dbus-glib, and it got deprecated in GLib
2.31.x
https://bugzilla.gnome.org/show_bug.cgi?id=670196
configure.ac | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
commit 7f0a54b8e59a1d03181c67a035e8a924a67f5b0c
Author: Automatic Mirroring <aronmalache@gmail.com>
Date: Thu Feb 16 11:57:35 2012 +0000
Add zh_CN to LINGUAS
po/LINGUAS | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
commit d067754ab6edc0db833026bdcd23da7e733fa65b
Author: Wylmer Wang <wantinghard@gmail.com>
Date: Thu Feb 16 11:56:39 2012 +0000
Add Simplified Chinese translation.
po/zh_CN.po | 753
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
1 files changed, 753 insertions(+), 0 deletions(-)
commit 3b479090475e5eb7ab1d40a2de48e3b727f50f6c
Author: Mario Blättermann <mario.blaettermann@gmail.com>
Date: Sun Feb 5 13:52:33 2012 +0100
[l10n] Updated German translation
po/de.po | 342
+++++++++++++++++++++++++++++++++++++-------------------------
1 files changed, 203 insertions(+), 139 deletions(-)
commit 312d2c035bf68bea78f6d3f0e11b5b1dcba88097
Author: Piotr Drąg <piotrdrag@gmail.com>
Date: Thu Feb 2 19:18:29 2012 +0100
Updated Polish translation
po/pl.po | 186
+++++++++++++++++++++++++++++++-------------------------------
1 files changed, 94 insertions(+), 92 deletions(-)
commit 221cb22ae55b4cf9ecab6d02969a87ad72590c8e
Author: Matej Urbančič <mateju@svn.gnome.org>
Date: Tue Jan 31 20:10:18 2012 +0100
Updated Slovenian translation
po/sl.po | 186
+++++++++++++++++++++++++++++++-------------------------------
1 files changed, 93 insertions(+), 93 deletions(-)
commit a8f50f0b7d77e83781c7dd7433ae99f48c64a9c8
Author: Daniel Mustieles <daniel.mustieles@gmail.com>
Date: Tue Jan 31 13:14:54 2012 +0100
Updated Spanish translation
po/es.po | 205
+++++++++++++++++++++++++++++++------------------------------
1 files changed, 104 insertions(+), 101 deletions(-)
commit 3f78e4a1c5b6cb9084608fa3a28264341d4274c7
Author: Travis Reitter <travis.reitter@collabora.co.uk>
Date: Thu Jan 26 16:27:03 2012 -0800
Only add non-empty Role or PostalAddress fields in Tracker backend
This prevents some newly-exposed test failures.
backends/tracker/lib/trf-persona-store.vala | 7 ++++-
backends/tracker/lib/trf-persona.vala | 31
+++++++++++++++++---------
2 files changed, 25 insertions(+), 13 deletions(-)
commit 50171f5392901dca6eb1af48cc76a7b0c7ad7b5b
Author: Travis Reitter <travis.reitter@collabora.co.uk>
Date: Tue Jan 24 18:00:29 2012 -0800
Don't assume every Tpf.Persona has a contact
backends/telepathy/lib/tpf-persona-store.vala | 38
+++++++++++++++++++++++-
1 files changed, 36 insertions(+), 2 deletions(-)
commit 22e4318d3ff4a10c94d51d509553428529c9a729
Author: Travis Reitter <travis.reitter@collabora.co.uk>
Date: Tue Jan 24 17:00:58 2012 -0800
Fix the nullity of test functions.
tests/folks/aggregation.vala | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
commit 05e72fcf261fb7a45cebf6db58c754d1b548f72f
Author: Travis Reitter <travis.reitter@collabora.co.uk>
Date: Tue Jan 24 15:57:32 2012 -0800
Make Individual implement PresenceDetails properly
folks/individual.vala | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
commit 84ada94322ade52392f386b09450d1a92ed9d02c
Author: Travis Reitter <travis.reitter@collabora.co.uk>
Date: Sat Jan 21 17:24:05 2012 -0800
Make Tpf.Persona properly implement the PresenceDetails properties.
backends/telepathy/lib/tpf-persona.vala | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
commit e407887f03f84379934391760a779109f1237cbe
Author: Alexander Larsson <alexl@redhat.com>
Date: Mon Jan 23 16:30:58 2012 +0100
Match names better for PotentialMatches
We match alias as well as full name, to e.g. match an EDS contact
(full name)
with an IM contact (alias).
Also, we make exact name matches bring the priority to HIGH alone,
which
is needed in the IM case since the alias is the only piece of data
we have to match on.
https://bugzilla.gnome.org/show_bug.cgi?id=668499
folks/potential-match.vala | 46
++++++++++++++++++++++++++++++++++++++++---
1 files changed, 42 insertions(+), 4 deletions(-)
commit 555d2d05f103dc48056a2f83521128c567c3159d
Author: Colin Walters <walters@verbum.org>
Date: Thu Jan 19 15:38:35 2012 -0500
autogen.sh: Honor NOCONFIGURE=1
See http://people.gnome.org/~walters/docs/build-api.txt
autogen.sh | 24 ++++++++++++++----------
1 files changed, 14 insertions(+), 10 deletions(-)
commit 1f6ad99baf8d64b6f887c8fb2c862779118a05c0
Author: Fran Diéguez <fran.dieguez@mabishu.com>
Date: Tue Jan 17 01:52:27 2012 +0100
Updated Galician translations
po/gl.po | 250
+++++++++++++++++++++++++++++++++-----------------------------
1 files changed, 134 insertions(+), 116 deletions(-)
commit b5f3bfb649ec9b86c24f870177e3648df9f5a8c0
Author: Marek Černocký <marek@manet.cz>
Date: Mon Jan 16 10:02:20 2012 +0100
Updated Czech translation
po/cs.po | 244
+++++++++++++++++++++++++++++++++-----------------------------
1 files changed, 129 insertions(+), 115 deletions(-)
commit 8c0c98a26914f5b1014866ae889f24d461ba3877
Author: Philip Withnall <philip@tecnocode.co.uk>
Date: Mon Jan 9 18:24:21 2012 +0000
eds: Add a dummy authentication handler
This will deny any authentication requests, which goes some way
to stopping
address books remaining in the “opening” state
indefinitely. However, it
(curiously) doesn’t entirely eliminate the problem.
It also looks like this is a situation where the ::opened signal
can return
an error while the async open() call doesn’t. Joy.
backends/eds/lib/edsf-persona-store.vala | 26
+++++++++++++++++++++++++-
1 files changed, 25 insertions(+), 1 deletions(-)
commit 1e3cde1b510a936832b04e741f634dda72d943d3
Author: Philip Withnall <philip@tecnocode.co.uk>
Date: Mon Jan 9 14:47:02 2012 +0000
telepathy: Fix weak notification of TpContacts
By the time our weak notification callback was called, the
TpContact’s
handle had been set to 0, which mucked things up for us.
Closes: https://bugzilla.gnome.org/show_bug.cgi?id=667535
NEWS | 2 +
backends/telepathy/lib/tpf-persona-store.vala | 36
++++++++++++++++---------
2 files changed, 25 insertions(+), 13 deletions(-)
commit bf8dfa934b1e6fa31818d51a3eba5cbb04a1632b
Author: Philip Withnall <philip@tecnocode.co.uk>
Date: Fri Jan 6 23:08:10 2012 +0000
telepathy: Keep Tpf.PersonaStore.personas up to date for cached stores
When loading a Tpf.PersonaStore from its cache, ensure Personas
are inserted
into both the set of personas _and_ the map of IIDs to personas.
This fixes Tpf.PersonaStore.personas being empty for cached stores.
Helps: https://bugzilla.gnome.org/show_bug.cgi?id=667410
backends/telepathy/lib/tpf-persona-store.vala | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
commit d258c86814c0dd4405a8a2b7a45f3d2a036fa1eb
Author: Philip Withnall <philip@tecnocode.co.uk>
Date: Fri Jan 6 23:05:05 2012 +0000
Bug 667410 — A second aggregator instance only fetches a subset
of contacts
This was happening because the initial BackendStore was hanging
around across
multiple IndividualAggregator instances, keeping all the Backends,
PersonaStores and Personas alive.
The IndividualAggregator didn’t have code to deal with pre-prepared
Backends
and PersonaStores, meaning it never realised the Personas existed
(because
they weren’t announced via personas-changed signals), and thus
never created
Individuals out of them.
This commit fixes the problem by having IndividualAggregator check for
existing Backends, PersonaStores and Personas when prepare()
is called.
It also adds a test case to the folks test suite, based on the
one written
by Guillaume in bgo#667410.
Closes: https://bugzilla.gnome.org/show_bug.cgi?id=667410
NEWS | 2 +
folks/backend.vala | 10 ++++
folks/individual-aggregator.vala | 50 ++++++++++++++++++++-
folks/persona-store.vala | 10 ++++
tests/folks/init.vala | 91
++++++++++++++++++++++++++++++++++++++
5 files changed, 161 insertions(+), 2 deletions(-)
commit 93a0fa7049f9a94ff917fa3bba24b376257a7c2b
Author: Philip Withnall <philip@tecnocode.co.uk>
Date: Mon Jan 9 11:16:09 2012 +0000
eds: Mark a few more contact fields as being handled
This should prevent a few debug messages about unhandled fields.
backends/eds/lib/edsf-persona-store.vala | 19 ++++++++++++++-----
1 files changed, 14 insertions(+), 5 deletions(-)
commit c34cd4b9f07b22f3813c3f26051521cb6338ea5e
Author: Philip Withnall <philip@tecnocode.co.uk>
Date: Mon Jan 9 10:55:02 2012 +0000
core: Set G_MESSAGES_DEBUG when parsing debug domains
This stops GLib from dropping all our debug output (unless the
user has
remembered to set G_MESSAGES_DEBUG manually in addition to
FOLKS_DEBUG).
folks/debug.vala | 5 +++++
1 files changed, 5 insertions(+), 0 deletions(-)
commit 065de8cfbe14b819a0f3e2670060899b8cc8b9be
Author: Philip Withnall <philip@tecnocode.co.uk>
Date: Mon Jan 9 10:12:30 2012 +0000
build: Add folks-internal files to MAINTAINERCLEANFILES etc.
folks/Makefile.am | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
commit 97dce24a20534d33dbea1d9520d9e1333c4e8e56
Author: Philip Withnall <philip@tecnocode.co.uk>
Date: Sun Jan 8 23:43:29 2012 +0000
docs: Add NEWS for the previous two commits
NEWS | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
commit 4acfe29de66deff09e778084dae2d9f39fdbf28e
Author: Philip Withnall <philip@tecnocode.co.uk>
Date: Sun Jan 8 23:16:14 2012 +0000
build: Add lcov make targets from telepathy-glib
Add lcov.mk, copied from telepathy-glib:
http://cgit.freedesktop.org/telepathy/telepathy-glib/tree/tools/lcov.am
with the tp-glib–specific bits removed.
These targets are only useful if folks is compiled with
--enable-code-coverage.
To run the test suite and generate a report, run `make lcov-check`. To
just
generate a report without running the test suite, run `make
lcov-report`.
The .info file and generated report are only deleted by
`make maintainer-clean`, since the developer might want to refer
to them
across other cleans.
Closes: https://bugzilla.gnome.org/show_bug.cgi?id=659610
Makefile.am | 15 +++++++++++++++
lcov.mk | 23 +++++++++++++++++++++++
2 files changed, 38 insertions(+), 0 deletions(-)
commit 56e69d1c2bdb2311f01b8d291f85645a356edd78
Author: Philip Withnall <philip@tecnocode.co.uk>
Date: Sun Jan 8 21:31:04 2012 +0000
Bug 657063 — Allow to pass a command to folks-inspect
Add a non-interactive mode to folks-inspect which executes the command
given on the command line synchronously, and then exits.
Closes: https://bugzilla.gnome.org/show_bug.cgi?id=657063
tools/inspect/inspect.vala | 165
++++++++++++++++++++++++++++++++++----------
1 files changed, 128 insertions(+), 37 deletions(-)
commit ba2d3fb69a0c5145ef3fca75377a8f63137025cc
Author: Philip Withnall <philip@tecnocode.co.uk>
Date: Sun Jan 8 19:51:25 2012 +0000
inspect: Set up locale in main()
tools/inspect/Makefile.am | 3 +++
tools/inspect/inspect.vala | 3 +++
2 files changed, 6 insertions(+), 0 deletions(-)
commit 7ee89fb9376af9aa671e86c5ef4116819c5a0cdf
Author: Philip Withnall <philip@tecnocode.co.uk>
Date: Sun Jan 8 19:19:03 2012 +0000
tests: Add a quiescence test for the Telepathy backend
This just checks that an aggregator with a single Tpf.PersonaStore
reaches
quiescence in a reasonable time.
tests/lib/Makefile.am | 25 +++++++++-
tests/lib/test-utils.vala | 44 +++++++++++++++++
tests/telepathy/Makefile.am | 7 ++-
tests/telepathy/init.vala | 109
+++++++++++++++++++++++++++++++++++++++++++
4 files changed, 182 insertions(+), 3 deletions(-)
commit d6e9f684b0303b6c7365373dad1adb937c7e99cf
Author: Philip Withnall <philip@tecnocode.co.uk>
Date: Sun Jan 8 17:02:40 2012 +0000
tests: Add a fake-tp-backend program in the Telepathy tests
This is not an automated test, and is intended to be run manually
on a D-Bus
bus specified using the DBUS_SESSION_BUS_ADDRESS environment variable,
together with a client program (for example, a test program) to be
run against
it.
tests/telepathy/Makefile.am | 8 +++-
tests/telepathy/fake-tp-backend.vala | 68
++++++++++++++++++++++++++++++++++
2 files changed, 75 insertions(+), 1 deletions(-)
commit 945cb3d7301b94205ad77fb454482d07679f5037
Author: Philip Withnall <philip@tecnocode.co.uk>
Date: Sun Jan 8 15:58:16 2012 +0000
build: Add an --enable-code-coverage configure parameter
When building with code coverage enabled, -fprofile-arcs and
-ftest-coverage
will be passed to gcc during compilation, and -lgcov will be passed
during
linking.
Code coverage is disabled by default for the core of folks, since
it has to
turn off valac’s ‘-g’ option to output #line directives in
the generated C
code. This is necessary because lcov gets confused by execution
passing
between .vala and .c files. More useful results can be obtained
by just
looking at the code coverage of the .c files and ignoring the
boilerplate
in them.
(More specifically, lcov reports on .vala files aren’t especially
useful
because they erroneously mark many lines as being executed which
actually
weren’t. This happens because one Vala line may be compiled
into several
lines of C, some of which will be executed unconditionally even if
the Vala
line itself isn’t executed. This will fool lcov into thinking the
Vala line
was actually executed.)
Code coverage is automatically turned off when making a release.
backends/eds/Makefile.am | 2 +
backends/eds/lib/Makefile.am | 2 +
backends/key-file/Makefile.am | 2 +
backends/libsocialweb/Makefile.am | 2 +
backends/libsocialweb/lib/Makefile.am | 2 +
backends/telepathy/Makefile.am | 2 +
backends/telepathy/lib/Makefile.am | 4 +++
backends/tracker/Makefile.am | 2 +
backends/tracker/lib/Makefile.am | 2 +
configure.ac | 34
+++++++++++++++++++++++++++++++-
folks/Makefile.am | 4 +++
11 files changed, 56 insertions(+), 2 deletions(-)
commit f4b46b0cdbea0ef334ffc1fe281440654c40dfea
Author: Philip Withnall <philip@tecnocode.co.uk>
Date: Sun Jan 8 15:50:02 2012 +0000
build: Tidy up use of AM_* variables in Makefile.ams
backends/eds/Makefile.am | 33
+++++++++++++++++++++------------
backends/eds/lib/Makefile.am | 4 ++++
backends/key-file/Makefile.am | 27 ++++++++++++++++++---------
backends/libsocialweb/Makefile.am | 33
+++++++++++++++++++++------------
backends/telepathy/Makefile.am | 31 ++++++++++++++++++++-----------
backends/telepathy/lib/Makefile.am | 9 ++++++++-
backends/tracker/Makefile.am | 33
+++++++++++++++++++++------------
backends/tracker/lib/Makefile.am | 28 ++++++++++++----------------
folks/Makefile.am | 11 +++++++++++
tools/Makefile.am | 15 +++++++++------
tools/inspect/Makefile.am | 8 +++++++-
11 files changed, 152 insertions(+), 80 deletions(-)
commit 478d8b0f9744d97600303dcd3dd7876b74949806
Author: Philip Withnall <philip@tecnocode.co.uk>
Date: Fri Jan 6 23:01:12 2012 +0000
eds: Cope with opening buggy EDS address book backends
Turns out that almost as soon as I’d pushed the previous commit,
one of my
address books proved me wrong and returned successfully from the
async open()
call without being open (according to is_opened()) afterwards. Bother.
This replaces the assertion that the above holds with some code
which will
throw an error instead, which should be a bit more robust in the
case of
buggy EDS address books.
backends/eds/lib/edsf-persona-store.vala | 28
+++++++++++++---------------
1 files changed, 13 insertions(+), 15 deletions(-)
commit 9eac06d8f0fe7cb5e58a95d7540f670419d98e54
Author: Philip Withnall <philip@tecnocode.co.uk>
Date: Fri Jan 6 18:29:21 2012 +0000
eds: Handle BUSY errors when opening address books better
If another process is in the middle of opening an address book when
we come
to try and open it, our open() call will return immediately with
a BUSY
error.
In this case, we need to wait for the EClient::opened signal to
know when
the open operation has finished.
Hopefully, this will fix those irritating ‘blah is busy’ errors
I frequently
get when running the EDS backend test suite. Hopefully it also won’t
introduce too many other problems.
backends/eds/lib/edsf-persona-store.vala | 86
+++++++++++++++++++++++++++++-
1 files changed, 85 insertions(+), 1 deletions(-)
commit 07bd131884ce4ae7d6e1fa9bf777da38b82b1a46
Author: Philip Withnall <philip@tecnocode.co.uk>
Date: Fri Jan 6 14:37:28 2012 +0000
tests: Fix the EDS link-personas-diff-stores test
Due to the tightening up of checks for PersonaStores being prepared
before
PersonaStore.add_persona_from_details() is called, this test was
failing
because it didn’t wait for its persona stores to get prepared.
This fixes the problem by waiting for quiescence before launching
into the
test code proper.
tests/eds/link-personas-diff-stores.vala | 26
+++++++++++++++++---------
1 files changed, 17 insertions(+), 9 deletions(-)
commit d4aeea66f0719dc7a77a43372a940735cdfff4f2
Author: Philip Withnall <philip@tecnocode.co.uk>
Date: Fri Jan 6 14:35:01 2012 +0000
eds: Reach quiescence in Edsf.PersonaStore for address books with
no contacts
It’s possible for an address book to have the “do-initial-query”
capability
yet not emit any ::objects-added signals on its view, if the address
book has
no contacts.
This commit fixes that by listening for the ::complete signal on
the address
book view and using that to determine quiescence instead.
This should theoretically also catch cases where the address book
encounters
an error part-way through initialisation, since that will be
reported via
the ::complete signal.
backends/eds/lib/edsf-persona-store.vala | 41
++++++++++++++++++++++++------
1 files changed, 33 insertions(+), 8 deletions(-)
commit 6e8949a42ebb767c3d82039365e5204422e26d50
Author: Philip Withnall <philip@tecnocode.co.uk>
Date: Fri Jan 6 14:33:52 2012 +0000
tests: Fix printerr() handler in TestCase
It was always getting a null message due to having an extraneous extra
parameter (in its C form), meaning that stacktraces from failed
assertions
in test cases were never getting printed.
tests/lib/test-case.vala | 5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
commit 33f7d0564156e766c22e8637e33f6389ae110bc6
Author: Philip Withnall <philip@tecnocode.co.uk>
Date: Wed Dec 28 19:17:09 2011 +0000
eds: Nullability fixes
With the EDS annotation fixes in
https://bugzilla.gnome.org/show_bug.cgi?id=667388, this fixes all
of the
nullability problems found by compiling with
--enable-experimental-non-null.
As mentioned in the previous commit, we can’t use
--enable-experimental-non-null by default yet, but the fixes should
work by
themselves.
backends/eds/lib/edsf-persona-store.vala | 286
++++++++++++++++++------------
backends/eds/lib/edsf-persona.vala | 247 ++++++++++++++-----------
backends/eds/lib/memory-icon.vala | 12 +-
folks/persona-store.vala | 9 +-
4 files changed, 324 insertions(+), 230 deletions(-)
commit d3385bae363651fe9588826210f79359fa820e01
Author: Philip Withnall <philip@tecnocode.co.uk>
Date: Wed Dec 21 23:58:39 2011 +0000
core: Nullability fixes
Almost all of these are just the necessary ‘(!)’ annotations to
allow the
nullability check to pass. There were few, if any, actual bugs found
by the
check (which either means folks is perfect, or Vala's nullability
checking
is imperfect).
This brings us down from 296 nullability errors to just below 50.
The work was done by compiling folks with valac’s
--enable-experimental-non-null flag. We’re not ready to add the
flag to
VALAFLAGS permanently yet, since this commit depends on various
annotation
fixes in GLib (and similarly, the next one depends on several in EDS).
However, the fixes themselves should be valid without the flag.
This depends on (at least):
• https://bugzilla.gnome.org/show_bug.cgi?id=666700
• https://bugzilla.gnome.org/show_bug.cgi?id=666699
folks/abstract-field-details.vala | 4 +-
folks/avatar-cache.vala | 17 ++-
folks/backend-store.vala | 80 ++++++++++------
folks/debug.vala | 23 +++--
folks/email-details.vala | 4 +-
folks/im-details.vala | 28 +++---
folks/individual-aggregator.vala | 169
+++++++++++++++++++--------------
folks/individual.vala | 190
+++++++++++++++++++++---------------
folks/note-details.vala | 12 +--
folks/object-cache.vala | 43 +++++----
folks/persona-store.vala | 9 +-
folks/persona.vala | 6 +-
folks/phone-details.vala | 7 +-
folks/postal-address-details.vala | 2 +-
folks/potential-match.vala | 14 ++-
folks/role-details.vala | 7 +-
folks/url-details.vala | 2 +-
folks/web-service-details.vala | 2 +-
18 files changed, 357 insertions(+), 262 deletions(-)
commit 9136e590ecfade421f419233bb6afc70df5b332c
Author: Matej Urbančič <mateju@svn.gnome.org>
Date: Wed Jan 4 20:31:26 2012 +0100
Updated Slovenian translation
po/sl.po | 234
++++++++++++++++++++++++++++++++-----------------------------
1 files changed, 123 insertions(+), 111 deletions(-)
commit d8dcef46764b17771eed66cd1b53ceb4caeff082
Author: Christian Kirbach <Christian.Kirbach@googlemail.com>
Date: Sun Jan 1 22:44:46 2012 +0100
Updated German translation
po/de.po | 364
++++++++++++++++++++++++++++----------------------------------
1 files changed, 163 insertions(+), 201 deletions(-)
commit ec7d34f1532a734c87eaec9ee7178c6a65c02841
Author: Nicolás Satragno <nsatragno@gmail.com>
Date: Sat Dec 31 18:49:49 2011 +0100
Updated Spanish translation
po/es.po | 60
++++++++++++++++++++++++++++++++++++++----------------------
1 files changed, 38 insertions(+), 22 deletions(-)
commit 9c6da3b5fe39eb46532ce879067b1ff55d15df9e
Author: Nicolás Satragno <nicoymatu9@hotmail.com>
Date: Thu Dec 29 15:46:42 2011 +0100
Updated Spanish translation
po/es.po | 292
+++++++++++++++++++++++++++++++++-----------------------------
1 files changed, 156 insertions(+), 136 deletions(-)
commit 08db22f49e991df099b0f499ce48ee1d1c3b719a
Author: Piotr Drąg <piotrdrag@gmail.com>
Date: Wed Dec 28 22:41:40 2011 +0100
Updated Polish translation
po/pl.po | 239
++++++++++++++++++++++++++++++++++----------------------------
1 files changed, 130 insertions(+), 109 deletions(-)
commit b108a7c8de2f35546a1e7df2e3e45b77a39db481
Author: Philip Withnall <philip@tecnocode.co.uk>
Date: Wed Dec 28 19:56:24 2011 +0000
aggregator: Expand the ‘no primary persona store’ error messages
Try and be a little more helpful.
folks/individual-aggregator.vala | 12 ++++++++++--
1 files changed, 10 insertions(+), 2 deletions(-)
commit c7991405bb2304bc57b5af711ff733a724f1372b
Author: Philip Withnall <philip@tecnocode.co.uk>
Date: Sun Dec 25 11:03:02 2011 +0000
docs: Add NEWS for commit a99f47a196bee5a5ab258a010f7dcc173bbf7a42
NEWS | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
commit e5a2b01dceb57acad6104fa75e13623be10231a5
Author: Philip Withnall <philip@tecnocode.co.uk>
Date: Sun Dec 25 10:58:38 2011 +0000
eds: Ensure the default role is non-empty
If the default role is empty (e.g. because EDS returns empty strings
as the
contact's title, org or role; rather than null), don't add it to the
Persona.
Helps: bgo#666540
backends/eds/lib/edsf-persona.vala | 24 ++++++++++++++----------
1 files changed, 14 insertions(+), 10 deletions(-)
commit a99f47a196bee5a5ab258a010f7dcc173bbf7a42
Author: Philip Withnall <philip@tecnocode.co.uk>
Date: Sun Dec 25 10:48:14 2011 +0000
core: Warn on passing empty values to AbstractFieldDetails subclasses
There are no situations where passing an empty value (string or
object) to
an AbstractFieldDetails subclass makes sense. It just introduces
potential
bugs with mishandling empty strings (etc.) in code which consumes the
AbstractFieldDetails.
This commit adds warnings to all the AbstractFieldDetails
subclasses’
constructors which check for empty inputs. We can't use assert()s here
because that would be an API break.
Helps: bgo#666540
folks/email-details.vala | 9 +++++++--
folks/im-details.vala | 8 +++++++-
folks/note-details.vala | 8 +++++++-
folks/phone-details.vala | 8 +++++++-
folks/postal-address-details.vala | 27 ++++++++++++++++++++++++++-
folks/role-details.vala | 22 +++++++++++++++++++++-
folks/url-details.vala | 7 ++++++-
folks/web-service-details.vala | 8 +++++++-
8 files changed, 88 insertions(+), 9 deletions(-)
commit 6d9b0f55ff057776c13a2a6927a853ba6e9a320d
Author: Philip Withnall <philip@tecnocode.co.uk>
Date: Wed Dec 21 20:09:47 2011 +0000
Bug 666540 — Segfault on empty e-mail addresses with potential match
Gracefully handle invalid e-mail addresses (such as empty strings
or strings
not containing an ‘@’) when searching for potential matches.
Closes: bgo#666540
NEWS | 1 +
folks/potential-match.vala | 24 +++++++++++++++++++++---
2 files changed, 22 insertions(+), 3 deletions(-)
commit dd743bdc54c477a8e5653b4e00d569b151199365
Author: Philip Withnall <philip@tecnocode.co.uk>
Date: Wed Dec 21 20:08:32 2011 +0000
eds: Ignore empty values when creating AbstractFieldDetails instances
We don't want to be passing around (e.g.) empty strings as e-mail
addresses,
or we'll cause bugs like bgo#666540.
This modifies the EDS backend to check E.VCardAttribute.get_value()
is not
null or the empty string whenever it's called, and skip the
attribute as
appropriate.
Helps: bgo#666540
backends/eds/lib/edsf-persona.vala | 48
++++++++++++++++++++++++++++++-----
1 files changed, 41 insertions(+), 7 deletions(-)
commit 73b61e6a5465d9c511e0ef853e9dea7497bbcf10
Author: Philip Withnall <philip@tecnocode.co.uk>
Date: Wed Dec 21 17:53:04 2011 +0000
Bug 666528 — Can't convert from type 'GFile' to 'gchararray'
Add pretty-printing support for a couple of new properties to
folks-inspect.
Closes: bgo#666528
NEWS | 1 +
tools/inspect/utils.vala | 15 ++++++++++++++-
2 files changed, 15 insertions(+), 1 deletions(-)
commit c05b0a64acc35f47f8474094a1c378e22d874954
Author: Philip Withnall <philip@tecnocode.co.uk>
Date: Wed Dec 21 17:52:05 2011 +0000
inspect: Fix use of a deprecated NoteFieldDetails property
tools/inspect/utils.vala | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
commit ec303b8f6c467a9c39a5a81bf5b2fc1b788208af
Author: Henrique P. Machado <hpmachado@gnome.org>
Date: Mon Dec 19 15:27:01 2011 -0200
Added Brazilian Portuguese translation
po/LINGUAS | 1 +
po/pt_BR.po | 758
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
2 files changed, 759 insertions(+), 0 deletions(-)
commit a73c77ec7ee7bc4c1a19a93b8999e0c9a02e8205
Author: Kjartan Maraas <kmaraas@gnome.org>
Date: Mon Dec 19 09:27:57 2011 +0100
Add nb
po/LINGUAS | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
commit 20ff0c8d89b7a6b4bc50952eb6dbff95120748d4
Author: Kjartan Maraas <kmaraas@gnome.org>
Date: Mon Dec 19 09:27:51 2011 +0100
Added Norwegian bokmål translation
po/nb.po | 724
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
1 files changed, 724 insertions(+), 0 deletions(-)
commit 7ccaef83603d2e3ce8cba054baf9dda5d8b7d9d0
Author: Kjartan Maraas <kmaraas@gnome.org>
Date: Tue Mar 29 14:50:16 2011 +0200
Add missing #include <config.h> to make translations work
backends/telepathy/lib/tp-lowlevel.c | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
commit 675f42c0b877c1a25bff05beb91e552fd793a6d9
Author: Philip Withnall <philip@tecnocode.co.uk>
Date: Thu Dec 15 18:33:26 2011 +0000
Bug 666310 — Crash in Tracker backend by unsetting an entry in
a read-only…
Closes: bgo#666310
NEWS | 1 +
backends/tracker/tr-backend.vala | 2 +-
2 files changed, 2 insertions(+), 1 deletions(-)
commit cd7653e952c3002087fa5dfea42910addca9263e
Author: Travis Reitter <travis.reitter@collabora.co.uk>
Date: Tue Dec 13 16:51:15 2011 -0800
Post-release version bump.
NEWS | 4 ++++
configure.ac | 4 ++--
2 files changed, 6 insertions(+), 2 deletions(-)