commit 54b47403fa8dab2fe635fc36e155fb8511db55bf
Author: Jeremy Whiting <jpwhiting@kde.org>
Date: Thu Jun 28 13:49:50 2012 -0600
Use async creation of Source Registry in eds test backend.
tests/lib/eds/backend.vala | 27 +++++++++++++++------------
1 file changed, 15 insertions(+), 12 deletions(-)
commit 5575c62212216918bfa445bb9bf06ad7b864e70c
Author: Jeremy Whiting <jpwhiting@kde.org>
Date: Thu Jun 28 13:49:00 2012 -0600
Start eds source-registry and addressbook-factory ourselves.
tests/tools/eds.sh | 6 ++++++
tests/tools/with-session-bus-eds.sh | 1 +
2 files changed, 7 insertions(+)
commit 41e06cadb865a1ab2db1b72fda9d495aa477221f
Author: Jeremy Whiting <jpwhiting@kde.org>
Date: Thu Jun 28 13:47:32 2012 -0600
Add test.source and other.source to EXTRA_DIST.
tests/tools/Makefile.am | 2 ++
1 file changed, 2 insertions(+)
commit 7c9668c86a0408a5dd3f483faba9fee3060de326
Author: Jeremy Whiting <jpwhiting@kde.org>
Date: Thu Jun 28 13:46:57 2012 -0600
Add Bugfix to NEWS.
NEWS | 1 +
1 file changed, 1 insertion(+)
commit ecd2ac896d06fb77f4cf0a1695820b8f7f6335ff
Author: Jeremy Whiting <jpwhiting@kde.org>
Date: Thu Jun 28 12:17:52 2012 -0600
Add folks-internal to libsocialweb backend library vapi.
Fixes https://bugzilla.gnome.org/show_bug.cgi?id=679020
backends/libsocialweb/lib/Makefile.am | 1 +
1 file changed, 1 insertion(+)
commit a74d6856327e59488a44c761bec8468a003e8556
Author: Jeremy Whiting <jpwhiting@kde.org>
Date: Thu Jun 28 11:41:15 2012 -0600
Add folks-internal to make docs dependencies for profiling symbols.
docs/Makefile.am | 1 +
1 file changed, 1 insertion(+)
commit b0bebe1a1323160ae711b8751a275109de1ca4c3
Author: Jeremy Whiting <jpwhiting@kde.org>
Date: Thu Jun 28 10:53:58 2012 -0600
Default to xz tarballs for distribution.
configure.ac | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
commit 66ad2dbd9c3394da131f0165ee4cea0ecc301b4c
Author: Jeremy Whiting <jpwhiting@kde.org>
Date: Wed Jun 27 11:22:18 2012 -0600
Remove individual-zeitgeist from make check targets.
tests/telepathy/Makefile.am | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
commit 817614ae68c9a08b0e54ecc3d3f905ebc516360d
Author: Jeremy Whiting <jpwhiting@kde.org>
Date: Tue Jun 26 21:48:45 2012 -0600
Folks 0.7.2 release.
configure.ac | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
commit 6313ad3c01ab7f047e5b83671b52de5834cb4071
Author: Philip Withnall <philip@tecnocode.co.uk>
Date: Sun Jun 24 20:21:55 2012 +0100
tracker: Unmark a method as asynchronous
Private method, didn’t need to be asynchronous.
backends/tracker/lib/trf-persona-store.vala | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
commit 09c1736bceb33722139704f71bad40ec7b070177
Author: Philip Withnall <philip@tecnocode.co.uk>
Date: Sun Jun 24 18:33:49 2012 +0100
eds: Share a single E.SourceRegistry between all Edsf.PersonaStores
Turns out a single E.SourceRegistry takes about 200ms to construct,
due to
involving D-Bus round trips, so sharing the existing SourceRegistry
from the
Eds.Backend to all its Edsf.PersonaStores is a big win.
backends/eds/eds-backend.vala | 3 ++-
backends/eds/lib/edsf-persona-store.vala | 38
+++++++++++++++++++++++++++-----
2 files changed, 35 insertions(+), 6 deletions(-)
commit f032c7afaf86fba46dca272cf973a89a78208d56
Author: Philip Withnall <philip@tecnocode.co.uk>
Date: Sun Jun 24 18:15:41 2012 +0100
aggregator: Don’t prematurely reach quiescence
If one of the backends loads very fast, but doesn’t signal the
addition of
any persona stores for a while, the IndividualAggregator will
prematurely
reach quiescence. We now force quiescence to be reached at least
after all
the backends have finished loading.
folks/individual-aggregator.vala | 7 +++++++
1 file changed, 7 insertions(+)
commit 3deab10a238fb77a68f96fb74ce75a4f37c347a8
Author: Philip Withnall <philip@tecnocode.co.uk>
Date: Sun Jun 24 17:55:43 2012 +0100
core: Add a profiling API and implement some profiling points
The API outputs messages in the format accepted by Federico’s
plot-timeline.py
(http://people.gnome.org/~federico/news-2006-03.html#timeline-tools)
so graphs can easily be generated by running:
strace -ttt -f -o /tmp/logfile folks-inspect
python plot-timeline.py -o graph.png /tmp/logfile
So far, the BackendStore, IndividualAggregator and Backend and
PersonaStore
classes for all the backends have been annotated.
HACKING | 15 +++++
NEWS | 1 +
backends/eds/Makefile.am | 2 +
backends/eds/eds-backend.vala | 4 ++
backends/eds/lib/edsf-persona-store.vala | 23 ++++++++
backends/key-file/Makefile.am | 2 +
backends/key-file/kf-backend.vala | 4 ++
backends/key-file/kf-persona-store.vala | 10 ++++
backends/libsocialweb/Makefile.am | 2 +
backends/libsocialweb/lib/swf-persona-store.vala | 10 ++++
backends/libsocialweb/sw-backend.vala | 4 ++
backends/telepathy/Makefile.am | 2 +
backends/telepathy/lib/tpf-persona-store.vala | 24 +++++++-
backends/telepathy/tp-backend.vala | 4 ++
backends/tracker/Makefile.am | 2 +
backends/tracker/lib/Makefile.am | 2 +
backends/tracker/lib/trf-persona-store.vala | 17 ++++++
backends/tracker/tr-backend.vala | 4 ++
configure.ac | 11 ++++
folks/Makefile.am | 5 ++
folks/backend-store.vala | 42 ++++++++++++--
folks/individual-aggregator.vala | 10 ++++
folks/internal.vala | 72
++++++++++++++++++++++++
folks/persona-store.vala | 3 +
24 files changed, 269 insertions(+), 6 deletions(-)
commit 93d2f1b947e98fe87ceacc2a26dcd114429e16ad
Author: Jeremy Whiting <jpwhiting@kde.org>
Date: Mon Jun 25 16:01:19 2012 -0600
Add bug fix to NEWS file.
NEWS | 1 +
1 file changed, 1 insertion(+)
commit 0120e189815b0594188b827e707791d05118d60f
Author: Jeremy Whiting <jpwhiting@kde.org>
Date: Mon Jun 25 15:55:22 2012 -0600
Fix style issues as noted in
https://bugzilla.gnome.org/show_bug.cgi?id=678811.
Use _addressbook_name to ref the test source.
Remove unused _source_name.
tests/lib/eds/backend.vala | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
commit 922e8afea3bec94f6721c9a0cac15f0e935f64fb
Author: Jeremy Whiting <jpwhiting@kde.org>
Date: Mon Jun 25 13:07:49 2012 -0600
Remove GConf stop from eds test harness, since it's not needed.
tests/tools/with-session-bus-eds.sh | 7 -------
1 file changed, 7 deletions(-)
commit a155d6b645fe855de6c4dcb07e85c44f0b3158d9
Author: Jeremy Whiting <jpwhiting@kde.org>
Date: Mon Jun 25 13:06:26 2012 -0600
Add mainloop to eds test backend tear_down to wait for addressbook
removal.
tests/lib/eds/backend.vala | 33 +++++++++++++++++++--------------
1 file changed, 19 insertions(+), 14 deletions(-)
commit b0c51f90db62b8390d55ab098963792627fc29c4
Author: Jeremy Whiting <jpwhiting@kde.org>
Date: Mon Jun 25 13:01:49 2012 -0600
Fix link-personas-diff-stores test.
Need to use both test and other addressbooks.
tests/eds/link-personas-diff-stores.vala | 2 ++
1 file changed, 2 insertions(+)
commit 70f5879d8105ea9f4cb74520637b9c08358e9334
Author: Jeremy Whiting <jpwhiting@kde.org>
Date: Mon Jun 25 13:00:15 2012 -0600
Use ESource display_name instead of uid.
backends/eds/lib/edsf-persona-store.vala | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
commit 28a79de9d06b3222325a6ba44acce14bac051f8d
Author: Jeremy Whiting <jpwhiting@kde.org>
Date: Thu Jun 21 12:36:27 2012 -0600
Use async addressbook remove method, since sync method hangs
currently.
tests/lib/eds/backend.vala | 26 ++++++++++++++------------
1 file changed, 14 insertions(+), 12 deletions(-)
commit bf289030eab2459b9d64afe84ad3304bc61265c9
Author: Jeremy Whiting <jpwhiting@kde.org>
Date: Wed Jun 20 12:19:19 2012 -0600
Fix link-personas-diff-stores unit test.
Remove obsolete EDS TestBackend address_uri.
Allow choosing other or test source in set_up method.
tests/eds/link-personas-diff-stores.vala | 3 +--
tests/lib/eds/backend.vala | 13 +++++--------
2 files changed, 6 insertions(+), 10 deletions(-)
commit 5784cb03bf52b56c7f9439e2ebb45cbc4bc7c4be
Author: Jeremy Whiting <jpwhiting@kde.org>
Date: Wed Jun 20 12:18:42 2012 -0600
Create another other.source for eds unit tests.
tests/tools/eds.sh | 2 +-
tests/tools/other.source | 6 ++++++
2 files changed, 7 insertions(+), 1 deletion(-)
commit ef7b78ef733f9a3b5ed4658cbd8d4f796ede0760
Author: Jeremy Whiting <jpwhiting@kde.org>
Date: Tue Jun 19 11:54:05 2012 -0600
Port test eds backend to eds api changes.
Add test.source keyfile for unit tests.
tests/lib/eds/backend.vala | 41 ++++++++++++-----------------------------
tests/tools/eds.sh | 5 +++++
tests/tools/test.source | 6 ++++++
3 files changed, 23 insertions(+), 29 deletions(-)
commit f62079cf2cf382c6627f1b3423d356181644ac03
Author: Jeremy Whiting <jpwhiting@kde.org>
Date: Tue Jun 19 11:52:13 2012 -0600
Re-enable eds backend unit tests.
configure.ac | 2 ++
tests/Makefile.am | 5 ++---
tests/lib/Makefile.am | 5 ++---
3 files changed, 6 insertions(+), 6 deletions(-)
commit 2341b9772bfba76ff153d3b36aa88cb3409e8681
Author: Philip Withnall <philip@tecnocode.co.uk>
Date: Mon Jun 25 20:07:21 2012 +0100
core: Replace symbols with spaces when matching names in
PotentialMatch
This allows, for example, “Alice Badger” and “alice.badger”
to have a HIGH
match. This is a common situation when trying to pair up IM personas
with
other personas.
This also includes a test case.
Closes: https://bugzilla.gnome.org/show_bug.cgi?id=678474
folks/potential-match.vala | 17 ++++++++++-------
tests/tracker/match-name.vala | 9 +++++++++
2 files changed, 19 insertions(+), 7 deletions(-)
commit 48b4c38494803023d6ad75a2724cf7ee6ad59a14
Author: Philip Withnall <philip@tecnocode.co.uk>
Date: Mon Jun 25 21:47:55 2012 +0100
eds: Fix memory leaks in EDS backend
These were unavoidably caused by a problem with the EDS Vala
bindings. This
will be fixed in EDS 3.5.4, so our dependency has been bumped.
Closes: https://bugzilla.gnome.org/show_bug.cgi?id=678781
NEWS | 2 ++
backends/eds/lib/edsf-persona.vala | 50
++++++++++++++++++--------------------
configure.ac | 2 +-
3 files changed, 27 insertions(+), 27 deletions(-)
commit 697b611adfbfffdb37a817feb5482f43bb715e1e
Author: Philip Withnall <philip@tecnocode.co.uk>
Date: Sat Jun 23 11:24:53 2012 +0100
core: Fix indexing for unichars in PotentialMatch’s Jaro distance
function
The indexing was getting out of sync between the two strings if
one contained
a different number of non-ASCII characters to the other (as the
indexing was
done in terms of bytes, rather than characters). This re-works
the Jaro
distance function to operate on unichar arrays, and index in terms of
characters. This also means that exact matches now work over stripped
non-ASCII
characters, which they didn’t before.
This adds a new test case. Yay.
Closes: https://bugzilla.gnome.org/show_bug.cgi?id=678474
NEWS | 1 +
folks/potential-match.vala | 89
++++++++++++++++++++++++++-----------------
tests/tracker/match-name.vala | 9 +++++
3 files changed, 64 insertions(+), 35 deletions(-)
commit 6dee26ca93460f1518f13c3af09cf36fff88b8f3
Author: Philip Withnall <philip@tecnocode.co.uk>
Date: Sat Jun 23 10:09:14 2012 +0100
core: Tidy up MatchResult usage in PotentialMatch a little
There’s no need for the result to be an instance variable.
folks/potential-match.vala | 74
++++++++++++++++++++++++----------------------
1 file changed, 39 insertions(+), 35 deletions(-)
commit b36980efea265edcd822b71e1a1ff8715e75e652
Author: Florian Müllner <fmuellner@gnome.org>
Date: Mon Jun 25 15:41:44 2012 +0200
eds: Adjust to e-d-s API break
Address books are now referenced by UID instead of URI, and the API
has been updated to reflect this.
backends/eds/lib/edsf-persona-store.vala | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
commit 1c6817d6e3e0544015a50211c4127a6ea908acbe
Author: A S Alam <aalam@users.sf.net>
Date: Mon Jun 25 06:45:20 2012 +0530
Update Punjabi Translation
po/pa.po | 189
++++++++++++++++++++++++++++++++++++++-------------------------
1 file changed, 113 insertions(+), 76 deletions(-)
commit 58e305e8270578fdb942a1272b3b9393eccd1b42
Author: Fran Diéguez <fran.dieguez@mabishu.com>
Date: Mon Jun 25 00:05:55 2012 +0200
Updated Galician translations
po/gl.po | 113
++++++++++++++++++++++++++++++++-------------------------------
1 file changed, 57 insertions(+), 56 deletions(-)
commit c199edd98c5c439b649c61a0dcb247dc3e7a13f5
Author: Philip Withnall <philip@tecnocode.co.uk>
Date: Sat Jun 23 12:17:23 2012 +0100
eds: Fix warnings about empty postal addresses
backends/eds/lib/edsf-persona.vala | 15 +++++++++++++--
1 file changed, 13 insertions(+), 2 deletions(-)
commit be138e709d9d01c60a09bc7ed2c431a6205b5fcd
Author: Philip Withnall <philip@tecnocode.co.uk>
Date: Sat Jun 23 12:04:38 2012 +0100
eds: Revert checks for empty properties
These are in the wrong place and duplicate checks further down
those code
paths.
backends/eds/lib/edsf-persona-store.vala | 18 +++++++-----------
1 file changed, 7 insertions(+), 11 deletions(-)
commit 35f426f0d35480504556d2967de5a9aaa4226034
Author: Dimitris Spingos <dmtrs32@gmail.com>
Date: Fri Jun 22 16:34:04 2012 +0300
Updated Greek translation
po/LINGUAS | 1 +
po/el.po | 51 +++++++++++++++++++++++++++------------------------
2 files changed, 28 insertions(+), 24 deletions(-)
commit 59cc87e0d37286f9d9832dc664feac1ec0ac36df
Author: Dimitris Spingos <dmtrs32@gmail.com>
Date: Fri Jun 22 16:15:38 2012 +0300
Added Greek translation
po/el.po | 723
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 723 insertions(+)
commit fe3ddd5fb909c7289aacd7d4d4edfbb6ee298a3f
Author: Daniel Mustieles <daniel.mustieles@gmail.com>
Date: Fri Jun 22 13:49:25 2012 +0200
Updated Spanish translation
po/es.po | 114
+++++++++++++++++++++++++++++++++------------------------------
1 file changed, 59 insertions(+), 55 deletions(-)
commit 714b554524a84b6418fd2d02a6b706ba35123766
Author: Philip Withnall <philip@tecnocode.co.uk>
Date: Tue Jun 19 11:25:06 2012 +0100
telepathy: Remove unused variable
backends/telepathy/lib/tpf-persona-store.vala | 3 ---
1 file changed, 3 deletions(-)
commit 392ece02e7bb0e564f9b8fdd6472ab95d6b78361
Author: Philip Withnall <philip@tecnocode.co.uk>
Date: Mon Jun 18 12:11:39 2012 +0100
core: Change default EDS PersonaStore ID to ‘system-address-book’
The new version of EDS uses that instead of ‘system’. This
shouldn’t pose
upgrade problems (e.g. if a user has ‘system’ stored in
GSettings), since in
that case the ‘system’ persona store wouldn’t be found, and
the fallback
would be to use the persona store marked as the system-set default
— which
is the ‘system-address-book’ persona store, as required.
folks/individual-aggregator.vala | 2 +-
folks/org.freedesktop.folks.gschema.xml.in | 2 +-
tests/eds/change-primary-store.vala | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
commit 79b83aeb6d97f6ce5b489e64e4cd13e5b2be06df
Author: Philip Withnall <philip@tecnocode.co.uk>
Date: Mon Jun 18 12:09:58 2012 +0100
eds: Fix invalid cast in Edsf.PersonaStore
E.SourceRegistry.find_extension() always returns an E.Source — we
must then
call get_extension() on that E.Source to get the relevant
extension. This
commit fixes an invalid cast here and factors out code to check
for backend
name matches for things like the ‘google’ and ‘ldap’ address
book backends.
Note that this depends on a new GIR annotation in EDataServer.
backends/eds/lib/edsf-persona-store.vala | 41
+++++++++++++++-----------------
1 file changed, 19 insertions(+), 22 deletions(-)
commit c7939400effd108163eb2413c5027222d2508dc8
Author: Philip Withnall <philip@tecnocode.co.uk>
Date: Mon Jun 18 12:09:08 2012 +0100
eds: Handle the possibility of E.SourceRegistry being null
Several functions can be called before E.SourceRegistry is set
in prepare(),
so they must cope with it potentially being null.
backends/eds/lib/edsf-persona-store.vala | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
commit 09ab10a3068e52b5f4d7f55375dd67fa3c98fa29
Author: Jeremy Whiting <jpwhiting@kde.org>
Date: Tue Jun 19 08:51:09 2012 -0600
Get E.SourceAddressBook extensions from the source.
Fix eds backend warnings.
backends/eds/lib/edsf-persona-store.vala | 42
++++++++++++++++++--------------
1 file changed, 24 insertions(+), 18 deletions(-)
commit 1446c3ed1adafbb153925b81e42e3f199cc1e63a
Author: Philip Withnall <philip@tecnocode.co.uk>
Date: Mon Jun 18 11:08:59 2012 +0100
telepathy: Don’t create PersonaStores for disabled accounts
We shouldn’t create persona stores for disabled accounts, as they
just sit
there looking lonely and empty. Persona stores should be created
for enabled
and valid accounts, and should be removed when those accounts are
disabled
or become invalid.
backends/telepathy/tp-backend.vala | 5 +++++
1 file changed, 5 insertions(+)
commit c8fa98d3ae271c56d7e760f9c2eed37585108541
Author: Philip Withnall <philip@tecnocode.co.uk>
Date: Mon Jun 18 11:04:57 2012 +0100
Bug 677166 — Salut personas survive disconnection
Handle TpAccounts being disabled by listening for
TpAccountManager::account-disabled rather than (erroneously)
assuming that
TpAccount:enabled will have been changed by the time the corresponding
TpConnection is disconnected.
This fixes a race condition when accounts are disabled, where the
account’s
personas would persist if TpAccount:enabled hadn’t changed by the
time the
connection was disconnected.
This comes at the cost of potentially storing and re-loading the
set of
personas for that account to the cache, only to later delete the
cache file
when TpAccount:enabled changes. I can’t think of a simple fix
for this.
Closes: https://bugzilla.gnome.org/show_bug.cgi?id=677166
NEWS | 3 +-
backends/telepathy/lib/tpf-persona-store.vala | 50
++++++++++++++++-----------
2 files changed, 31 insertions(+), 22 deletions(-)
commit 1c3357fb0c32855f5423e5b88127f2b4cfb1baa5
Author: Philip Withnall <philip@tecnocode.co.uk>
Date: Mon Jun 18 10:32:49 2012 +0100
inspect: Implement pretty printing of GDateTime
The new Zeitgeist work in the Telepathy backend makes use of nullable
GDateTimes, so this implements pretty printing of them in
folks-inspect.
Everyone prefers reading well-formatted ISO 8601 date/times over
reading
error messages saying the conversion wasn’t possible, right?
tools/inspect/utils.vala | 14 ++++++++++++++
1 file changed, 14 insertions(+)
commit 0e729d7be7f3431922aa531704aad897c0bb598b
Author: Philip Withnall <philip@tecnocode.co.uk>
Date: Mon Jun 18 10:31:54 2012 +0100
telepathy: Set some missing properties on cached TpfPersonas
Recently-added properties needed implementing for cached personas.
backends/telepathy/lib/tpf-persona.vala | 3 +++
1 file changed, 3 insertions(+)
commit 83ad58a85a2c623c66a3864f25b995f29b18ede6
Author: Jeremy Whiting <jpwhiting@kde.org>
Date: Fri Jun 15 10:10:32 2012 -0600
Bump version number post 0.7.1 release.
Add a new section to NEWS for 0.7.1 -> 0.7.2 changes.
NEWS | 10 ++++++++++
configure.ac | 4 ++--
2 files changed, 12 insertions(+), 2 deletions(-)