commit 2c58454a0b9ff212f33480a1ac6d14a813084831
Author: Stef Walter <stefw@gnome.org>
Date: 2012-11-21
Release version 3.7.2
NEWS | 7 +++++++
configure.ac | 2 +-
2 files changed, 8 insertions(+), 1 deletion(-)
commit a08eeffdcdda3ec69c77177927d78b2a282ef4a4
Author: Mathias Hasselmann <mathias@openismus.com>
Date: 2012-11-19
gck/gcr: Check result of write() in logger
* Recent versions of libc mark the write() system call with
the warn_unused_result attribute. This patch checks the
result and disables logging if write() failed.
https://bugzilla.gnome.org/show_bug.cgi?id=688684
gck/gck-debug.c | 7 ++++++-
gcr/gcr-debug.c | 7 ++++++-
2 files changed, 12 insertions(+), 2 deletions(-)
commit aeae080e778c5168eae22b3271d60fc6bc7e1482
Author: Stef Walter <stefw@gnome.org>
Date: 2012-11-09
gck: Remove duplicate defined symbol
* We shouldn't be defining the secure memory globals twice,
once in the gck library and once in its tests.
https://bugzilla.gnome.org/show_bug.cgi?id=687980
gck/tests/test-gck-attributes.c | 2 --
1 file changed, 2 deletions(-)
commit e186975ed53a897262fb455f5d7a8de842cdbfd2
Author: Stef Walter <stefw@gnome.org>
Date: 2012-11-07
egg-asn1x: More complete coverage for ASN.1 tests
* Remove or change code that doesn't get executed in normal
operation.
* Fix a few bugs discovered during the testing.
egg/egg-asn1x.c | 139 +++---
egg/tests/test-asn1.c | 1237 ++++++++++++++++++++++++++++++++++++++++++++---
egg/tests/test-asn1x.c | 58 +--
egg/tests/test-symkey.c | 4 +-
egg/tests/test.asn | 34 +-
5 files changed, 1306 insertions(+), 166 deletions(-)
commit b0bf0aeb6688c7ff3795f42f5e1a5bee27e52bf6
Author: Stef Walter <stefw@gnome.org>
Date: 2012-11-07
egg-asn1x: Fix corner case where long DER length overflows
* Better detection of the case where TLV length overflows
the size of an int.
egg/egg-asn1x.c | 34 +++++++++++++++++++++++-----------
1 file changed, 23 insertions(+), 11 deletions(-)
commit 1116d056d839443ddd6223605d6d3281668d9b66
Author: Stef Walter <stefw@gnome.org>
Date: 2012-11-07
egg-symkey: Complete tests for recent ASN.1 API changes
Since the ASN.1 API changed, we need to make sure things still work.
Add tests to ensure this. In addition rework code which is (or should
be) currently unreachable.
egg/egg-symkey.c | 37 +++--
egg/tests/test-symkey.c | 425 ++++++++++++++++++++++++++++++++++++++++++++++++
egg/tests/test.asn | 2 +
3 files changed, 446 insertions(+), 18 deletions(-)
commit d5e403890427e629c568f03a5823efb25175ee73
Author: Stef Walter <stefw@gnome.org>
Date: 2012-11-07
egg-asn1x: Bring over changes from gnome-keyring
egg/egg-asn1x.c | 17 ++++++++++++++++-
egg/egg-asn1x.h | 3 +++
2 files changed, 19 insertions(+), 1 deletion(-)
commit 2e11e75e3bcf0e47709959e0eae8c4a8aa295480
Author: Stef Walter <stefw@gnome.org>
Date: 2012-11-05
egg-asn1x: Fix crash when parsing invalid DER files
* When parsing invalid DER files and more than one sub-TLV is
encountered we would do a NULL dereference.
* Catch this condition and test for it.
egg/egg-asn1x.c | 8 ++++++++
egg/tests/test-asn1.c | 47 +++++++++++++++++++++++++++++++++++++++++++++++
2 files changed, 55 insertions(+)
commit b271623e5c3044099fdbae8e6037fd23e3eee5e9
Author: Stef Walter <stefw@gnome.org>
Date: 2012-11-07
egg-hex: Use a full string as the hex delimiter
So that we can better print out escape encodings in our test data.
egg/egg-hex.c | 29 ++++++++++++++++++-----------
egg/egg-hex.h | 4 ++--
egg/tests/test-hex.c | 8 ++++----
gck/gck-dump.c | 2 +-
gcr/gcr-certificate.c | 2 +-
gcr/gcr-display-view.c | 2 +-
gcr/gcr-gnupg-util.c | 2 +-
gcr/gcr-openpgp.c | 14 +++++++-------
gcr/tests/frob-certificate.c | 4 ++--
9 files changed, 37 insertions(+), 30 deletions(-)
commit 06defe293e5f71206971d37a4c0606f63a05d4a8
Author: Stef Walter <stefw@gnome.org>
Date: 2012-10-27
Merge secure memory changes from libsecret
egg/egg-secure-memory.c | 366 +++++++++++++++++++++++++-----------------------
egg/egg-secure-memory.h | 33 +++--
2 files changed, 213 insertions(+), 186 deletions(-)
commit ce0f9c79382830a50d19f0d66d1997476950074a
Author: Xi Wang <xi.wang@gmail.com>
Date: 2012-10-22
Fix incorrect loop condition in egg_hkdf_perform()
This does not cause a change in behavior (as evidenced by tests,
at least on linux when built with gcc) but is more correct code,
and less likely to be miscompiled.
The condition (i < 256) in the following loop is always false since i
is of type guchar, which is at most 255.
guchar i;
...
for (i = 1; i < 256; ++i) { ... }
This patch changes i to a larger type gint.
Also in the loop we have:
gcry_md_write (md2, &i, 1);
change it to use gcry_md_putc().
egg/egg-hkdf.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)