commit 12c4c56345b6d51c2b59947c2a86fcbddad61659
Author: Stef Walter <stefw@gnome.org>
Date: 2012-11-21
Release version 3.7.2
NEWS | 9 +++++++++
configure.ac | 2 +-
2 files changed, 10 insertions(+), 1 deletion(-)
commit 6f7ee2da70cf39b7e8ef2f2482a77b88fa60ed53
Author: Stef Walter <stefw@gnome.org>
Date: 2012-11-07
egg-asn1x: More complete coverage for ASN.1 tests
* Remove or change code that doesn't get executed in normal
operation.
* Fix a few bugs discovered during the testing.
egg/egg-asn1x.c | 139 ++-
egg/tests/Makefile.am | 18 +-
egg/tests/files/test-personalname-1.der | 1 -
egg/tests/files/test-personalname-invalid.der | 1 +
egg/tests/test-asn1.c | 1237 +++++++++++++++++++++++--
egg/tests/test-asn1x.c | 58 +-
egg/tests/test-symkey.c | 4 +-
egg/tests/test.asn | 34 +-
pkcs11/gkm/gkm-data-der.c | 9 +-
pkcs11/gkm/tests/test-data-der.c | 4 +-
pkcs11/xdg-store/tests/dump-trust-file.c | 11 +-
pkcs11/xdg-store/tests/frob-trust-file.c | 3 +-
12 files changed, 1326 insertions(+), 193 deletions(-)
commit 0023ffdf3fa02785ec1982b851a372f138297452
Author: Stef Walter <stefw@gnome.org>
Date: 2012-11-07
egg-asn1x: Fix corner case where long DER length overflows
* Better detection of the case where TLV length overflows
the size of an int.
egg/egg-asn1x.c | 34 +++++++++++++++++++++++-----------
1 file changed, 23 insertions(+), 11 deletions(-)
commit e078e8a79015176158c195e3016578d4b030a0e4
Author: Stef Walter <stefw@gnome.org>
Date: 2012-11-07
egg-symkey: Complete tests for recent ASN.1 API changes
Since the ASN.1 API changed, we need to make sure things still work.
Add tests to ensure this. In addition rework code which is (or should
be) currently unreachable.
egg/egg-symkey.c | 37 +++--
egg/tests/test-symkey.c | 425 ++++++++++++++++++++++++++++++++++++++++++++++++
egg/tests/test.asn | 2 +
3 files changed, 446 insertions(+), 18 deletions(-)
commit 46e5c1ee631146bddd7f8309ffcc05c4aa8a757f
Author: Stef Walter <stefw@gnome.org>
Date: 2012-11-05
egg-asn1x: Fix crash when parsing invalid DER files
* When parsing invalid DER files and more than one sub-TLV is
encountered we would do a NULL dereference.
* Catch this condition and test for it.
egg/egg-asn1x.c | 8 ++++++++
egg/tests/test-asn1.c | 47 +++++++++++++++++++++++++++++++++++++++++++++++
2 files changed, 55 insertions(+)
commit f7d5a800efa856a27ca16378d6bbe9fcb42e501a
Author: Stef Walter <stefw@gnome.org>
Date: 2012-10-27
Bring in fixed ASN.1 parser from gcr library
egg/egg-asn1x.c | 3146 ++++++++++++++++--------------
egg/egg-asn1x.h | 60 +-
egg/egg-dn.c | 50 +-
egg/egg-dn.h | 4 +-
egg/egg-symkey.c | 82 +-
egg/egg-symkey.h | 12 +-
egg/tests/test-asn1.c | 93 +-
egg/tests/test-asn1x.c | 140 +-
egg/tests/test-dn.c | 19 +-
egg/tests/test.asn | 3 +-
pkcs11/gkm/gkm-certificate.c | 4 +-
pkcs11/gkm/gkm-data-asn1.c | 2 +-
pkcs11/gkm/gkm-data-der.c | 48 +-
pkcs11/gkm/tests/test-data-der.c | 4 +-
pkcs11/xdg-store/gkm-xdg-trust.c | 8 +-
pkcs11/xdg-store/tests/frob-trust-file.c | 8 +-
16 files changed, 1935 insertions(+), 1748 deletions(-)
commit a901798e025389f3c4414406b6144687f85aa552
Author: Stef Walter <stefw@gnome.org>
Date: 2012-11-07
egg-hex: Use a full string as the hex delimiter
So that we can better print out escape encodings in our test data.
egg/egg-hex.c | 29 ++++++++++++++++++-----------
egg/egg-hex.h | 4 ++--
egg/tests/test-hex.c | 8 ++++----
pkcs11/gnome2-store/gkm-gnome2-file.c | 2 +-
4 files changed, 25 insertions(+), 18 deletions(-)
commit 6beae07105e368a529db85b227f60fa4b60bb397
Author: Stef Walter <stefw@gnome.org>
Date: 2012-11-07
egg-hex: Bring over hex changes from gcr and libsecret
egg/egg-hex.c | 28 +++++++++++++++-------------
egg/egg-hex.h | 22 ++++++++++++----------
egg/tests/test-hex.c | 8 +++++++-
3 files changed, 34 insertions(+), 24 deletions(-)
commit ac2df1e5a7862fa9a9b838406472e2c75b8575b3
Author: Stef Walter <stefw@gnome.org>
Date: 2012-11-09
dbus: Handle empty secrets correctly
* Don't assume an error occurred when retrieving an empty
secret from the store.
https://bugzilla.gnome.org/show_bug.cgi?id=687979
daemon/dbus/gkd-secret-session.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
commit 370694b36f1ed6f26554ccc740da3b3e92aafded
Author: Rex Dieter <rdieter@fedoraproject.org>
Date: 2012-08-17
only print debug message if no pkcs11 socket
This is to handle the case of running gnome-keyring in environments
not matching GNOME;Unity and avoid needless
WARNING: couldn't connect to: /tmp/keyring-SqfLpI/pkcs11
type errors
https://bugzilla.gnome.org/show_bug.cgi?id=665961
pkcs11/rpc-layer/gkm-rpc-module.c | 18 ++++++++++++++++--
1 file changed, 16 insertions(+), 2 deletions(-)
commit 3ad60838447f5badd11d98447f13ad8e78786242
Author: Stef Walter <stefw@gnome.org>
Date: 2012-10-27
Merge secure memory changes from libsecret
egg/egg-secure-memory.c | 366 +++++++++++++++++++++++++-----------------------
egg/egg-secure-memory.h | 33 +++--
egg/tests/test-secmem.c | 19 +--
3 files changed, 224 insertions(+), 194 deletions(-)
commit 3156ac7c5e20e7fd2cb7096d6401165fb033ee78
Author: Xi Wang <xi.wang@gmail.com>
Date: 2012-10-22
Fix incorrect loop condition in egg_hkdf_perform()
This does not cause a change in behavior (as evidenced by tests,
at least on linux when built with gcc) but is more correct code,
and less likely to be miscompiled.
The condition (i < 256) in the following loop is always false since i
is of type guchar, which is at most 255.
guchar i;
...
for (i = 1; i < 256; ++i) { ... }
This patch changes i to a larger type gint.
Also in the loop we have:
gcry_md_write (md2, &i, 1);
change it to use gcry_md_putc().
egg/egg-hkdf.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)