commit b27805dc163dff4d7b301b9be10a8d29b54a8a91
Author: David King <amigadave@amigadave.com>
Date: Wed Feb 19 20:20:58 2014 +0000
Update NEWS for 2.1.10 release
M AUTHORS
M NEWS
M SOURCES
M THANKS
M configure.ac
commit a80df787d0389ced85c838c2f99494136dda2772
Author: Piotr Drąg <piotrdrag@gmail.com>
Date: Wed Feb 19 21:13:51 2014 +0100
Updated Polish translation
M po/pl.po
commit 42ecdcda50fd047bf2f2466d112a3746edde8611
Author: David King <amigadave@amigadave.com>
Date: Wed Feb 19 19:50:50 2014 +0000
Add Help item to About menu
M src/bar.c
M src/bar.h
M src/misc.c
M src/misc.h
M src/ui_manager.h
commit 6b8f7464f74fbafd8ccce4861694ea2c6b9ca6a7
Author: David King <amigadave@amigadave.com>
Date: Wed Feb 19 18:00:11 2014 +0000
Use LOCALAPPDATA for NSIS user data uninstall
M easytag-win32-installer.nsi.in
commit 9eda06ce6518075c8d93dbec9a73b35e1f0ce828
Author: David King <amigadave@amigadave.com>
Date: Wed Feb 19 17:55:00 2014 +0000
Launch application after NSIS installation
M easytag-win32-installer.nsi.in
commit 2373022ee3a5cb7b1cca82d1d2ed2f488a98843f
Author: David King <amigadave@amigadave.com>
Date: Wed Feb 19 17:23:41 2014 +0000
Default to an icons style toolbar on Windows
M easytag-win32-installer.nsi.in
commit 56ff61aff7e6fc20a0496a1eaa74e4106a101edd
Author: David King <amigadave@amigadave.com>
Date: Wed Feb 19 17:21:34 2014 +0000
Add folder icons and emblem to NSIS installer
M easytag-win32-installer.nsi.in
commit 6d28bb7afe5ffe11bd23f9b0d365b0bea6d1d6fa
Author: David King <amigadave@amigadave.com>
Date: Tue Feb 18 22:34:33 2014 +0000
Refactor process spawning code
Refactor the process spawning code so that it handles additional
arguments, as it did before switching to use g_spawn_async(). Use a
single et_run_program() method for spawning processes, and merge the
existing implementations.
M src/browser.c
M src/misc.c
M src/misc.h
commit 0f55daa993955f0b07a8164d4d0393083c3f528d
Author: David King <amigadave@amigadave.com>
Date: Fri Feb 7 17:03:27 2014 +0000
Use g_spawn_async() on Windows
Remove Windows-specific code to spawn processes. Bundle the GLib spawn
helper in the Windows installer.
M TODO
M easytag-win32-installer.nsi.in
M src/browser.c
M src/misc.c
commit 89711f22cb736d979612f1f55e447cc3338bc7d7
Author: Abhinav <abhijangda@hotmail.com>
Date: Tue Feb 18 20:05:34 2014 +0530
Use GFileInfo instead of stat() in prefs.c
https://bugzilla.gnome.org/show_bug.cgi?id=724608
M src/prefs.c
commit 3313129cb0e750dd1817c11f4f1ce187d005abd2
Author: David King <amigadave@amigadave.com>
Date: Sun Feb 16 21:09:46 2014 +0000
Fix memory leak in Create_Tag_Area()
M src/easytag.c
commit aa20526caa45d213cf36b18c27bfbffc3618eccc
Author: David King <amigadave@amigadave.com>
Date: Sun Feb 16 21:06:32 2014 +0000
Avoid critical warnings with invalid default path
Rather than calling Browser_Tree_Select_Dir() directly, call
g_application_open() to use the same open codepath throughout.
https://bugzilla.redhat.com/show_bug.cgi?id=1065765
M src/browser.c
commit 2c803c58791645af443a20039df1b9478f83c0ff
Author: Abhinav <abhijangda@hotmail.com>
Date: Sun Feb 16 18:11:43 2014 +0530
Convert stat() usage to GFileInfo in et_core.c
Found with Coverity (CID 1163367 and CID 1163368)
https://bugzilla.gnome.org/show_bug.cgi?id=724461
M src/et_core.c
commit c4da4b18295afb94a985b7b81858f3bc0ee1e925
Author: David King <amigadave@amigadave.com>
Date: Sat Feb 15 23:18:38 2014 +0000
Remove bogus comparison in Id3tag_Read_File_Tag
Found with cppcheck.
M src/id3v24_tag.c
commit 618700ae5bfa971a895e567a01b50de3e683905b
Author: Aurimas Černius <aurisc4@gmail.com>
Date: Sat Feb 15 19:16:12 2014 +0200
Updated Lithuanian translation
M po/lt.po
commit 91cef7e1d57fb7aae65b209d4aecf4c70d68d0a3
Author: Abhinav <abhijangda@hotmail.com>
Date: Sat Feb 15 12:11:15 2014 +0530
Convert stat() to GFileInfo in Save_List_Of_Files
https://bugzilla.gnome.org/show_bug.cgi?id=724400
M src/easytag.c
commit 4381597a181c96b8786857825eb8f9b05bb48e50
Author: Abhinav <abhijangda@hotmail.com>
Date: Fri Feb 14 19:59:23 2014 +0530
Use GFileInfo instead of stat() in src/browser.c
The lack of error-checking in expand_cb() was found by Coverity (CID
1163359).
https://bugzilla.gnome.org/show_bug.cgi?id=724357
M src/browser.c
commit 80a649add920eb716818381b9b29599782698910
Author: David King <amigadave@amigadave.com>
Date: Thu Feb 13 18:47:12 2014 +0000
Replace use of stat() in file list ctime sorting
Use GFileInfo to query the ctime attribute, and explicitly ignore
errors.
Found with Coverity (CID 1163370).
M src/et_core.c
commit 81a1e7cf4bcb7897abd7c7ac4f6bfe0f0a038395
Author: Abhinav <abhijangda@hotmail.com>
Date: Thu Feb 13 19:27:48 2014 +0530
Only add dummy browser row if the path is readable
Prevent empty rows from appearing in the browser when parent
directories
are deleted externally. Additionally, delete the parent directory from
the tree if it is not found.
https://bugzilla.gnome.org/show_bug.cgi?id=722380
M src/browser.c
commit a220a6d4c0bd51bd8e532ec863af8ead299de8af
Author: David King <amigadave@amigadave.com>
Date: Tue Feb 11 19:25:33 2014 +0000
Use g_format_size() instead of custom code
Replace Convert_Size() and Convert_Size_1() with g_format_size() to
avoid potential invalid memory accesses.
Found with Coverity (CID 1163338 and CID 1163339).
M src/cddb.c
M src/et_core.c
M src/flac_header.c
M src/misc.c
M src/misc.h
M src/monkeyaudio_header.c
M src/mp4_header.c
M src/mpeg_header.c
M src/musepack_header.c
M src/ogg_header.c
M src/picture.c
M src/wavpack_header.c
commit 2ab505068d708a1a81775df558fdcfc42612dceb
Author: David King <amigadave@amigadave.com>
Date: Tue Feb 11 19:05:44 2014 +0000
Remove a bogus sign check
Found with Coverity (CID 1163351).
M src/scan.c
commit b93a38b07fc9a6a7e655e61a502bbd3046114137
Author: David King <amigadave@amigadave.com>
Date: Tue Feb 11 18:59:02 2014 +0000
Remove bogus conditional check
Found with Coverity (CID 1163350).
M src/misc.c
commit aa8fb4b82606540c5edfd96aadcd12fbe7124c1a
Author: David King <amigadave@amigadave.com>
Date: Tue Feb 11 18:41:55 2014 +0000
Remove a bogus GtkTreeIter assignment
Found with Coverity (CID 1163324).
M src/cddb.c
commit 09f96fd0c9056c48e041fc3ec92a845c6840eeae
Author: David King <amigadave@amigadave.com>
Date: Tue Feb 11 10:27:42 2014 +0000
Fix memory leak in et_get_file_size()
Unref the GFileInfo and GFile after use.
M src/misc.c
commit ae3dd7b81ba283ba0e9ea3d4aff326deedcc077e
Author: Santtu Lakkala <inz@inz.fi>
Date: Tue Feb 11 10:16:37 2014 +0000
Fix two memory leaks in scanner
Free the result of g_utf8_strup() in
Scan_Process_Fields_First_Letters_Uppercase() Roman numeral handling.
M src/scan.c
commit d7bda2d1681f4c52920a0b6d83ce66f610da849c
Author: David King <amigadave@amigadave.com>
Date: Mon Feb 10 22:34:55 2014 +0000
Add estimated size to NSIS installer
Additionally, use MUI2 rather than MUI, which should be faster.
M easytag-win32-installer.nsi.in
commit 16a66debb404726c34331c6159e32bf99ff107a5
Author: David King <amigadave@amigadave.com>
Date: Mon Feb 10 20:06:06 2014 +0000
Check iter in Browser_Tree_Rename_Directory
Found with Coverity (CID 1163371).
M src/browser.c
commit 15fc326f8eda8f3df86d31d9dd362efae66fd2de
Author: David King <amigadave@amigadave.com>
Date: Mon Feb 10 20:01:49 2014 +0000
Check for a valid iter in Browser_Tree_Select_Dir
Found with Coverity (CID 1163372).
M src/browser.c
commit 7bfab6120fed8d56019056daf937c6a7011effff
Author: David King <amigadave@amigadave.com>
Date: Mon Feb 10 18:08:52 2014 +0000
Do not override the primary toolbar style
Users should be able to override the style of the primary toolbar.
M src/bar.c
commit ea8396a03888494c8b9bc14c572b058e237d9a74
Author: David King <amigadave@amigadave.com>
Date: Mon Feb 10 17:15:49 2014 +0000
Remove Quit action from toolbar
Having an infrequently-used item such as Quit on the toolbar is
against
the toolbar guidelines in the GNOME HIG:
https://developer.gnome.org/hig-book/stable/toolbars-appearance.html
M src/ui_manager.h
commit 7f4d721a8f4dcfa7c099a4d7125c11941c1dc611
Author: David King <amigadave@amigadave.com>
Date: Thu Feb 6 23:07:28 2014 +0000
Fix context menu shortcut in NSIS installer
https://bugzilla.gnome.org/show_bug.cgi?id=723795
M easytag-win32-installer.nsi.in
commit 23517574058cd25e07777326dcff8bcbbbb5472f
Author: Marek Černocký <marek@manet.cz>
Date: Sun Feb 9 09:23:05 2014 +0100
Updated Czech translation
M po/cs.po
commit 1a9f7b798082c9e398bcd9b85deb66fbb1de91ba
Author: Piotr Drąg <piotrdrag@gmail.com>
Date: Sun Feb 9 01:52:25 2014 +0100
Updated Polish translation
M po/pl.po
commit 240bc63b4f67d98cf94f55a7a385b5a9dd0e100b
Author: David King <amigadave@amigadave.com>
Date: Sat Feb 8 23:11:13 2014 +0000
Return 0 from et_get_file_size() on error
Found by Coverity (CID 1170175).
M src/misc.c
commit 02d199b2cac7c34b36cb534a48eda32172efb941
Author: David King <amigadave@amigadave.com>
Date: Wed Jan 22 17:37:28 2014 +0000
Add AppData XML using APPDATA_XML macro
M .gitignore
M Makefile.am
M README
M configure.ac
A data/easytag.appdata.xml.in
M po/POTFILES.in
commit 6c70f15269bd66936b2e7d65e62c8a80bc38fc9f
Author: David King <amigadave@amigadave.com>
Date: Thu Feb 6 22:56:09 2014 +0000
Do not unref GFile in GApplication::open handler
https://retrace.fedoraproject.org/faf/problems/1504917/
M src/easytag.c
commit c01a3ee46ca0b8e35fafa5008d5b6ef5e8e66592
Author: David King <amigadave@amigadave.com>
Date: Thu Feb 6 22:32:11 2014 +0000
Avoid a crash when handling invalid arguments
Do not try to dereference a NULL ETCore pointer.
M src/et_core.c
commit 712bbffee0243317baf0644dd84c6fca8789b6d2
Author: David King <amigadave@amigadave.com>
Date: Thu Feb 6 23:38:43 2014 +0000
Clear the statusbar timeout ID when it expires
Avoids a critical warning that the source had already been removed.
M src/bar.c
commit 076d45f59d5eaa57a33961acfe928ad99b898c20
Author: David King <amigadave@amigadave.com>
Date: Thu Feb 6 10:41:18 2014 +0000
Add id3lib and libid3tag to Windows installer
Additionally, update SOURCES.
M SOURCES
M easytag-win32-installer.nsi.in
commit 200562fce40833510713a1f0b71092821984ae66
Author: David King <amigadave@amigadave.com>
Date: Mon Feb 3 16:54:59 2014 +0000
Replace use of stat() in Get_File_Size()
Use g_file_info_get_size() and check for errors, instead of calling
stat(). Rename Get_File_Size() to et_get_file_size().
Found with Coverity (CID 1163369).
M src/flac_header.c
M src/misc.c
M src/misc.h
M src/mp4_header.c
M src/mpeg_header.c
M src/ogg_header.c
commit 7305451e0e967a2fdd5e0d59e364357a9a338fcb
Author: David King <amigadave@amigadave.com>
Date: Mon Feb 3 16:31:46 2014 +0000
Remove bogus conditional check in settings parser
Found with Coverity (CID 1163352).
M src/setting.c
commit ebb19c7ed0f60156224c01bdca43a2212d933617
Author: David King <amigadave@amigadave.com>
Date: Mon Feb 3 16:28:23 2014 +0000
Add a comment about id3_file_fdopen()
Passing a file descriptor to id3_file_fdopen() causes it to take
ownership of the descriptor, so that only a matching id3_file_close()
is
required to close the resulting file.
Found with Coverity (CID 1163335).
M src/id3v24_tag.c
commit 2e07b5f5c8970a6e26e14723e25f1292ba7e6d1d
Author: David King <amigadave@amigadave.com>
Date: Mon Feb 3 22:34:16 2014 +0000
Remove gettimeofday and pid_t configure.ac checks
M configure.ac
commit 1d0a255ca85d964141945a29f6e92d2ba0d89714
Author: David King <amigadave@amigadave.com>
Date: Mon Feb 3 22:30:28 2014 +0000
Fix memory leak in Parse_Date()
M src/misc.c
commit d7bd51145e045a31e2e0be05f73c0b3b09f553a5
Author: Rafael Ferreira <rafael.f.f1@gmail.com>
Date: Sun Feb 2 14:15:11 2014 +0000
Updated Brazilian Portuguese translation
M po/pt_BR.po
commit 8db3b218984ff1b1d1568de6e3d9a692a4702304
Author: David King <amigadave@amigadave.com>
Date: Wed Jan 29 13:47:21 2014 +0000
Add programming language to DOAP file
M easytag.doap
commit 90e2f4edf99408225e931e051bb4ffc7badcac2a
Author: Мирослав Николић <miroslavnikolic@rocketmail.com>
Date: Tue Jan 28 17:59:03 2014 +0100
Updated Serbian translation
M po/sr.po
M po/sr@latin.po
commit 6b01c678f92cc4f554e98840523bff2bac6903f3
Author: Marek Černocký <marek@manet.cz>
Date: Sat Jan 25 22:39:58 2014 +0100
Updated Czech translation
M po/cs.po
commit d744a661921a9aa678fe0ebdc38ebb7f5ae0942c
Author: Piotr Drąg <piotrdrag@gmail.com>
Date: Wed Jan 22 02:14:12 2014 +0100
Updated Polish translation
M po/pl.po
commit afad898b0394b6eafeaf6f89cf411ac5c0e96ab0
Author: David King <amigadave@amigadave.com>
Date: Tue Jan 21 19:42:09 2014 +0000
Fix memory leak in Log_Format_Date()
M src/log.c
commit c9d92605a62206a9046770d947ac7c6ff57e99bc
Author: David King <amigadave@amigadave.com>
Date: Tue Jan 21 19:28:48 2014 +0000
Use g_spawn_async() to launch media player
M src/misc.c
commit c04889482be6f2b6baa20b321cf2581dc606c8ff
Author: David King <amigadave@amigadave.com>
Date: Tue Jan 21 19:18:37 2014 +0000
Use g_spawn_async() to launch open with process
M src/browser.c
M src/misc.c
M src/misc.h
commit b698dad4c31ffc702121cc06200ff1a0e1e89864
Author: David King <amigadave@amigadave.com>
Date: Tue Jan 21 16:21:32 2014 +0000
Remove Unix signal handlers, bug 721943
M src/easytag.c
commit dd4f3bd815bd186e3e58752e0ac7999c6c645fd7
Author: David King <amigadave@amigadave.com>
Date: Sun Jan 19 09:26:57 2014 +0000
Check for failure of g_output_stream_write_all()
Flip an incorrect check for the return value of
g_output_stream_write_all() when svaing Vorbis tags. Fixes bug 722522.
M src/vcedit.c
commit 192aa2201320bcc2d7b5bcf64fa3a015c21478b3
Author: David King <amigadave@amigadave.com>
Date: Thu Jan 16 21:30:36 2014 +0000
Avoid unreffing a NULL GFileInfo in the browser
M src/browser.c
commit bdb4476177a06c7bbd15ea90229d3056a6a95d7a
Author: David King <amigadave@amigadave.com>
Date: Mon Jan 6 09:03:37 2014 +0000
Update Santtu Lakkala's email address
M AUTHORS
M src/about.c
M src/dlm.c
M src/dlm.h
commit 7b487c7571bc6b65759cd0673de4c223e00b6297
Author: David King <amigadave@amigadave.com>
Date: Fri Jan 3 10:44:29 2014 +0000
Clarify licensing of dlm.c and dlm.h, bug 721385
Signed-off-by: Santtu Lakkala <inz@inz.fi>
M src/dlm.c
M src/dlm.h
commit 7cadc2e0a6eb2e5929f5c82e903ed92b978433f9
Author: Wolfgang Stöggl <c72578@yahoo.de>
Date: Sun Jan 5 09:05:35 2014 +0100
[l10n] Updated German translation
M po/de.po
commit 109681d07d7af62fb5f0ca46cb9bfbfc4d4b4839
Author: David King <amigadave@amigadave.com>
Date: Sat Jan 4 15:39:25 2014 +0000
Update copyright year in about dialogue
M src/about.c