commit bec4bdd64f7650e0051f90d198ab3e6ee9a4dfb3
Author: David King <amigadave@amigadave.com>
Date: Fri Feb 6 17:49:05 2015 +0000
Update NEWS for 2.3.4 release
M NEWS
M configure.ac
commit a2d8e7a5c8cb4541666e7c3156ab1e87078ec015
Author: David King <amigadave@amigadave.com>
Date: Fri Feb 6 17:45:09 2015 +0000
Fix redefinition warning from TagLib
https://github.com/taglib/taglib/commit/7d7a7be115976d31715b7d4051d50249f32d2a05
M src/tags/mp4_tag.cc
commit ecf346d48f601c5c1c42a772338bef5f34ef2e99
Author: David King <amigadave@amigadave.com>
Date: Fri Feb 6 17:31:35 2015 +0000
Fix redefinition warning in Windows compat code
Only define a custom mkstemp() or truncate() if the functions are not
available.
M src/win32/win32dep.c
M src/win32/win32dep.h
commit 44ee9ec20ce2f6dd0810a0abf268cd0209783d92
Author: David King <amigadave@amigadave.com>
Date: Thu Jan 8 20:03:47 2015 +0000
Remove several unused functions
Found with the -fdata-sections and -ffunction-sections arguments
to the
compiler, and --gc-sections and --print-gc-sections linker arguments.
M src/application_window.c
M src/application_window.h
M src/charset.c
M src/charset.h
M src/misc.c
M src/misc.h
M src/preferences_dialog.c
M src/scan_dialog.c
M src/scan_dialog.h
commit 8a94b7defb5600919930434410f69eb1bdbf7697
Author: David King <amigadave@amigadave.com>
Date: Wed Jan 7 21:02:58 2015 +0000
Refactor several file list functions
Accept a file list as the first parameter, and return the list pointer
as necessary.
M src/application_window.c
M src/browser.c
M src/easytag.c
M src/file.c
M src/file_list.c
M src/file_list.h
M src/tag_area.c
commit e319c907d92245ac581258d43e4e8491a1830090
Author: David King <amigadave@amigadave.com>
Date: Wed Jan 7 20:46:44 2015 +0000
Remove unused displayed list function
M src/file_list.c
M src/file_list.h
commit f6f2e4d32fd037960db81b6fba32abb21380d154
Author: David King <amigadave@amigadave.com>
Date: Mon Jan 5 23:24:14 2015 +0000
Refactor artist album file list functions
Take a file list as the first parameter.
M src/browser.c
M src/file_list.c
M src/file_list.h
commit e9225a10b223f6ac1a5ffb9e15c882b273846373
Author: David King <amigadave@amigadave.com>
Date: Mon Jan 5 22:48:49 2015 +0000
Refactor file list freeing functions
Accept the list to be freed as a parameter. Zero out the list
pointer in
ET_Core_Free() instead of in the list freeing functions.
M src/et_core.c
M src/file_list.c
M src/file_list.h
commit 4d2e91f89457275b7527209605644d1074ecc318
Author: David King <amigadave@amigadave.com>
Date: Mon Jan 5 21:27:34 2015 +0000
Refactor function to check if all files are saved
Accept the file list as a parameter.
M src/application_window.c
M src/browser.c
M src/file_list.c
M src/file_list.h
commit 8097699d1170248d09721bfda9baf8a747fe5085
Author: David King <amigadave@amigadave.com>
Date: Wed Feb 4 08:28:32 2015 +0000
Use AX_GENERATE_CHANGELOG
Use the upstream autoconf archive ChangeLog generation macro, rather
than a custom equivalent.
M Makefile.am
M configure.ac
A m4/ax_generate_changelog.m4
commit 7f2d67b9a02a6c4d5f6cae10b012d9fc86f821a7
Author: David King <amigadave@amigadave.com>
Date: Tue Feb 3 23:17:12 2015 +0000
Use AX_IS_RELEASE to control compiler warnings
Make compiler warnings non-fatal for release builds (those in which a
git directory is not present).
M configure.ac
A m4/ax_is_release.m4
commit 3aaf603fb5579ba547f2295c541f4887cae7e161
Author: David King <amigadave@amigadave.com>
Date: Sat Jan 31 14:08:56 2015 +0100
Port to AX_COMPILER_FLAGS
M configure.ac
A m4/ax_append_compile_flags.m4
A m4/ax_append_flag.m4
A m4/ax_check_compile_flag.m4
A m4/ax_check_enable_debug.m4
A m4/ax_compiler_flags.m4
A m4/ax_compiler_flags_cflags.m4
A m4/ax_compiler_flags_cxxflags.m4
A m4/ax_compiler_flags_gir.m4
A m4/ax_compiler_flags_ldflags.m4
A m4/ax_require_defined.m4
commit 127157defbb9965c2cd5d0a591fd8a24336f3c57
Author: David King <amigadave@amigadave.com>
Date: Fri Jan 30 14:10:57 2015 +0000
Fix const correctness warnings
M src/file_area.c
M src/scan_dialog.c
M src/tag_area.c
M src/tags/ogg_header.c
commit e0a9c2f75c9a65d1bd4508dbde46abc0d1742106
Author: David King <amigadave@amigadave.com>
Date: Fri Jan 30 13:53:50 2015 +0000
Fix sign comparison warnings
M src/cddb_dialog.c
M src/charset.c
M src/charset.h
M src/core_types.h
M src/file.c
M src/file.h
M src/log.c
M src/scan_dialog.c
M src/tags/id3v24_tag.c
commit 9110197224fb3084b926828c9a1466e89d1b5390
Author: David King <amigadave@amigadave.com>
Date: Fri Jan 30 13:50:17 2015 +0000
Avoid old-style function declaration
M src/application.c
M src/log.c
commit e90a7e842f459fd3354d5de9f9da8410de143386
Author: David King <amigadave@amigadave.com>
Date: Fri Jan 30 13:49:40 2015 +0000
Avoid unhandled switch cases warning
M src/application.c
M src/picture.c
M src/playlist_dialog.c
M src/scan_dialog.c
M src/tag_area.c
M src/tags/flac_header.c
M src/tags/flac_tag.c
M src/tags/id3_tag.c
M src/tags/id3v24_tag.c
M src/tags/mp4_tag.cc
M src/tags/mpeg_header.c
M src/tags/ogg_header.c
M src/tags/vcedit.c
commit 6f19b8589cb2857c646dbdc443108026ccd62d09
Author: David King <amigadave@amigadave.com>
Date: Fri Jan 30 13:43:57 2015 +0000
Avoid shadowed variable warnings
M src/application_window.c
M src/cddb_dialog.c
M src/charset.c
M src/easytag.c
M src/file.c
M src/file_list.c
M src/log.c
M src/playlist_dialog.c
M src/scan_dialog.c
M src/tags/gio_wrapper.cc
M src/tags/id3_tag.c
M src/tags/id3v24_tag.c
M src/tags/libapetag/apetaglib.c
M src/tags/mp4_tag.cc
M src/tags/ogg_tag.c
M src/tags/vcedit.c
commit 0a6d0228a7cd2ea8a92fe502f15d07a09a44d4f0
Author: David King <amigadave@amigadave.com>
Date: Fri Jan 30 13:35:25 2015 +0000
Add missing default cases in switch statements
M src/application_window.c
M src/browser.c
M src/cddb_dialog.c
M src/file_list.c
M src/load_files_dialog.c
M src/playlist_dialog.c
M src/scan_dialog.c
M src/tag_area.c
M src/tags/opus_header.c
M src/tags/vcedit.c
commit 2db55ba7ecf762762bf95d27c673dd16bf1110c8
Author: David King <amigadave@amigadave.com>
Date: Fri Jan 30 13:31:15 2015 +0000
Remove redundant declaration
M src/file_list.h
M src/scan_dialog.c
commit 91e48e8a6cdc551cb6e0220591a3b3d7350ee9c0
Author: David King <amigadave@amigadave.com>
Date: Fri Jan 30 14:26:19 2015 +0000
Handle OptimFrog files as if they are unknown
M src/file.c
M src/file_list.c
commit 65435b7197b5edf8404da3dee5ec633bbb5f9861
Author: David King <amigadave@amigadave.com>
Date: Mon Feb 2 20:55:13 2015 +0000
Fix compilation of misc test
M tests/test-misc.c
commit 2703196a5c7446c0873aa71bdd3d26428ed53296
Author: David King <amigadave@amigadave.com>
Date: Thu Jan 22 16:32:20 2015 +0000
Remove unnecessary NULL check in CDDB dialog
Found with Coverity (CID 1265641).
M src/cddb_dialog.c
commit 7c04a8693a4a05aa5a4d19e9ea65ffc3502e7a67
Author: David King <amigadave@amigadave.com>
Date: Thu Jan 22 16:31:55 2015 +0000
Add missing break in switch
Avoid an assert when opening Opus files.
Found with Coverity (CID 1265644).
M src/tags/vcedit.c
commit c47e1c630c7d510a33758e1886f2569bffd6e1f7
Author: Daniel Mustieles <daniel.mustieles@gmail.com>
Date: Mon Jan 12 19:13:06 2015 +0100
Updated Spanish translation
M po/es.po
commit 31b6782943c2470e71a83835b07f723046d23da2
Author: Christian Kirbach <christian.kirbach@gmail.com>
Date: Sun Jan 11 23:43:12 2015 +0100
Added German help translation
M help/Makefile.am
A help/de/de.po
commit 93b17aed08fae4c89739b7ad84419fb173ce2042
Author: David King <amigadave@amigadave.com>
Date: Fri Jan 9 18:54:12 2015 +0000
Simplify GtkFileFilter creation
M src/tag_area.c
commit 5709590dda8e909e5d0c85881aa1ced632d92e1b
Author: David King <amigadave@amigadave.com>
Date: Thu Jan 8 20:02:01 2015 +0000
Fix common symbol linker warnings
Found with the --warn-common linker argument.
M src/easytag.c
M src/easytag.h
M src/setting.c
M src/setting.h
commit debc2d333fa7a1679e4828f1d8f78f8a1546f7e2
Author: David King <amigadave@amigadave.com>
Date: Wed Jan 7 09:23:54 2015 +0000
Fix pointer arithmetic when reading CDDB result
Found with cppcheck.
M src/cddb_dialog.c
commit b8719737110fb33bd4c169308f9b316191beb9c1
Author: David King <amigadave@amigadave.com>
Date: Wed Jan 7 09:23:32 2015 +0000
Avoid an unnecessary variable assignment
Found with cppcheck.
M src/browser.c
commit ebe269ac7bedf4394f57db8712f8dfd402f2d5e3
Author: David King <amigadave@amigadave.com>
Date: Wed Jan 7 09:16:46 2015 +0000
Fix crash when saving FLAC tags
https://bugzilla.gnome.org/show_bug.cgi?id=742350
M src/tags/id3_tag.c
commit 9aad89da3bbe7c822eb12fb082e7d4a085eb3ed6
Author: David King <amigadave@amigadave.com>
Date: Mon Jan 5 00:09:36 2015 +0000
Refactor File_Tag copying functions
Change functions which accept ET_File for the purposes of copying a
File_Tag struct to instead use the File_Tag directly. Move the
declarations to file_tag.h.
M src/cddb_dialog.c
M src/file.c
M src/file.h
M src/file_tag.c
M src/file_tag.h
M src/scan_dialog.c
M src/tag_area.c
commit 5068f6537caa6748cf535405a6ef59776bb0f683
Author: David King <amigadave@amigadave.com>
Date: Sun Jan 4 22:24:36 2015 +0000
Update copyright year in about dialog
M src/about.c
commit f1b5b2ab94bdd5448e3415f1189c846fabfbcd36
Author: David King <amigadave@amigadave.com>
Date: Sun Jan 4 22:15:56 2015 +0000
Simplify ET_Copy_File_Tag_Item()
Use File_Tag setters to avoid code duplication.
M src/file_tag.c
commit c2d9b91f88f0255d4f54d48b1f108d7675c1ec56
Author: David King <amigadave@amigadave.com>
Date: Sun Jan 4 21:58:57 2015 +0000
Remove unnecessary et_file_tag_init()
Use g_slice_new0() to zero-initialize the File_Tag struct, and do away
with the separate function.
M src/file_tag.c
commit 4db3cfad59ada303745ca1d938daf0fdec92b88d
Author: David King <amigadave@amigadave.com>
Date: Sun Jan 4 21:51:44 2015 +0000
Use consistent naming for File_Tag methods
Use et_file_tag_ as a prefix for functions dealing with File_Tag
structs.
M src/application_window.c
M src/cddb_dialog.c
M src/file.c
M src/file_list.c
M src/file_tag.c
M src/file_tag.h
M src/scan_dialog.c
M src/tag_area.c
M src/tags/flac_tag.c
M src/tags/id3_tag.c
commit fda6ef148fa2c1f68494b17806d64083bc4a511a
Author: Marek Černocký <marek@manet.cz>
Date: Sun Jan 4 23:35:33 2015 +0100
Updated Czech translation
M help/cs/cs.po
commit 46ce097031559cf279f1d63c4fff25026ef2040e
Author: Marek Černocký <marek@manet.cz>
Date: Sun Jan 4 22:38:12 2015 +0100
Add Czech help translation
M help/Makefile.am
A help/cs/cs.po
commit 6224dff545be6ae7776d13f4ed37b148edd9c1a9
Author: David King <amigadave@amigadave.com>
Date: Sun Jan 4 14:26:40 2015 +0000
Relicense id3lib wrapper to GPLv2+
Invoke Section 3 of the LGPL, and apply the terms of the GPL to
all the
LGPL portions of id3lib code inside EasyTAG.
M src/tags/id3lib/c_wrapper.cpp
M src/tags/id3lib/id3_bugfix.h
commit 608a91f515004efe1ad44534e7cafc79c93e08e5
Author: David King <amigadave@amigadave.com>
Date: Sun Jan 4 12:07:19 2015 +0000
Check for a valid Vorbis comment image MIME type
M src/tags/ogg_tag.c
commit 8944602a8154fd7cbbaa6911e3f43b3e6f432368
Author: David King <amigadave@amigadave.com>
Date: Sun Jan 4 11:34:44 2015 +0000
Do some validation of Vorbis artwork field lengths
M src/tags/ogg_tag.c
commit 2024a4be439afd9cdf1b897e72bbda7b76052fdb
Author: David King <amigadave@amigadave.com>
Date: Sun Jan 4 10:41:11 2015 +0000
Check for an invalid field when reading Vorbis art
When reading cover art from Vorbis comments, check that the
Base64-decoded data is at least long enough to hold the
METADATA_BLOCK_PICTURE fields. Mark any invalid files as modified, so
that the invalid field is removed upon saving.
https://retrace.fedoraproject.org/faf2/problems/516585/
M src/tags/ogg_tag.c