commit 074348e9c0e3f3db597e3e3e3a94666bb17ea9d0 Author: David King Date: Mon Jan 25 23:01:06 2016 +0000 Update NEWS for 2.4.1 release M AUTHORS M NEWS M SOURCES M configure.ac commit 4fa035d37dd545f4492ce8380b237a67551aa0ff Author: David King Date: Mon Jan 25 21:14:36 2016 +0000 Refactor directory renaming Renaming directories broke when porting to use GFile for the current path. Fix this by refactoring the functions involved to use g_build_filename() and semantically-useful variable names. M src/browser.c commit d58e1e2f86589616ad4ce6a218f53ca25e97f079 Author: David King Date: Mon Jan 25 19:17:03 2016 +0000 Only show a locale log message if it is useful On Windows, check that the LANG environment variable is set before displaying its value in a log message. M src/application.c commit fabaccb3c1d0fa3a18641c7f1290ba982d106363 Author: David King Date: Mon Jan 25 18:54:25 2016 +0000 Use g_mkstemp() instead of mkstemp() As filenames are always in the GLib filename encoding, make sure to use the appropriate GLib function. M TODO M configure.ac M src/browser.c M src/misc.c M src/win32/win32dep.c M src/win32/win32dep.h commit 9e9b60157f9c4515fe5be1b72e24f63899ee8d8b Author: David King Date: Mon Jan 25 17:10:06 2016 +0000 Fix CDDB dialog flag controls Since commit bbf918f8427950734d0101ef2744fff57eaa4b7b, et_settings_flags_toggle_get() and et_settings_flags_toggle_set() expect widgets passed to them to have a "flags-key" data item to be set to the name of the appropriate setting. Make this so for the search fields and categories widgets. https://bugzilla.gnome.org/show_bug.cgi?id=761018 M src/cddb_dialog.c commit fa014e50ecdbd546f3b1a0e125f119ce8a60fce8 Author: David King Date: Mon Jan 25 17:05:56 2016 +0000 Remove some unwanted elements from the AppData Remove the donation and project group links, and reindent the file. M data/easytag.appdata.xml.in commit 9592ca3dc23e625df0435681c9b0b8ff31499a8b Author: David King Date: Fri Jan 22 16:02:51 2016 +0000 Avoid an unnecessary NULL check Found with Coverity (CID 1295129). M src/scan_dialog.c commit 59496c7e81894941f16dcf00e1bdcc4ebf519155 Author: David King Date: Thu Jan 21 19:23:06 2016 +0000 Test EtPicture comparisons in the FileTag tests M tests/test-file_tag.c commit 8d57f897546da32429b3311fd07efb229cd7fbb2 Author: David King Date: Wed Jan 20 17:32:41 2016 +0000 Refactor Browser_Tree_Handle_Rename() Avoid a bogus use of UTF-8 functions with strings in the GLib filename encoding. M src/browser.c commit a67fba24b9679429e08353fc1c1cf0b5f0aa7279 Author: David King Date: Tue Jan 19 16:52:21 2016 +0000 Convert Windows filename encoding for id3lib As id3lib does not use the wide character API on Windows, it expects filenames to be in the system codepage. Convert the GLib encoding to the system codepage before passing it to id3lib. M src/tags/id3_tag.c M src/tags/libapetag/id3v2_read.c M src/tags/mpeg_header.c M src/tags/opus_header.c commit 98001302f40c640446845e5334a7880eda6bb443 Author: Richard Hughes Date: Mon Jan 25 15:42:32 2016 +0000 Add a missing tag to the AppData file M data/easytag.appdata.xml.in commit 0a8d3554172f44d35024df75e672121435974b07 Author: Mario Blättermann Date: Sun Jan 24 17:22:28 2016 +0100 Updated German doc translation M help/de/de.po commit 6e1558aabece4d5c688e1e27c584812a557fc80e Author: Aurimas Černius Date: Sat Jan 23 17:41:34 2016 +0200 Updated Lithuanian translation M po/lt.po commit eae0cc672db9f058e2af873cf7f5e0c14eb27dbf Author: Richard Hughes Date: Fri Jan 22 19:37:29 2016 +0000 Update the AppData file to spec version 0.7+ M data/easytag.appdata.xml.in commit e80ec2317bcb63cd468c55774fa145e6397a11ca Author: Mario Blättermann Date: Thu Jan 21 21:34:47 2016 +0100 Updated German doc translation M help/de/de.po commit 1ec85412c79601db4606cfa799883ebe96575f6c Author: David King Date: Tue Jan 19 19:03:13 2016 +0000 Fix compiler warning in tests Pass a GError ** to g_close(). M tests/test-misc.c commit 5e74546aec8ce4721d52480b1c55bd231e2bc39f Author: David King Date: Tue Jan 19 16:49:57 2016 +0000 Use g_open() instead of open() Ensure that filenames are kept in the GLib filename encoding. Additionally, use id3_file_fdopen() rather than id3_file_open() to ensure that the GLib filename encoding is used when reading ID3 tags. M src/tags/id3v24_tag.c M src/tags/libapetag/info_mac.c M src/tags/libapetag/info_mpc.c M src/win32/win32dep.c commit 99890b917c6ce9814cdc7361d3ad951fc3216973 Author: David King Date: Tue Jan 19 16:48:10 2016 +0000 Use g_close() instead of close() Available since GLib 2.36, g_close() provides a portable wrapper around close(). M src/browser.c M src/misc.c M tests/test-misc.c commit 238b1e3da15de8acd4ebad4749feb6751371b11c Author: David King Date: Sun Jan 17 19:35:05 2016 +0000 Fix typo in ID3v2.4 code comment M src/tags/id3v24_tag.c commit 21c01d25d067afcc32876fb545ceea834ef912be Author: David King Date: Sat Jan 16 00:14:30 2016 +0000 Replace g_utf8_str[r]chr() usage with str[r]chr() If looking for an ASCII character, it is simpler to use the string functions from the C library. M src/cddb_dialog.c M src/file_area.c M src/misc.c M src/scan.c M src/tag_area.c M src/tags/ape_tag.c M src/tags/flac_tag.c M src/tags/id3v24_tag.c M src/tags/ogg_tag.c M src/tags/wavpack_tag.c commit 063dbf2346aac6aa4aa29deb0f73bce0490f17ff Author: David King Date: Fri Jan 15 23:43:16 2016 +0000 Use the GFile edit name in the file area entry Avoid the situation that, when the encoding conversion fails, an explanatory string is added to the filename for display by using the edit name in the GtkEntry where the user can enter a new filename. M src/file_area.c commit 2b3adb11b8ab8028b000851f8d8c9b741c6c6b4a Author: David King Date: Fri Jan 15 22:29:02 2016 +0000 Solve a FIXME when changing file extension case As the source strings are is ASCII, use g_ascii_strdown() and g_ascii_strup() rather than the UTF-8 equivalents. M src/file.c commit 9a2c766e9c27467c8a2607635674fee021ca9db1 Author: David King Date: Fri Jan 15 20:26:00 2016 +0000 Remove unused Windows backslash removal function As GFile does trivial canonicalization of paths, such as removing a trailing slash, there is no reason to handle a path from a GFile specially under Windows. M src/browser.c M src/win32/win32dep.c M src/win32/win32dep.h commit 2609e840ffe09291d158c0425c07d103dfbfcf56 Author: David King Date: Thu Dec 31 22:10:55 2015 +0000 Use GFile for current browser path M src/application_window.c M src/application_window.h M src/browser.c M src/browser.h M src/load_files_dialog.c M src/playlist_dialog.c commit 8ea193faa73d4edbc6915e1c342f1d04be2ea314 Author: David King Date: Thu Dec 31 19:35:45 2015 +0000 Use GFile in et_browser_select_dir() M src/application.c M src/application_window.c M src/application_window.h M src/browser.c M src/browser.h commit f0019adf81e120f6b8d8d85902e9ecb8215b8c56 Author: David King Date: Thu Dec 31 09:47:33 2015 +0000 Use the GFile parse name in the browser entry This should make it easier for users to enter and modify paths which are not in UTF-8 encoding. M src/browser.c commit 92118a38e385e4f3192de804c926b629d7a31fe1 Author: David King Date: Fri Jan 1 10:13:34 2016 +0000 Simplify et_browser_show_rename_directory_dialog() Use g_filename_display_basename() to simplify the logic to extract the basename and convert to UTF-8 for display. M src/browser.c commit 7454529fa6b346237552d93d443e4821bc505b5a Author: David King Date: Thu Jan 14 18:27:02 2016 +0000 Use et_str_empty() in another place M src/application_window.c commit 87dbe2d2210059d3fc7643cd614c90de752001fd Author: David King Date: Thu Jan 14 18:07:57 2016 +0000 Remove old EASYTAGLANG handling A separate environment variable for setting the locale of EasyTAG on Windows has not been used for some time. M src/application.c commit d52f1b41b5cfb3c884c18b5b4afb57cbd0880ae3 Author: David King Date: Thu Jan 14 16:55:36 2016 +0000 Refactor Try_To_Validate_Utf8_String() Avoid leaking a GError if encoding conversion fails. M src/charset.c commit 345f9d93d7ff33f6750ba2f2a0d7e688f96b96fb Author: David King Date: Thu Jan 14 16:13:09 2016 +0000 Remove a redundant comparison M src/charset.c commit b22f0a517dcb5b2a6b19c86ad3dc946a617cbf3c Author: David King Date: Tue Jan 12 23:08:39 2016 +0000 Refactor get_encoding_from_locale() Use g_get_locale_variants() when looking up the non-Unicode character encoding for a locale, to ensure that variants are checked (such as when checking "en_GB", so that "en" is checked). Additionally, treat "utf8" as synonymous with "UTF-8" as per locale(7). As a fallback, return UTF-8. M src/charset.c commit b23a3bb3fcb612b86c1c40372db6bc9125037a01 Author: David King Date: Tue Jan 12 17:34:44 2016 +0000 Refactor filename_from_display() Validate that the supplied string is UTF-8 with g_return_val_if_fail(). Use g_filename_from_utf8() before attempting any other conversions. Avoid leaking a GError if there are conversion failures. Use g_get_filename_charsets() to query the filename encoding. M src/charset.c commit 75cc59afd0b934271ab5a93329dfe433153bf47b Author: David King Date: Thu Dec 31 17:37:31 2015 +0000 Use et_str_empty() in et_browser_select_dir() M src/browser.c commit 0a1898a445be88842a834b19ee8a458d6a1fb704 Author: David King Date: Sat Jan 10 00:27:46 2015 +0000 Avoid using internal filename_to_display() Use the GLib functions for converting filenames from the GLib file encoding to UTF-8 for display. Avoid trying to guess the encoding, and only pay attention to the G_FILENAME_ENCODING environment variable as an override. M src/application.c M src/browser.c M src/charset.c M src/charset.h M src/easytag.c M src/file_list.c M src/file_name.c M src/load_files_dialog.c M src/playlist_dialog.c M src/scan_dialog.c M src/tags/id3_tag.c M src/tags/ogg_tag.c M src/win32/win32dep.c M src/win32/win32dep.h commit 84bb35464dec34870e38d1f7f08ca8d0282340b7 Author: David King Date: Fri Jan 8 08:49:43 2016 +0000 Use full path when converting name for display Previously, the full path of a directory was converted to UTF-8 for display in the UI. Commit 9d23932754a9b82db0b1be3ac02df04717e99a6c changed the behaviour to use the display name from GFileInfo, which only contains the basename of the file and not the complete path. Use the full path, and convert it for display using g_filename_display_name(). M src/easytag.c commit 567cc99b03d8e35945a6bd851e05dc2c3eaed3a1 Author: David King Date: Fri Jan 8 08:12:04 2016 +0000 Use g_file_enumerator_get_child() in expand_cb() M src/browser.c commit 9d23932754a9b82db0b1be3ac02df04717e99a6c Author: David King Date: Thu Jan 7 22:08:59 2016 +0000 Use display name when reading directory When formatting an error message for display in the UI, use the display name of the file. M src/easytag.c commit bc9f1cde9cb01040db73d1749b44ed8b010c89ab Author: David King Date: Thu Jan 7 21:33:45 2016 +0000 Use g_file_enumerator_get_child() Resolve a TODO in read_directory_recursively(). M src/easytag.c commit 5b4f7f58c2cf4932d67f787c8c26f328494dbb89 Author: Marcus Gisslén Date: Wed Jan 6 01:49:55 2016 +0100 Add Swedish help translation M help/Makefile.am A help/sv/sv.po commit 4aecce9397f6ca42cef7974163110e319c163e37 Author: Daniel Mustieles Date: Thu Jan 7 23:07:38 2016 +0100 Updated Spanish translation M po/es.po commit a21d043d7d63bf773be4bf6420d6f321f293c681 Author: David King Date: Thu Jan 7 17:09:26 2016 +0000 Use GLib POSIX wrapper functions consistently As EasyTAG only handles filenames being in the GLib filename encoding, be careful to use functions which accept that encoding. M src/browser.c M src/cddb_dialog.c M src/file.c M src/file_list.c M src/tags/ape_tag.c M src/tags/libapetag/apetaglib.c M src/tags/libapetag/apetaglib.h commit 595d8554ffeae1e2e65827dfb72506d7af56fc2b Author: David King Date: Thu Jan 7 16:39:53 2016 +0000 Remove some unneeded Windows compat code M src/win32/win32dep.c M src/win32/win32dep.h commit fc09649854a3b4c759770e56100189d1c0b10f3a Author: David King Date: Thu Jan 7 08:58:04 2016 +0000 Depend on at least libnautilus-extension 3.0 Ensure that the Nautilus dependency is on a version that requires GTK+ 3.0 or above for gdk_display_get_app_launch_context(). M configure.ac commit 8afecf0a6573b6db93d91fd4e87e996301c4d495 Author: David King Date: Tue Jan 5 16:02:40 2016 +0000 Replace filename characters after substitutions Ensure that scanner options do not override whether illegal characters should be replaced in filenames, by doing the replacement after the substitutions. This has the effect that if underscores are to be replaced by spaces, and the filename has a trailing underscore, the end result will be a filename with an underscore. https://bugzilla.gnome.org/show_bug.cgi?id=760155 M src/scan_dialog.c commit b3504c69bb11cfd800993a443d0c1be1124c2966 Author: David King Date: Tue Jan 5 16:00:29 2016 +0000 Replace illegal characters at end of filename On FAT filesystems, filenames should avoid ending with ' ' or '.': https://msdn.microsoft.com/en-us/library/windows/desktop/aa365247%28v=vs.85%29.aspx#naming_conventions Handle this in et_filename_prepare(), when the option to replace illegal characters in filenames is enabled, and add new test cases. https://bugzilla.gnome.org/show_bug.cgi?id=760155 M src/misc.c M tests/test-misc.c commit 3749d91f306adb9d73bbce39ce6bf621025f7441 Author: Josef Andersson Date: Sun Jan 3 16:09:50 2016 +0000 Updated Swedish translation M po/sv.po commit 8f1620b5d192f177ea206b085d336cc3f2eda624 Author: David King Date: Fri Jan 1 11:03:47 2016 +0000 Fix memory leak in open directory with dialog Use g_object_set_data_full() to free the current directory path when destroying the dialog. M src/browser.c commit c177c1da3f04e8891bd95edba6f275ee8e585572 Author: David King Date: Fri Jan 1 10:56:54 2016 +0000 Simplify rename directory dialog destruction Use g_object_set_data_full() to automatically free the parent and current directory paths when the dialog is destroyed. M src/browser.c commit 8e343337a81227314760370c4fbcd48a0da42d67 Author: David King Date: Wed Dec 30 20:44:02 2015 +0000 Remove last remnants of GTK+ usage from tag code Rather than opening a GTK+ dialog from the ID3 writing code when detecting a buggy implementation, simply return a new ET_ID3_ERROR_BUGGY_ID3LIB error. Handle the error and show the dialog in the UI code. M src/easytag.c M src/tags/id3_tag.c M src/tags/id3_tag.h commit d3d41072a3ff3802341d96145e5ea87e1508005a Author: David King Date: Thu Dec 31 00:04:42 2015 +0000 Resolve a FIXME when saving config files Convert the list store file path encoding for display using g_filename_display_name(). M src/setting.c commit df18c025151951cc2ec386855ddda9c8fffd1520 Author: David King Date: Wed Dec 30 17:29:17 2015 +0000 Ensure ID3v2.4 tag fields use the correct encoding Fix the check for whether Unicode should be used when writing ID3v2.4 tag fields. https://bugzilla.gnome.org/show_bug.cgi?id=758090 M src/tags/id3v24_tag.c commit acc554b2825abd84554b9f3a18edfb0887686d5c Author: Мирослав Николић Date: Tue Dec 29 09:29:34 2015 +0100 Updated Serbian translation M po/sr.po M po/sr@latin.po commit a74f0d280ed522e69ba91c0126a41466db266b61 Author: Jordi Mas Date: Sat Dec 5 23:02:11 2015 +0100 Update Catalan translation M po/ca.po commit c91fecb5d09f68864522fde00f18c7aed845ea8f Author: Marcus Gisslén Date: Wed Dec 2 14:06:54 2015 +0000 Updated Swedish translation M po/sv.po commit bbf918f8427950734d0101ef2744fff57eaa4b7b Author: Dennis Björklund Date: Sun Nov 29 18:30:29 2015 +0000 Fix selection of CDDB fields to fill https://bugzilla.gnome.org/show_bug.cgi?id=754901 M src/cddb_dialog.c M src/scan_dialog.c M src/setting.c commit 9adaa19236a14206c05c24b957c765833a79d834 Author: David King Date: Fri Nov 13 19:00:28 2015 +0000 Synchronize ETFileList pointer Ensure that sorting ETCore->ETFileDisplayedList, and possibly changing the head pointer, results in the ETCore->ETFileList pointer being updated to the head of the list. https://bugzilla.gnome.org/show_bug.cgi?id=755069 M src/file_list.c commit f18a548b5ae0f705a82db1b4da690fb6566191ba Author: David King Date: Fri Nov 13 18:59:35 2015 +0000 Simplify invariant checks with et_str_empty() M src/file_list.c commit 89f11ef54025dbe83a8bfedf760dc47850ec3653 Author: David King Date: Fri Nov 13 18:58:21 2015 +0000 Simplify ET_Displayed_File_List_By_Etfile() Use g_list_find() rather than a custom list search implementation. M src/file_list.c commit 367e0b25f79a2e4cd8fa1a592f7093c13c6b748a Author: David King Date: Thu Nov 5 08:51:24 2015 +0000 Handle FLAC files with an invalid sample rate Avoid dividing by zero when encountering FLAC files with a (invalid, according to the FLAC specification) sample rate of zero. https://bugzilla.gnome.org/show_bug.cgi?id=757547 M src/tags/flac_header.c commit 52a31751c5b05606a9701ecf9dbcd039fb474ef4 Author: Seong-ho Cho Date: Thu Nov 5 00:39:15 2015 +0000 Updated Korean translation M po/ko.po commit a51e87c194da60aab1827ff1fe3aa5558c901347 Author: Marek Černocký Date: Mon Oct 12 00:06:28 2015 +0200 Updated Czech translation M help/cs/cs.po commit 32f3bdeb01b1a0f5a9ce724c83a21afbcc62e659 Author: Anders Jonsson Date: Mon Oct 5 22:33:58 2015 +0200 Fix verb form in help file M help/C/tag-capitalization.page commit b2cb380bca6d4ee17faa4aed075df32a8d3faf74 Author: Daniel Mustieles Date: Mon Oct 5 14:48:38 2015 +0000 Updated Spanish translation M po/es.po commit 75798b76b0bbc6992485f762cbdc31969957c243 Author: David King Date: Wed Sep 9 19:52:01 2015 +0100 Add additional autoconf-archive bootstrap macros A m4/ax_append_link_flags.m4 A m4/ax_check_link_flag.m4 commit 7c440592e4ff95f3c8cec438019d270ca784b3d8 Author: James Cowgill Date: Tue Sep 8 17:49:13 2015 +0100 Fix crash when writing playlists The error was caused by reading the 'rename-convert-spaces' setting with g_settings_get_flags() instead of g_settings_get_enum(). https://bugzilla.gnome.org/show_bug.cgi?id=754742 M src/playlist_dialog.c commit de19a1705a03753eb130ad9e9336e5ad5b42dc9b Author: Kjartan Maraas Date: Mon Sep 7 22:24:48 2015 +0200 Updated Norwegian bokmål translation from Åka Sikrom. M po/nb.po commit a31b38c1c0fa9603ecf67b47ea622c59cf9eb2f5 Author: James Cowgill Date: Mon Sep 7 15:43:11 2015 +0100 Add missing case when calling opus_tags_parse() The case for a "successful" return value was missing so saving an opus file was always causing easytag to abort at the assertion in the default case block. https://bugzilla.gnome.org/show_bug.cgi?id=754685 M src/tags/vcedit.c commit 84069f14c8c2006555e397ae5acdc7fc40917f7b Author: David King Date: Mon Sep 7 10:19:13 2015 +0100 Fix a linking error on Mac OS X Update autoconf-archive M4 macros (especially AX_COMPILER_FLAGS_LDFLAGS) to ensure that linker flags are checked with the linker, not the compiler. https://bugzilla.gnome.org/show_bug.cgi?id=750981 M m4/ax_compiler_flags.m4 M m4/ax_compiler_flags_cflags.m4 M m4/ax_compiler_flags_cxxflags.m4 M m4/ax_compiler_flags_gir.m4 M m4/ax_compiler_flags_ldflags.m4 commit c46c1312329dacf53544c82280898de36a2551ed Author: Piotr Drąg Date: Wed Sep 2 21:34:45 2015 +0200 Updated Polish translation M po/pl.po