commit 5f1d509ea8e964df5ea439f855892b4530566fce Author: Guillaume Desmottes Date: Mon Nov 30 16:17:30 2009 +0000 prepare 2.29.3 release NEWS | 44 ++++++++++++++++++++++++++++++++++++++++++++ configure.ac | 2 +- 2 files changed, 45 insertions(+), 1 deletions(-) commit c2fc41220152f8907f8511fb59d1c8153ddad5d6 Author: Matej Urbančič Date: Mon Nov 30 17:16:45 2009 +0100 Updated Slovenian translation po/sl.po | 436 +++++++++++++++++++++++++++++++++++++++++--------------------- 1 files changed, 290 insertions(+), 146 deletions(-) commit 6e1756e9eafd1fb88c0e09fbb80a31185c6c13ff Author: Guillaume Desmottes Date: Mon Nov 30 16:03:58 2009 +0000 debug-window: don't disconnect the new debug msg signal once the proxy has been invalidated According to tp_proxy_signal_connection_disconnect's documentation it's not safe to disconnect a signal after its proxy has been invalidated (#603384). src/empathy-debug-window.c | 23 ++++++++++++++++++++++- 1 files changed, 22 insertions(+), 1 deletions(-) commit 740a34efd932ad1bf6d5cd1d4580fd3b6af0eacc Merge: 8d21537 9ec54fd Author: Guillaume Desmottes Date: Mon Nov 30 15:08:24 2009 +0000 Merge commit 'shaunm/dndfiles2' commit 8d21537a22e1e4a1e6224d5e70190e0be2ef9a40 Author: Guillaume Desmottes Date: Mon Nov 30 14:11:47 2009 +0000 contact_manager_status_changed_cb: ignore disconnected account There is no point to start tracking an account which is about to be removed. Furthemore, this avoid to re-add previoulsy invalidated connections (#603361). libempathy/empathy-contact-manager.c | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-) commit 75bbe2b4d9e2dfbc0706fcad8bc77cae2579dfa0 Author: Guillaume Desmottes Date: Mon Nov 30 11:33:45 2009 +0000 add tooltips on the camera buttons src/empathy-call-window.ui | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) commit 3d8a5d2b45d490142b021b43fb4ef1b232ed7910 Author: Brian Pepple Date: Fri Nov 27 16:56:22 2009 -0500 Add check for new NetworkManager-glib pkgconfig file. Fixes bug #599315. configure.ac | 10 ++++++++++ 1 files changed, 10 insertions(+), 0 deletions(-) commit ad74851368bf2a5b355696f4ad8f55f184070179 Author: Felix Kaser Date: Sat Nov 28 20:16:45 2009 +0100 use conn-status-reason instead of conn-status a hardcoded callback call used TP_CONNECTION_STATUS_DISCONNECTED where a TP_CONNECTION_STATUS_REASON should have been, changed to TP_CONNECTION_STATUS_REASON_NONE_SPECIFIED. src/empathy-accounts-dialog.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) commit 297ebd5f9415f444b2bc6db3e30a1ab8c2654a22 Author: Gabor Kelemen Date: Sat Nov 28 12:08:59 2009 +0100 Updated Hungarian translation po/hu.po | 826 ++++++++++++++++++++++++++++++++++++++------------------------ 1 files changed, 506 insertions(+), 320 deletions(-) commit 476130b2add6244a24be51ce32393a095df4a4ef Author: Jorge González Date: Sat Nov 28 10:54:10 2009 +0100 Updated Spanish translation po/es.po | 287 ++++++++++++++++++++++++++++++++++++-------------------------- 1 files changed, 166 insertions(+), 121 deletions(-) commit a59cf9be7760bdbcadbdca2922c777878b9d960a Author: Guillaume Desmottes Date: Fri Nov 27 17:11:50 2009 +0000 Set the stock-person icon for contact online/offline notification This one makes more sense than the info icon as notifications are obviously an information (#590700). src/empathy-event-manager.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) commit 865a820252f569238f53a5a401836a1925acd2f9 Author: Guillaume Desmottes Date: Fri Nov 27 16:27:50 2009 +0000 Capitalize first letter of debug msg src/empathy-call-window.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) commit 68cdcde0b0a029379d3a0b9e0e62bfda7e0bcf7f Author: Guillaume Desmottes Date: Wed Nov 25 13:45:45 2009 +0000 Disable video preview when there is no call This is a workaround until bug 602937 is fixed. src/empathy-call-window.c | 14 ++++++++++++++ 1 files changed, 14 insertions(+), 0 deletions(-) commit 9e048d003178ce72ca6599cb8d847dd64427a2da Author: Guillaume Desmottes Date: Wed Nov 25 13:08:09 2009 +0000 enable the camera-off button if call doens't have initial video src/empathy-call-window.c | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-) commit d7fa9cd2d46574d739d0ad78f7accf7410481ec6 Author: Guillaume Desmottes Date: Wed Nov 25 12:56:32 2009 +0000 enable the camera-off button when call is disconnected Disabling the camera on button doesn't make sense any more. src/empathy-call-window.c | 4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) commit e0a94c57e1266deadd58f158989980c91d7ab4ee Author: Guillaume Desmottes Date: Wed Nov 25 11:44:17 2009 +0000 empathy_call_window_set_send_video: don't request video stream if the call is not connected yet src/empathy-call-window.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) commit 76a7dfdf4fcd250f7787c166da87e1bfa6b70761 Author: Guillaume Desmottes Date: Wed Nov 25 11:32:30 2009 +0000 disable_camera: disable send video only if we were sending it src/empathy-call-window.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) commit 015746e131559133730f2112777d26c581c6ac50 Author: Guillaume Desmottes Date: Wed Nov 25 11:26:29 2009 +0000 update toggle buttons when the camera state is changed because of radio buttons src/empathy-call-window.c | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-) commit 8d1e30bfa8cacadaf2411c03396bd01ad41332c3 Author: Guillaume Desmottes Date: Wed Nov 25 11:22:46 2009 +0000 hook the camera radio buttons src/empathy-call-window.c | 35 ++++++++++++++++++++++++++++++++++- 1 files changed, 34 insertions(+), 1 deletions(-) commit 0961715329c70614a83e874c3c8a5b64cea5691b Author: Guillaume Desmottes Date: Wed Nov 25 11:20:10 2009 +0000 make disable_camera, enable_preview and enable_camera no-op if we are already in the desired state src/empathy-call-window.c | 27 +++++++++++++++------------ 1 files changed, 15 insertions(+), 12 deletions(-) commit 90c8334a4a0c8e84fdd430c44fffb54fa8623b7c Author: Guillaume Desmottes Date: Tue Nov 24 17:51:26 2009 +0000 update radio actions when a button is pressed src/empathy-call-window.c | 11 +++++++++++ 1 files changed, 11 insertions(+), 0 deletions(-) commit 21c54ffdc6d8ff5c47a7a7768aca6bc213075f7f Author: Guillaume Desmottes Date: Tue Nov 24 17:22:55 2009 +0000 add video menu containing radio actions to control video src/empathy-call-window.ui | 41 +++++++++++++++++++++++++++++++++++++++++ 1 files changed, 41 insertions(+), 0 deletions(-) commit 46d8c4965781a2327c6f6206b233f6d72f88b8bb Author: Guillaume Desmottes Date: Tue Nov 24 17:04:49 2009 +0000 remove the "send video" menu item We're going to replace it by radio buttons. src/empathy-call-window.c | 35 ----------------------------------- src/empathy-call-window.ui | 8 -------- 2 files changed, 0 insertions(+), 43 deletions(-) commit 05cfdd280b8a53948d3c2c38c8dc74cfd8672909 Author: Guillaume Desmottes Date: Tue Nov 24 16:58:50 2009 +0000 empathy_call_window_set_send_video: add a debug msg src/empathy-call-window.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) commit 76a44dbf5a997548cc5e2377041d5081369a4c8a Author: Guillaume Desmottes Date: Tue Nov 24 16:58:43 2009 +0000 stop sending video when 'camera off' or 'preview' is enabled src/empathy-call-window.c | 14 +++++++++++--- 1 files changed, 11 insertions(+), 3 deletions(-) commit fe97bdb9c202f40f57b1438df9d0045fad8f40c8 Author: Guillaume Desmottes Date: Tue Nov 24 16:28:49 2009 +0000 early return if the camera_state is already the one we want src/empathy-call-window.c | 9 +++++++++ 1 files changed, 9 insertions(+), 0 deletions(-) commit c2b043aa2094b697ce903186ea06038f24e1ef4b Author: Guillaume Desmottes Date: Tue Nov 24 16:26:15 2009 +0000 disable the others button when 'camera on' is enabled src/empathy-call-window.c | 42 +++++++++++++++++++++++++++++++----------- 1 files changed, 31 insertions(+), 11 deletions(-) commit 05d1a875137abbbefdb249aa02de0d582fe9f3e5 Author: Guillaume Desmottes Date: Tue Nov 24 16:01:07 2009 +0000 rename camera to camera_on Also move down tool_button_camera_on_toggled_cb so it doesn't need a prototype. src/empathy-call-window.c | 75 +++++++++++++++++++++----------------------- src/empathy-call-window.ui | 2 +- 2 files changed, 37 insertions(+), 40 deletions(-) commit f20562cc1586506750e33b7751e5c3b494d43399 Author: Guillaume Desmottes Date: Tue Nov 24 15:53:58 2009 +0000 remove the "Always Show Video Preview" menuitem We use buttons for that now. src/empathy-call-window.c | 25 ------------------------- src/empathy-call-window.ui | 8 -------- 2 files changed, 0 insertions(+), 33 deletions(-) commit 5432a3fc4003e8285ef230c707ffdfe70b38be90 Author: Guillaume Desmottes Date: Tue Nov 24 15:51:48 2009 +0000 connect the 'camera off' and 'preview' buttons src/empathy-call-window.c | 121 +++++++++++++++++++++++++++++++++++++++++++++ 1 files changed, 121 insertions(+), 0 deletions(-) commit 3d6c558cf87c2a7144c40edecd8cebbfac9a1596 Author: Guillaume Desmottes Date: Tue Nov 24 14:37:02 2009 +0000 set the icon of the camera_off button src/empathy-call-window.c | 20 ++++++++++++++++++++ 1 files changed, 20 insertions(+), 0 deletions(-) commit 49df4fbadf79b918a67356647e586bf76cd1f0b7 Author: Guillaume Desmottes Date: Tue Nov 24 13:55:18 2009 +0000 add "camera off" and "preview" buttons to the toolbar Also rename "send video" to "camera on" src/empathy-call-window.ui | 31 ++++++++++++++++++++++++++++++- 1 files changed, 30 insertions(+), 1 deletions(-) commit 374054f9c4525fb6da432ab82e89d62d78f0e7a9 Author: Guillaume Desmottes Date: Mon Nov 23 16:43:07 2009 +0100 call-window: check box labels should use sentence capitalization src/empathy-call-window.ui | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) commit 5b1fa500d7047b6759f1c6e2a090c84a1a81c483 Author: Guillaume Desmottes Date: Tue Nov 10 12:02:23 2009 +0000 We should display the avatar/preview when call is disconnected src/empathy-call-window.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) commit 71b1700af75c01dc9ead0621c7b52e460383fcaa Author: Guillaume Desmottes Date: Tue Nov 10 11:34:28 2009 +0000 call-window: add some debug msg src/empathy-call-window.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) commit a8f35052d171a1dff4be5eae80f4532ae735da7b Author: Guillaume Desmottes Date: Tue Nov 10 11:10:09 2009 +0000 disable video preview when we turn off video sending src/empathy-call-window.c | 5 +---- 1 files changed, 1 insertions(+), 4 deletions(-) commit 4db67c186241cca03b2f4002ac592b4d86601eb8 Author: Guillaume Desmottes Date: Mon Nov 9 18:05:28 2009 +0000 Enable 'send video' buttons and display the preview if call has 'initial video' (#601288) src/empathy-call-window.c | 10 ++++++++++ 1 files changed, 10 insertions(+), 0 deletions(-) commit af3cc2af6c30341cc2a12f63b397d733d3de8a6f Author: Guillaume Desmottes Date: Mon Nov 9 17:51:57 2009 +0000 Don't display the video preview when the sink is added We should dislpay it since we started the sending video process so there is no point to enforce it at this stage. src/empathy-call-window.c | 10 ---------- 1 files changed, 0 insertions(+), 10 deletions(-) commit ba1c519dde7bede7ea44d94246b41d909265c04c Author: Guillaume Desmottes Date: Mon Nov 9 17:46:59 2009 +0000 we don't want to hide the self frame anymore src/empathy-call-window.c | 3 --- 1 files changed, 0 insertions(+), 3 deletions(-) commit ee4c91ff7f14c4f1249ee271cd56faae92ce96be Author: Guillaume Desmottes Date: Mon Nov 9 17:42:07 2009 +0000 remove empathy_call_window_update_self_avatar_visibility This function is wrong. We should disable the preview only when we stop sending video. src/empathy-call-window.c | 24 ------------------------ 1 files changed, 0 insertions(+), 24 deletions(-) commit f4b6d60a4b454233cac3fb5b5e1c407e7496baa6 Author: Guillaume Desmottes Date: Mon Nov 9 17:37:24 2009 +0000 call-window: factor out display_video_preview to display/hide the video preview src/empathy-call-window.c | 51 ++++++++++++++++++++++++++++++++------------ 1 files changed, 37 insertions(+), 14 deletions(-) commit cac3a717a5e34df4439ec5a0660d5ffdc76a27c5 Author: Guillaume Desmottes Date: Mon Nov 9 16:35:17 2009 +0000 add 'voip' debug domain libempathy/empathy-debug.c | 1 + libempathy/empathy-debug.h | 1 + 2 files changed, 2 insertions(+), 0 deletions(-) commit 50f433180ff289b9933860527f00800f77096505 Author: Guillaume Desmottes Date: Mon Nov 9 17:23:07 2009 +0000 call-window: change the semantic of the "Video Preview" menu item (#601288) Change it to "Always Show Video preview". We should always display the preview when we are sending video. So by changing the semantic of this menu it won't be possible to disable the preview while we are sending video. This mean that this menu isn't changed automatically anymore when the preview is displayed. src/empathy-call-window.c | 40 +++++++--------------------------------- src/empathy-call-window.ui | 10 +++++----- 2 files changed, 12 insertions(+), 38 deletions(-) commit 09fa4f08f6477da1b4b371d50e9ddaa48b3eafa7 Author: Guillaume Desmottes Date: Fri Nov 27 15:25:54 2009 +0000 change 'unread from everyone' to 'unread from all' src/empathy-chat-window.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) commit c925d2a550ebbe3e90eac80cf3340714c2c9cb4b Author: Guillaume Desmottes Date: Thu Nov 26 10:40:31 2009 +0000 fix typo in comments src/empathy-chat-window.c | 5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) commit 9764ef80a02af7894a38c396d5d57e8b760a8f2a Author: Guillaume Desmottes Date: Wed Nov 25 17:25:24 2009 +0000 update the window title when a new message is received src/empathy-chat-window.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) commit 761a836a296d32c4af5200d8efc80f3fa9cb33e0 Author: Guillaume Desmottes Date: Wed Nov 25 17:25:07 2009 +0000 display the number of unread message in the window title (#548701) src/empathy-chat-window.c | 67 +++++++++++++++++++++++++++++++++++++++++--- 1 files changed, 62 insertions(+), 5 deletions(-) commit 06dc17735c9966d9b2ecab4f0257bfa9c2eb1742 Author: Guillaume Desmottes Date: Wed Nov 25 17:03:52 2009 +0000 call empathy_chat_messages_read when messages have been read in a tab src/empathy-chat-window.c | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-) commit b01de2f8b4e0ba170e1194615290e3d80865083f Author: Guillaume Desmottes Date: Wed Nov 25 17:03:00 2009 +0000 empathy-chat: keep count of the number of unread messages libempathy-gtk/empathy-chat.c | 23 +++++++++++++++++++++++ libempathy-gtk/empathy-chat.h | 3 +++ 2 files changed, 26 insertions(+), 0 deletions(-) commit 8b5eb07207e7aa74a0e9081a73502f71d1be58c1 Author: Guillaume Desmottes Date: Wed Nov 25 16:33:35 2009 +0000 display the number of other tabs src/empathy-chat-window.c | 20 +++++++++++++++++++- 1 files changed, 19 insertions(+), 1 deletions(-) commit c09471eb2c996367eb023f430b4fa3e599c9df09 Author: Guillaume Desmottes Date: Wed Nov 25 16:12:02 2009 +0000 factor out empathy_chat_get_name Dup the string as we are going to use g_strdup_printf src/empathy-chat-window.c | 12 +++++++++--- 1 files changed, 9 insertions(+), 3 deletions(-) commit 02fa89520bb3b2ca00af8307f476973e8cad83c0 Author: Adi Roiban Date: Fri Nov 27 04:54:21 2009 +0200 Update Romanian translations po/ChangeLog | 4 + po/ro.po | 1202 ++++++++++++++++++++++++++++++++++++---------------------- 2 files changed, 759 insertions(+), 447 deletions(-) commit 2473550861afe14de48efe174e44073405a195c4 Author: Guillaume Desmottes Date: Thu Nov 26 11:38:07 2009 +0000 chat-text-view: override GtkTextView copy_clipboard This allow us to hook our copy_clipboard function as so have pretty pasting when copying using the text view context menu (#603031). libempathy-gtk/empathy-chat-text-view.c | 11 +++++++++++ 1 files changed, 11 insertions(+), 0 deletions(-) commit 6b90cf0b018fa420e46ce23f17b2dfca3168b44b Author: Antón Méixome Date: Thu Nov 26 14:41:49 2009 +0100 Updated Galician Translation po/gl.po | 1259 +++++++++++++++++++++++++++++++++++++------------------------- 1 files changed, 745 insertions(+), 514 deletions(-) commit 38fb31535052089c55fc012d3356758363ae7bb3 Author: Guillaume Desmottes Date: Wed Nov 25 17:50:01 2009 +0000 Always display the 'Room' column (#586678) There is no reason to only display it when an account is selected. src/empathy-chatrooms-window.c | 15 --------------- 1 files changed, 0 insertions(+), 15 deletions(-) commit 1e3bb1380521ae6bb0b16ceb98e36834aeba70d8 Author: Xavier Claessens Date: Mon Nov 23 17:14:28 2009 +0100 Remember the geometry of debug window src/empathy-debug-window.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) commit 0ab9a70d10856dd6876b9a4b31bcf7f5f1663495 Author: Sjoerd Simons Date: Thu Nov 26 09:35:42 2009 +0000 gssize isn't an int on various platforms libempathy-gtk/empathy-theme-adium.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) commit 9ff14672ab605f20789a2db6f9f89673cf8f2c4b Merge: 078aa4b 0b86e86 Author: Xavier Claessens Date: Thu Nov 26 10:20:40 2009 +0100 Merge branch 'adium-events' Conflicts: libempathy-gtk/empathy-theme-adium.c commit 078aa4b28cbca7e5a77701fcbcaf0237e6e717ab Author: Xavier Claessens Date: Thu Nov 26 10:18:31 2009 +0100 Clean how we insert smileys in adium themes libempathy-gtk/empathy-theme-adium.c | 18 +++++------------- 1 files changed, 5 insertions(+), 13 deletions(-) commit 02ca446606c2c9f2673188b811891dd107c21e19 Author: Xavier Claessens Date: Thu Nov 26 10:16:39 2009 +0100 Clean how we insert link in adium themes libempathy-gtk/empathy-theme-adium.c | 14 ++++++-------- 1 files changed, 6 insertions(+), 8 deletions(-) commit 12924ec3e9b06460c5ec6ccb5e84a58ab64cd762 Author: Xavier Claessens Date: Wed Nov 25 10:19:55 2009 +0100 Rework the link regex to have "(user@server.com)" case work. libempathy-gtk/empathy-ui-utils.c | 16 +++++++++------- 1 files changed, 9 insertions(+), 7 deletions(-) commit fe57de44b370951c5e0a5de0aa78e0bb0fca9849 Author: Xavier Claessens Date: Wed Nov 25 10:19:21 2009 +0100 Add some more tests, and fail only after all have run, it's easier to debug tests/empathy-parser-test.c | 26 ++++++++++++++++++-------- 1 files changed, 18 insertions(+), 8 deletions(-) commit 2d9bbb26709398a1211312306ce5bee4b639f2a3 Author: Gustavo Noronha Silva Date: Tue Nov 24 15:28:59 2009 -0200 Escape what is put inside tags We should be careful here, and make sure whatever is put enclosed by tags is correctly encoded. What caused bug #597049 is that what was being liked to looked like a tag, so the browser ignored it, but this is potentially a security vulnerability. Bug #597049 libempathy-gtk/empathy-theme-adium.c | 9 ++++++++- 1 files changed, 8 insertions(+), 1 deletions(-) commit 9ec54fdc072173c6676ec2d8ea0b8eabe6936cef Author: Shaun McCance Date: Tue Nov 24 11:26:45 2009 -0600 Some improvements to file drag-and-drop based on comments on #595226 src/empathy-chat-window.c | 28 ++++++++++++++++++---------- 1 files changed, 18 insertions(+), 10 deletions(-) commit 89bc747b15ff519b81b8b153bcf94c8cd19245b1 Author: Shaun McCance Date: Wed Oct 7 10:47:41 2009 -0500 [empathy-contact-list-view] Don't accept file drags to offline/non-FT contacts libempathy-gtk/empathy-contact-list-view.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) commit bcc824a40f40c86e87cfdd84c00652ada111fdaa Author: Shaun McCance Date: Tue Oct 6 17:56:47 2009 -0500 [empathy-chat-window] Cleanup DND, don't accept drags to offline contacts src/empathy-chat-window.c | 82 ++++++++++++++++++++++++++++++++++----------- 1 files changed, 62 insertions(+), 20 deletions(-) commit adade63c475294db24a422c3a0e5f6b3879641b6 Author: Shaun McCance Date: Mon Oct 5 15:09:46 2009 -0500 Move GtkTargetLists into priv so they're no longer static libempathy-gtk/empathy-contact-list-view.c | 16 +++++++++------- src/empathy-chat-window.c | 19 +++++++++++++------ 2 files changed, 22 insertions(+), 13 deletions(-) commit bbe8c4eadaf0aadd45b3f70cb55dfad44bd4ba49 Author: Shaun McCance Date: Mon Oct 5 14:52:46 2009 -0500 [empathy-chat-window] Documented MOVE/COPY selection in drag_motion src/empathy-chat-window.c | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-) commit 43390cb381e1dd4b68771c3c285bc1f5326a5b74 Author: Shaun McCance Date: Mon Oct 5 14:48:24 2009 -0500 Fixed leak in drag motion and added comments for bug #595226 libempathy-gtk/empathy-contact-list-view.c | 16 +++++++++++++++- 1 files changed, 15 insertions(+), 1 deletions(-) commit f167ec2d92a526d19f1faf8320d9ff975ae1e502 Author: Shaun McCance Date: Mon Oct 5 14:22:32 2009 -0500 Utilitiy function to send files from a URI list, for dnd implementations libempathy-gtk/empathy-chat.c | 5 ++++ libempathy-gtk/empathy-contact-list-view.c | 20 +---------------- libempathy-gtk/empathy-ui-utils.c | 30 ++++++++++++++++++++++++++++ libempathy-gtk/empathy-ui-utils.h | 2 + src/empathy-chat-window.c | 27 +----------------------- 5 files changed, 41 insertions(+), 43 deletions(-) commit cfb4283d66005aa2f12b15ce0d5aefde965d815a Author: Shaun McCance Date: Mon Oct 5 13:37:23 2009 -0500 Split contact_list_view_drag_data_received into smaller functions libempathy-gtk/empathy-contact-list-view.c | 259 +++++++++++++++------------- 1 files changed, 141 insertions(+), 118 deletions(-) commit 85e7ae3c96ccc9734f5f09371cd44817ff751ce6 Author: Shaun McCance Date: Fri Sep 18 14:11:44 2009 -0500 Setting reorderable on the contact list view to get row previews as drag icons This is a hack. There's a comment explaining the hack. Read it. libempathy-gtk/empathy-contact-list-view.c | 7 ++++++- 1 files changed, 6 insertions(+), 1 deletions(-) commit 18be92ecfb97887044867643e130ee0ee7c6b3f8 Author: Shaun McCance Date: Thu Sep 17 17:11:11 2009 -0500 Allow contacts to be dragged anywhere in a group, or dragged to the non-group libempathy-gtk/empathy-contact-list-view.c | 25 ++++++++++++++++++++----- 1 files changed, 20 insertions(+), 5 deletions(-) commit 3cbb3a10e138e1f777427311bf33f30cb6d4839e Author: Shaun McCance Date: Thu Sep 17 16:17:49 2009 -0500 Implemented file drags to contact list, along with row highlights libempathy-gtk/empathy-contact-list-view.c | 254 +++++++++++++++++++--------- src/empathy-chat-window.c | 4 +- 2 files changed, 176 insertions(+), 82 deletions(-) commit d068663d7d73c7dc54b560b3ed9846c218dd8f35 Author: Shaun McCance Date: Tue Sep 15 15:57:51 2009 -0500 Handle MOVE and COPY drags better, change contact-id drags to COPY src/empathy-chat-window.c | 10 ++++++---- 1 files changed, 6 insertions(+), 4 deletions(-) commit 42185f1d38082579ca113d612000c670eac76869 Author: Shaun McCance Date: Tue Sep 15 15:10:24 2009 -0500 Always prefer GDK_ACTION_COPY for text/uri-list drags src/empathy-chat-window.c | 39 +++++++++++++++++++++++++++++++-------- 1 files changed, 31 insertions(+), 8 deletions(-) commit 810fc88802d72b880ff9472be7374f72a34df748 Author: Shaun McCance Date: Tue Sep 15 12:47:09 2009 -0500 Don't try to offer file transfers to MUCs src/empathy-chat-window.c | 10 ++++++++-- 1 files changed, 8 insertions(+), 2 deletions(-) commit df2e42c11963a62c729ca592c3fb291a82ccedb9 Author: Shaun McCance Date: Mon Sep 14 21:31:58 2009 -0500 Call gtk_drag_finish when we get a file transfer drag on a chat window src/empathy-chat-window.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) commit 2e2fdd45ae2d7fac58c9cc40b48c84ffc6b3f48e Author: Shaun McCance Date: Mon Sep 14 21:15:06 2009 -0500 Implementing drag and drop file sending on chat windows libempathy-gtk/empathy-chat.c | 1 + libempathy-gtk/empathy-ui-utils.c | 36 +++++++++++++++++++----------- libempathy-gtk/empathy-ui-utils.h | 2 + src/empathy-chat-window.c | 44 +++++++++++++++++++++++++++++++++++++ 4 files changed, 70 insertions(+), 13 deletions(-) commit b253440c84091dd88e619171330e895507abe40d Author: Xavier Claessens Date: Tue Nov 24 18:38:38 2009 +0100 Add test for bug #597049 tests/empathy-parser-test.c | 11 +++++++++-- 1 files changed, 9 insertions(+), 2 deletions(-) commit 0b86e861b20e3c083baa04bb9e0fa2df31df8e8d Author: Xavier Claessens Date: Tue Nov 24 18:25:22 2009 +0100 Do not escape twice /me messages with adium theme. libempathy-gtk/empathy-theme-adium.c | 47 +++++++++++++++++++-------------- 1 files changed, 27 insertions(+), 20 deletions(-) commit 9863c689d9dab2772bb6ffda97d7376702142394 Author: Xavier Claessens Date: Tue Nov 24 16:44:29 2009 +0100 Add more test cases and fix some found issues in link regex. libempathy-gtk/empathy-ui-utils.c | 2 +- tests/empathy-parser-test.c | 72 ++++++++++++++++++++++++++---------- 2 files changed, 53 insertions(+), 21 deletions(-) commit 9c1e21c7ad3ba913ebf144b498aa2de6d22a7797 Author: Xavier Claessens Date: Tue Nov 24 15:54:21 2009 +0100 Replace GString param with a generic gpointer user_data, and port EmpathyChatTextView to new parser API. libempathy-gtk/empathy-chat-text-view.c | 147 ++++++++++++++----------------- libempathy-gtk/empathy-theme-adium.c | 78 ++++++++++------ libempathy-gtk/empathy-ui-utils.c | 63 ++++++------- libempathy-gtk/empathy-ui-utils.h | 39 ++++---- tests/empathy-parser-test.c | 26 +++++- 5 files changed, 184 insertions(+), 169 deletions(-) commit ebaadd93adf03514e9e629b6ae7b065803b046e7 Author: Xavier Claessens Date: Tue Nov 24 14:37:32 2009 +0100 Also parse smileys in tests tests/empathy-parser-test.c | 14 ++++++++++++++ 1 files changed, 14 insertions(+), 0 deletions(-) commit 3ad67fbdadb2b1da16c53a34fb04489a2acf1def Author: Xavier Claessens Date: Tue Nov 24 14:37:21 2009 +0100 Init GTK from test_init() tests/test-helper.c | 6 ++++-- 1 files changed, 4 insertions(+), 2 deletions(-) commit 8ab216aca28acaa857b4b7faa606cd3af26b6cd9 Author: Xavier Claessens Date: Tue Nov 24 14:32:00 2009 +0100 Add parser tests tests/.gitignore | 1 + tests/Makefile.am | 6 +++- tests/empathy-parser-test.c | 66 +++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 72 insertions(+), 1 deletions(-) commit 2fc34dbe48ff603b99b6e56ce4ea94d6a3a8c450 Author: Xavier Claessens Date: Tue Nov 24 14:31:13 2009 +0100 Call empathy_init() from test_init() tests/test-helper.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) commit c4eea520c7ed8adaf378e9424f199aa49efbccc7 Author: Xavier Claessens Date: Tue Nov 24 14:30:50 2009 +0100 Add Test debug domain libempathy/empathy-debug.c | 1 + libempathy/empathy-debug.h | 1 + 2 files changed, 2 insertions(+), 0 deletions(-) commit ce6f2983d99033c0144a622295ae72ec567e2582 Author: Xavier Claessens Date: Tue Nov 24 14:29:45 2009 +0100 Make possible to define different replace function for parsers libempathy-gtk/empathy-theme-adium.c | 96 ++++++++++++++++------------------ libempathy-gtk/empathy-ui-utils.c | 79 ++++++++++++++++++++-------- libempathy-gtk/empathy-ui-utils.h | 46 ++++++++++++---- 3 files changed, 135 insertions(+), 86 deletions(-) commit 7731e5f2031462707a4e774d6ebe38d32641a6e5 Author: Xavier Claessens Date: Tue Nov 24 11:41:05 2009 +0100 Accept any foo:// URL Schemes libempathy-gtk/empathy-ui-utils.c | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-) commit 212ea18a107e8ddfda82b3b754a1df2b7db9735f Author: Xavier Claessens Date: Mon Nov 16 09:27:50 2009 +0100 start and end positions in EmpathySmileyHit struct can't be negative. Change them to guint. libempathy-gtk/empathy-chat-text-view.c | 2 +- libempathy-gtk/empathy-smiley-manager.h | 4 ++-- libempathy-gtk/empathy-theme-adium.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) commit e83c0814113515cdd5a3dc511f7e29cbe51651e8 Author: Xavier Claessens Date: Mon Nov 16 09:23:12 2009 +0100 Add comments to explain empathy_smiley_manager_parse_len(), it is non-trivial function. libempathy-gtk/empathy-smiley-manager.c | 32 ++++++++++++++++++++++++++++++- libempathy-gtk/empathy-smiley-manager.h | 6 ++-- 2 files changed, 34 insertions(+), 4 deletions(-) commit 1af4342a53358f23f71fabd0012a0d868a13c194 Author: Xavier Claessens Date: Sun Nov 1 11:24:35 2009 +0100 Optimisation: Do not fetch use-smiley gconf key for each substring. libempathy-gtk/empathy-theme-adium.c | 13 +++++++------ 1 files changed, 7 insertions(+), 6 deletions(-) commit 1d42b9fde60750fab76d7af606388bc28b1083ad Author: Xavier Claessens Date: Sun Nov 1 11:19:57 2009 +0100 Extract empathy_string_parser_link and empathy_string_parser_escape from empathy-theme-adium.c libempathy-gtk/empathy-theme-adium.c | 66 +-------------------------------- libempathy-gtk/empathy-ui-utils.c | 62 +++++++++++++++++++++++++++++++ libempathy-gtk/empathy-ui-utils.h | 12 ++++++ 3 files changed, 76 insertions(+), 64 deletions(-) commit 6ea436c8b313974d94eb9fe97974edcf4f47e46d Author: Xavier Claessens Date: Sun Nov 1 11:04:00 2009 +0100 Create API for generic string parser libempathy-gtk/empathy-theme-adium.c | 41 +++++++++++++++++++++++---------- libempathy-gtk/empathy-ui-utils.c | 14 +++++++++++ libempathy-gtk/empathy-ui-utils.h | 12 ++++++++++ 3 files changed, 54 insertions(+), 13 deletions(-) commit b15f926089b6b718004467c8bb2ddf6f6cd3a9ac Author: Xavier Claessens Date: Mon Oct 26 13:09:38 2009 +0100 Remove dead code from EmpathySmileyManager libempathy-gtk/empathy-smiley-manager.c | 101 +++---------------------------- libempathy-gtk/empathy-smiley-manager.h | 4 - 2 files changed, 10 insertions(+), 95 deletions(-) commit 591c58b68cb39c62d22d76f394c30481b0821018 Author: Xavier Claessens Date: Mon Oct 26 12:59:09 2009 +0100 Use new smiley parser in EmpathyChatTextView. libempathy-gtk/empathy-chat-text-view.c | 29 ++++++++++++++++++----------- libempathy-gtk/empathy-smiley-manager.h | 4 ++-- 2 files changed, 20 insertions(+), 13 deletions(-) commit 954545eee55262449162dd8d0aa10ce6f9c8d036 Author: Xavier Claessens Date: Mon Oct 26 11:53:28 2009 +0100 exclude " and ' from links. libempathy-gtk/empathy-ui-utils.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) commit e4b5562ff59eeab1c5b8d72d72cb5d935cd7d765 Author: Xavier Claessens Date: Mon Oct 26 11:53:06 2009 +0100 Rework the way message parsing and escaping is done. libempathy-gtk/empathy-theme-adium.c | 216 ++++++++++++++++++++-------------- 1 files changed, 126 insertions(+), 90 deletions(-) commit c2a7ae14574cd90f98f97cf84966152ab6023ace Author: Xavier Claessens Date: Mon Oct 26 11:52:27 2009 +0100 Introduce a new smiley parser that can parse only a part of a string. libempathy-gtk/empathy-smiley-manager.c | 83 +++++++++++++++++++++++++++++++ libempathy-gtk/empathy-smiley-manager.h | 11 ++++ 2 files changed, 94 insertions(+), 0 deletions(-) commit 783fe36cb4d096a9ed17078e8ddc36b3542b638b Author: Jorge González Date: Tue Nov 24 17:57:30 2009 +0100 Updated Spanish translation po/es.po | 177 +++++++++++++++++++++++++++++++++++++++++++++++-------------- 1 files changed, 136 insertions(+), 41 deletions(-) commit d6c023acb730fd74dab269fd3f5883b0e655de5f Author: Gustavo Noronha Silva Date: Tue Nov 24 14:27:58 2009 -0200 Make sure double quotes are not considered part of URIs The fact that the URI regex we use to detect URIs in chat conversations does not exclude double quotes causes it to pick up more of the text than it should, in some cases. Bug #598381 libempathy-gtk/empathy-ui-utils.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) commit d7737fbc077b6e1a5af4446cbda759cad0e22e95 Author: Guillaume Desmottes Date: Tue Nov 24 10:59:02 2009 +0000 add empathy-account-widget-sip.c to POTFILES.in po/POTFILES.in | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) commit a5881d0c3bce92cee5fa0f81d6c0313db5537747 Author: Xavier Claessens Date: Mon Nov 23 16:58:27 2009 +0100 Clarify macro names libempathy-gtk/empathy-geometry.c | 36 +++++++++++++++++++++--------------- 1 files changed, 21 insertions(+), 15 deletions(-) commit 496598a1d17599b809d981c5c3016f90eec15376 Author: Xavier Claessens Date: Mon Nov 23 16:30:26 2009 +0100 Create EMPATHY_RECT_IS_ON_SCREEN macro instead of duplicating its code. libempathy-gtk/empathy-geometry.c | 5 ++--- libempathy-gtk/empathy-ui-utils.c | 4 +--- libempathy-gtk/empathy-ui-utils.h | 5 +++++ 3 files changed, 8 insertions(+), 6 deletions(-) commit 5a09311ed6bc01870413327addfd0337d7296a7e Author: Xavier Claessens Date: Mon Nov 23 14:35:19 2009 +0100 Drop workaround that restore window position when it gets deiconified It breaks with metacity because windows are all iconified/deiconified when switching workspace, and it seems reposition on map is enough. src/empathy-main-window.c | 16 ---------------- 1 files changed, 0 insertions(+), 16 deletions(-) commit 2035a59cc1d1a7b28d3fd583f49ca74c9b3db503 Author: Xavier Claessens Date: Mon Nov 23 14:34:35 2009 +0100 Restore position of window if it gets remapped. libempathy-gtk/empathy-geometry.c | 65 +++++++++++++++++++++++++++++-------- 1 files changed, 51 insertions(+), 14 deletions(-) commit 18f7718773d305ea2c83918c82ea938e2ff55ef3 Author: Xavier Claessens Date: Mon Nov 23 14:31:30 2009 +0100 Make empathy_present_window() also move to current desktop with compiz. Fixes bug #602649 libempathy-gtk/empathy-ui-utils.c | 18 +++++++++++++++--- 1 files changed, 15 insertions(+), 3 deletions(-) commit 05ecb3d3c81446517a71eaa884076efb9d3ae35a Author: Xavier Claessens Date: Mon Nov 23 08:50:12 2009 +0100 Make sure to not save offscreen positioning. It happens with compiz. libempathy-gtk/empathy-geometry.c | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-) commit cca12d5ca2612c344dd395da63a63c5a8c0a7969 Author: Guillaume Desmottes Date: Mon Nov 23 16:36:05 2009 +0100 Don't set the accounts dialog transient when running empathy -a This will avoid to display the contact list if it has been hidden (#581626). src/empathy.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) commit a0dc8b43d0776ae123cd7d6dfaeef7b4bd1672a6 Author: Guillaume Desmottes Date: Mon Nov 23 16:09:54 2009 +0100 account-widget-sip: translate all the labels in combo box libempathy-gtk/empathy-account-widget-sip.c | 14 +++++++++----- 1 files changed, 9 insertions(+), 5 deletions(-) commit e400d3cf3fee67202427344a74d51f92300c08cb Author: Guillaume Desmottes Date: Wed Nov 18 17:49:55 2009 +0000 empathy-account-widget-private: fix coding style libempathy-gtk/empathy-account-widget-private.h | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) commit 0aee963e52e7432567e664a385f4b0658fe8993c Author: Guillaume Desmottes Date: Wed Nov 18 17:48:26 2009 +0000 rename account_widget_setup_widget empathy_account_widget_setup_widget This function is exported now. libempathy-gtk/empathy-account-widget-private.h | 2 +- libempathy-gtk/empathy-account-widget-sip.c | 4 ++-- libempathy-gtk/empathy-account-widget.c | 7 ++++--- 3 files changed, 7 insertions(+), 6 deletions(-) commit adf5302cd8c725cd3d6c5948481839da6b911d45 Author: Guillaume Desmottes Date: Wed Nov 18 15:10:13 2009 +0000 fix position of the 2 combo boxes libempathy-gtk/empathy-account-widget-sip.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) commit cf5c186c7350a1fe174d202e72833352e4385903 Author: Guillaume Desmottes Date: Wed Nov 18 14:58:41 2009 +0000 move port settings to the same line as the host libempathy-gtk/empathy-account-widget-sip.ui | 211 +++++++++++++------------- 1 files changed, 106 insertions(+), 105 deletions(-) commit 4a2c2ba5f988b0f716f85cfcde22f67663b4984a Author: Guillaume Desmottes Date: Wed Nov 18 14:48:13 2009 +0000 indent the STUN Server/Port label under the checkbox libempathy-gtk/empathy-account-widget-sip.ui | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) commit 02f43d5ef0ed93d0699b3093e13c46bb129256ef Author: Guillaume Desmottes Date: Wed Nov 18 14:44:01 2009 +0000 rephrase subsection titles and their labels libempathy-gtk/empathy-account-widget-sip.ui | 16 ++++++++-------- 1 files changed, 8 insertions(+), 8 deletions(-) commit eed9993f70997795d52828ebe56e5831c9566206 Author: Guillaume Desmottes Date: Wed Nov 18 14:40:37 2009 +0000 add indentation so subsections are clearer libempathy-gtk/empathy-account-widget-sip.ui | 324 +++++++++++++++---------- 1 files changed, 194 insertions(+), 130 deletions(-) commit 7cf2b5ad033f1929e2e0697d72e22cb9d4a8442d Author: Guillaume Desmottes Date: Wed Nov 18 14:19:25 2009 +0000 rephrase the discover-stun checkbox label libempathy-gtk/empathy-account-widget-sip.ui | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) commit d37455f3e8525d70ec792a78319be8b398b38641 Author: Guillaume Desmottes Date: Wed Nov 18 14:18:30 2009 +0000 rename Misc section to Miscellaneous libempathy-gtk/empathy-account-widget-sip.ui | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) commit 6df549df80d1a2cede9a09d0523a09c892900640 Author: Guillaume Desmottes Date: Tue Nov 17 15:45:07 2009 +0000 account-widget-sip: add subsections in the advanced section libempathy-gtk/empathy-account-widget-sip.c | 2 +- libempathy-gtk/empathy-account-widget-sip.ui | 125 ++++++++++++++++++-------- 2 files changed, 90 insertions(+), 37 deletions(-) commit acd34840d001a4bba556886d4675832f9c4c29a0 Author: Guillaume Desmottes Date: Tue Nov 17 11:27:13 2009 +0000 account-widget-sip: fix typo in variable name libempathy-gtk/empathy-account-widget-sip.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) commit 4679f53f051665acb601de4516eb7d7f9e173f44 Author: Guillaume Desmottes Date: Tue Nov 17 11:26:01 2009 +0000 account-widget-sip: unsensitive the STUN labels as well when STUN is disabled libempathy-gtk/empathy-account-widget-sip.c | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-) commit 76ece46082b1a487acca4abea728c296b586824e Author: Guillaume Desmottes Date: Tue Nov 17 11:09:28 2009 +0000 account_widget_combobox_changed_cb: check that param has a default libempathy-gtk/empathy-account-widget.c | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) commit 6738d193bf3e30d0befaa3e8183cc75ffe607982 Author: Guillaume Desmottes Date: Tue Nov 17 11:05:41 2009 +0000 Set explicitely the model of combo box The value of the param has to be in the first column as a string. This allow us to display translated strings in the combo box. libempathy-gtk/empathy-account-widget-sip.c | 81 +++++++++++++++++++-------- libempathy-gtk/empathy-account-widget.c | 13 ++++- 2 files changed, 69 insertions(+), 25 deletions(-) commit db4180342c107e1641ae528739409e4168ba7d91 Author: Guillaume Desmottes Date: Mon Nov 16 18:00:02 2009 +0000 unsensitive the keep-alive spin button if keep-alive is disabled libempathy-gtk/empathy-account-widget-sip.c | 22 ++++++++++++++++++++++ 1 files changed, 22 insertions(+), 0 deletions(-) commit 8c92880ac4be339e9047cb03f981c7ec5de9cbfb Author: Guillaume Desmottes Date: Mon Nov 16 17:51:42 2009 +0000 account-widget-sip: add UI to configure the keepalive-mechanism and keepalive-interval params libempathy-gtk/empathy-account-widget-sip.c | 22 ++++++++++++ libempathy-gtk/empathy-account-widget-sip.ui | 46 +++++++++++++++++++++++++- 2 files changed, 67 insertions(+), 1 deletions(-) commit aa9f5c39b0600d7cba3d63124d8d7018e63209f1 Author: Guillaume Desmottes Date: Mon Nov 16 17:36:11 2009 +0000 account-widget-sip: add UI to configure the discover-binding param libempathy-gtk/empathy-account-widget-sip.c | 1 + libempathy-gtk/empathy-account-widget-sip.ui | 17 ++++++++++++++++- 2 files changed, 17 insertions(+), 1 deletions(-) commit b212a106ec0395c312ea9e1242d6ed684729ff9f Author: Guillaume Desmottes Date: Mon Nov 16 17:32:08 2009 +0000 account-widget-sip: add UI to configure the loose-routine param libempathy-gtk/empathy-account-widget-sip.c | 1 + libempathy-gtk/empathy-account-widget-sip.ui | 17 ++++++++++++++++- 2 files changed, 17 insertions(+), 1 deletions(-) commit 03b6a5b020c9c2f7cc3a2bf5240368ced685f1bc Author: Guillaume Desmottes Date: Mon Nov 16 16:31:00 2009 +0000 account-widget-sip: add UI to configure the transport param libempathy-gtk/empathy-account-widget-sip.c | 24 ++++++++++++++++++++++++ libempathy-gtk/empathy-account-widget-sip.ui | 16 +++++++++++++++- 2 files changed, 39 insertions(+), 1 deletions(-) commit 5443218a889c1866d8fbe29f5d74e76eb038e37e Author: Guillaume Desmottes Date: Mon Nov 16 16:27:30 2009 +0000 account_widget_setup_widget: add support for GtkComboBox libempathy-gtk/empathy-account-widget.c | 64 +++++++++++++++++++++++++++++++ 1 files changed, 64 insertions(+), 0 deletions(-) commit 03fb46a62ffebee924f1c610bfab31458df920de Author: Guillaume Desmottes Date: Mon Nov 16 15:56:22 2009 +0000 empathy-account-widget: export account_widget_setup_widget This function can be useful if a account widget wants to map a widget not created in the GtkBuilder file. libempathy-gtk/empathy-account-widget-private.h | 4 ++++ libempathy-gtk/empathy-account-widget.c | 2 +- 2 files changed, 5 insertions(+), 1 deletions(-) commit 3528c4dd9364d2b178e49b259affc50022ed9af3 Author: Guillaume Desmottes Date: Mon Nov 16 14:11:26 2009 +0000 account-widget-sip: Add UI to configure auth-user, proxy-host and port params (#601697) libempathy-gtk/empathy-account-widget-sip.c | 3 + libempathy-gtk/empathy-account-widget-sip.ui | 85 +++++++++++++++++++++++++- 2 files changed, 87 insertions(+), 1 deletions(-) commit 14e27827e307997db9ec5ad216900cd5282c2864 Author: Guillaume Desmottes Date: Thu Nov 19 11:46:04 2009 +0000 empathy_tp_contact_factory_get_from_{id,handle} shouldn't pass the ref of the contact to the cb This match the behaviour of empathy_tp_contact_factory_get_from_{ids,handles} and tp_connection_get_contacts_by_handle. libempathy/empathy-tp-contact-factory.c | 7 +++++++ 1 files changed, 7 insertions(+), 0 deletions(-) commit 9da605b25b64e25bc6a1b7651d001ea451fbeac9 Author: Guillaume Desmottes Date: Thu Nov 19 11:10:15 2009 +0000 event-manager: event_manager_ft_got_contact_cb: ref the contact empathy_tp_contact_factory_get_from_handle is not supposed to give a reference to the callback. src/empathy-event-manager.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) commit 250f2c784601f83fb5d0ccdd02d64d607ae0a385 Author: Guillaume Desmottes Date: Thu Nov 19 11:09:29 2009 +0000 ft-handler: contact_factory_contact_cb: ref the contact empathy_tp_contact_factory_get_from_handle is not supposed to give a reference to the callback. libempathy/empathy-ft-handler.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) commit 493d8e1b341aae18d3d94ff9fbe0187cd100a60d Author: Guillaume Desmottes Date: Thu Nov 19 10:53:53 2009 +0000 tp-contact-factory: document that empathy_tp_contact_factory_get_from_{ids,handles} don't give a ref to the cb libempathy/empathy-tp-contact-factory.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) commit 228087733091adf20dcf31c9a4f305aa1152e163 Author: Matej Urbančič Date: Fri Nov 20 14:05:23 2009 +0100 Updated Slovenian translation po/sl.po | 100 +++++++++++++++++++++++++++++-------------------------------- 1 files changed, 48 insertions(+), 52 deletions(-) commit ba7b628e94f952f6e8692e275e1e8098430fadb9 Author: Jorge González Date: Thu Nov 19 20:09:19 2009 +0100 Updated Spanish translation po/es.po | 130 ++++++++++++++++++++++++++++++++----------------------------- 1 files changed, 68 insertions(+), 62 deletions(-) commit eaf0587c3c9d674eca2350dec5a2f5c87705f402 Author: Guillaume Desmottes Date: Wed Nov 18 23:09:53 2009 +0000 notify-manager: unref the account mgr when disposing libempathy-gtk/empathy-notify-manager.c | 15 +++++++++++++++ 1 files changed, 15 insertions(+), 0 deletions(-) commit 0805caad8bb48b83e74648dbb3be85fd2869b541 Author: Guillaume Desmottes Date: Wed Nov 18 12:32:12 2009 +0000 account-widget: use the account-manaer instead of idle Also ensure that the 'apply' button is correctly updated when the status is changed. libempathy-gtk/empathy-account-widget.c | 88 +++++++++++++++++++----------- 1 files changed, 56 insertions(+), 32 deletions(-) commit 5e6b2ce12834a5b9a39ebfda3347377a52d00fac Author: Guillaume Desmottes Date: Wed Nov 18 11:47:13 2009 +0000 idle: make empathy_idle_get_status static It's not used anymore and other components should use the account manager directly. libempathy/empathy-idle.c | 36 ++++++++++++++++++------------------ libempathy/empathy-idle.h | 1 - 2 files changed, 18 insertions(+), 19 deletions(-) commit 6d44631feaef9003a77b9854764549afee839a27 Author: Guillaume Desmottes Date: Tue Nov 17 17:18:15 2009 +0000 empathy.c: use tp_account_manager_get_most_available_presence instead of empathy_idle_get_state src/empathy.c | 6 +++++- 1 files changed, 5 insertions(+), 1 deletions(-) commit 31e4f59e7c16016d0279070a711147fb6b460af1 Author: Guillaume Desmottes Date: Tue Nov 17 17:09:22 2009 +0000 notify-manager: use the account mgr directly instead of empathy_check_available_state libempathy-gtk/empathy-notify-manager.c | 40 ++++++++++++++++++++++++++++++- 1 files changed, 39 insertions(+), 1 deletions(-) commit 0a24fbcba90ec2b36ede035ec6d9a9915a740e1a Author: Guillaume Desmottes Date: Wed Nov 18 11:44:55 2009 +0000 status-icon: use the account-manager directly to get our state and status Also wait that he AM is ready before trying to get the status. Partially fix bug #601235. src/empathy-status-icon.c | 20 ++++++++++---------- 1 files changed, 10 insertions(+), 10 deletions(-) commit aadb68944951a49704d0bf4a018b22041432a25e Author: Guillaume Desmottes Date: Wed Nov 18 11:38:33 2009 +0000 presence-chooser: use the account-manager directly to get our state and status Also wait that the AM is ready before trying to get the status. Partially fix bug #601235. libempathy-gtk/empathy-presence-chooser.c | 65 +++++++++++++++++++++-------- 1 files changed, 48 insertions(+), 17 deletions(-) commit 91f13bff713e208272ad93d36c2faf0737cdd32c Author: Guillaume Desmottes Date: Wed Nov 18 14:06:15 2009 +0000 tp-chat: copy the rename message libempathy/empathy-tp-chat.c | 7 ++++--- 1 files changed, 4 insertions(+), 3 deletions(-) commit 8a149be5cabca92862b84dff0642ee44ea16dfa3 Author: Guillaume Desmottes Date: Wed Nov 18 13:55:42 2009 +0000 coding style fixes libempathy/empathy-tp-chat.c | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-) commit fa08a8879c77e99f706ee805df0e2821f202e9de Author: Guillaume Desmottes Date: Wed Nov 18 13:53:25 2009 +0000 don't mix code and variable declarations libempathy-gtk/empathy-chat.c | 8 ++++---- libempathy/empathy-tp-chat.c | 6 +++--- 2 files changed, 7 insertions(+), 7 deletions(-) commit ea9f4b06393425e7496a3494e084520da3de7618 Author: Jonathon Jongsma Date: Fri Feb 13 11:35:42 2009 -0600 Fixed some of Gillaume's review comments from Bug #571642 The following comments should be fixed in this commit: - tp_group_update_members: add "old" and "new" in comments so we known which contact we are talking about. - Always use TpHandle instead of guint when storing handles in variables. - contact_list_store_member_renamed_cb: would be good to share the common code with contact_list_store_members_changed_cb in a common function One comment about the last one: I split out common code into two new functions: contact_list_store_add_contact_and_connect(), and the matching contact_list_store_remove_contact_and_disconnect(). I wondered whether the signal connection/disconnection should just be added to the _add_contact() and _remove_contact() functions directly, but they do seem to be used in other places without connecting to signals, so i thought it would be safer to simply add some wrapper functions. libempathy-gtk/empathy-contact-list-store.c | 82 ++++++++++++-------------- 1 files changed, 38 insertions(+), 44 deletions(-) commit 500093ef89387aead8be8086e33c05fa250446e9 Author: Jonathon Jongsma Date: Wed Jan 7 15:49:08 2009 -0600 Handle the case where a user's id changes in a chatroom Telepathy-glib has a enum value for the MembersChanged signal to signify that a user's ID has changed. Previously, empathy was simply interpreting this as if a user with the old name had left the chat and a different user with the new name had entered the chat. This change handles this case more gracefully by updating the contact's id (and name) when this change reason is present One thing that does not yet work with this patch is if you are engaged in a private chat with a person and they change their nick in the middle of the chat. Then the EmpathyContact* that you are chatting with is no longer the EmpathyContact* representing the remote user, so messages won't be delivered properly. When we detect that a user has been 'renamed', we probably need to somehow go through all of the private chats with that person and swap out the old (invalid) EmpathyContact* and replace it with the new one so that the chat can continue without interruption. libempathy-gtk/empathy-chat.c | 29 ++++++++ libempathy-gtk/empathy-contact-list-store.c | 56 ++++++++++++++++ libempathy/empathy-contact-list.c | 9 +++ libempathy/empathy-tp-chat.c | 95 +++++++++++++++++++++++++++ 4 files changed, 189 insertions(+), 0 deletions(-) commit 79fcbc9965a60f8099ea355188b954ae2444eddc Author: Guillaume Desmottes Date: Wed Nov 18 18:35:54 2009 +0000 tp-chat: no need to connect twice on the ChatStateChanged signal libempathy/empathy-tp-chat.c | 4 ---- 1 files changed, 0 insertions(+), 4 deletions(-) commit c0619e8382aa29b5cbc872481abd7422ecc9b25b Author: Bastien Nocera Date: Wed Nov 18 17:06:34 2009 +0000 Fix nautilus-sendto plugin's linking No need to link to both libempathy-gtk and libempathy, the former already links to the latter. https://bugzilla.gnome.org/show_bug.cgi?id=602324 nautilus-sendto-plugin/Makefile.am | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) commit db67069547cedf5728d0015b1c207da6bd5445f0 Author: Laurent Bigonville Date: Wed Nov 18 16:57:24 2009 +0100 Move empathy-log to tests/interactive and don't install it anymore src/.gitignore | 1 - src/Makefile.am | 5 +-- src/empathy-logs.c | 60 -------------------------------------- tests/interactive/.gitignore | 1 + tests/interactive/Makefile.am | 2 + tests/interactive/empathy-logs.c | 60 ++++++++++++++++++++++++++++++++++++++ 6 files changed, 64 insertions(+), 65 deletions(-) commit d2da82d9684bd97038c95be1cef8cedf07e6df32 Author: Matej Urbančič Date: Wed Nov 18 07:03:15 2009 +0100 Updated Slovenian translation po/sl.po | 257 ++++++++++++++++++++++++++++++++++---------------------------- 1 files changed, 141 insertions(+), 116 deletions(-) commit b80b6e34115b8f2e483e89fa2dcd89fc7c4dfdcc Author: Guillaume Desmottes Date: Tue Nov 17 17:36:07 2009 +0000 remove empathy_idle_{get,set}_flash_state libempathy/empathy-idle.c | 46 --------------------------------------------- libempathy/empathy-idle.h | 3 -- 2 files changed, 0 insertions(+), 49 deletions(-) commit 526e1430353d4a371d98bdd6a3064499c6a286e4 Author: Guillaume Desmottes Date: Tue Nov 17 17:35:34 2009 +0000 presence-chooser: remove icon blinking support This code is broken and unused since a while. libempathy-gtk/empathy-presence-chooser.c | 92 +--------------------------- 1 files changed, 4 insertions(+), 88 deletions(-) commit 7cd2009c0869188a6968e64fd9b92981181ed129 Author: Guillaume Desmottes Date: Tue Nov 17 11:36:29 2009 +0000 account-widget-jabber: increase spacing in the 'Override Server Settings' section The frame was too close from the other widgets. libempathy-gtk/empathy-account-widget-jabber.ui | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) commit 0e5d455892166362053c3d65549fc181bf664724 Author: Sjoerd Simons Date: Tue Nov 17 11:04:07 2009 +0000 We should ensure, not create muc channels libempathy/empathy-dispatcher.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) commit 8bc927ba13e76d0d3955acb71651449bbab90591 Author: Xavier Claessens Date: Tue Nov 17 11:27:58 2009 +0100 Disable single include configure.ac | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-) commit 6f9fe3b417a3870ce48288f1273843af05d39624 Author: Javier Jardón Date: Fri Nov 13 06:29:35 2009 +0100 Use accessor functions instead direct access. Some functions still remaining because there is not API in GTK+ 2.19.0 yet. http://bugzilla.gnome.org/show_bug.cgi?id=586476 Reviewed-By: Danielle Madeley libempathy-gtk/empathy-avatar-image.c | 6 ++++-- libempathy-gtk/empathy-cell-renderer-expander.c | 4 +++- libempathy-gtk/empathy-chat.c | 10 ++++++---- libempathy-gtk/empathy-contact-dialogs.c | 6 +++--- libempathy-gtk/empathy-contact-menu.c | 2 +- libempathy-gtk/empathy-kludge-label.c | 9 ++++++--- libempathy-gtk/empathy-presence-chooser.c | 6 +++--- libempathy-gtk/empathy-status-preset-dialog.c | 2 +- libempathy-gtk/empathy-ui-utils.c | 4 ++-- libempathy-gtk/empathy-video-widget.c | 6 ++++-- src/empathy-call-window.c | 21 ++++++++++++++------- src/empathy-chat-window.c | 4 ++-- src/empathy-chatrooms-window.c | 2 +- src/empathy-sidebar.c | 12 ++++++++---- src/ephy-spinner.c | 18 ++++++++++-------- 15 files changed, 68 insertions(+), 44 deletions(-) commit e836a987945a601d70082eef2c6f2fd6796c4fd3 Author: Jorge González Date: Mon Nov 16 19:59:19 2009 +0100 Updated Spanish translation po/es.po | 141 +++++++++++++++++++++++++++++++++++++++----------------------- 1 files changed, 89 insertions(+), 52 deletions(-) commit d992856fae759eed04e9ae78e5242259462416f1 Author: Guillaume Desmottes Date: Mon Nov 16 17:19:09 2009 +0000 log_store_empathy_search_hit_new: don't unref accounts tp_account_manager_get_valid_accounts does *not* ref the accounts (#600800). libempathy/empathy-log-store-empathy.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) commit 60a1441ea328c9001ec1433be4d06fb363d34a42 Author: Guillaume Desmottes Date: Mon Nov 16 17:08:14 2009 +0000 start dev of 2.29.3 configure.ac | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)