commit 55adee5c891d1b7c6d2c76f99bb94ed2c5734813
Author: Michael Catanzaro <mcatanzaro@gnome.org>
Date: Mon Nov 21 17:13:27 2016 -0600
Prepare 3.23.2.1
NEWS | 8 ++++++++
configure.ac | 2 +-
2 files changed, 9 insertions(+), 1 deletion(-)
commit 79d52375239b4d8b95890beeeb85c7d7bd6de943
Author: Michael Catanzaro <mcatanzaro@gnome.org>
Date: Mon Nov 21 15:17:21 2016 -0600
bookmarks-manager: simplify finalize
Again, these functions are intended for dispose, where we really
need to
reset the values to NULL, not finalize.
src/bookmarks/ephy-bookmarks-manager.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
commit 4ab313b322cc5bca542dfc6d183438a4557db018
Author: Michael Catanzaro <mcatanzaro@gnome.org>
Date: Mon Nov 21 15:07:43 2016 -0600
bookmark: Fix leaks in ephy_bookmark_new
The property setters will duplicate the strings, they don't claim
ownership
src/bookmarks/ephy-bookmark.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
commit 1b5cf44b73bcfa69feb8652e493f62090d36938f
Author: Michael Catanzaro <mcatanzaro@gnome.org>
Date: Mon Nov 21 15:03:54 2016 -0600
bookmark: Fix leaks in property setters
src/bookmarks/ephy-bookmark.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
commit d6a8d17be8e16ee02ade994fb28859868a9978c1
Author: Michael Catanzaro <mcatanzaro@gnome.org>
Date: Mon Nov 21 15:00:29 2016 -0600
bookmarks-manager: Fix leak of gvdb_filename
src/bookmarks/ephy-bookmarks-manager.c | 2 ++
1 file changed, 2 insertions(+)
commit f4d656a868b391aa383af3526b4a1712c5e58e55
Author: Michael Catanzaro <mcatanzaro@gnome.org>
Date: Mon Nov 21 14:59:46 2016 -0600
bookmark: Simplify finalize function
It's finalize so we don't need to set anything to NULL
src/bookmarks/ephy-bookmark.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
commit 2aa60af0b078af9e2776cbca4812d3345721db05
Author: Michael Catanzaro <mcatanzaro@gnome.org>
Date: Mon Nov 21 14:46:55 2016 -0600
bookmark: Fix leak of id
Direct leak of 891 byte(s) in 27 object(s) allocated from:
#0 0x7f037a037e60 in malloc (/lib64/libasan.so.3+0xc6e60)
#1 0x7f0365b418f6 in g_malloc
/home/mcatanzaro/src/jhbuild/checkout/glib/glib/gmem.c:94
#2 0x7f0365b41bb3 in g_malloc_n
/home/mcatanzaro/src/jhbuild/checkout/glib/glib/gmem.c:331
#3 0x7f0365b5e4d8 in g_strdup
/home/mcatanzaro/src/jhbuild/checkout/glib/glib/gstrfuncs.c:363
#4 0x7f03799e74fc in ephy_bookmark_set_id
/home/mcatanzaro/src/jhbuild/checkout/epiphany/src/bookmarks/ephy-bookmark.c:353
#5 0x7f03799ee6b5 in ephy_bookmarks_manager_load_from_file
/home/mcatanzaro/src/jhbuild/checkout/epiphany/src/bookmarks/ephy-bookmarks-manager.c:620
#6 0x7f03799ed26a in ephy_bookmarks_manager_init
/home/mcatanzaro/src/jhbuild/checkout/epiphany/src/bookmarks/ephy-bookmarks-manager.c:223
#7 0x7f03691b5c55 in g_type_create_instance
/home/mcatanzaro/src/jhbuild/checkout/glib/gobject/gtype.c:1866
#8 0x7f036919c2aa in g_object_new_internal
/home/mcatanzaro/src/jhbuild/checkout/glib/gobject/gobject.c:1783
#9 0x7f036919c7b9 in g_object_newv
/home/mcatanzaro/src/jhbuild/checkout/glib/gobject/gobject.c:1930
#10 0x7f036919be5b in g_object_new
/home/mcatanzaro/src/jhbuild/checkout/glib/gobject/gobject.c:1623
#11 0x7f03799ed2fc in ephy_bookmarks_manager_new
/home/mcatanzaro/src/jhbuild/checkout/epiphany/src/bookmarks/ephy-bookmarks-manager.c:245
#12 0x7f0379a0b45d in ephy_shell_get_bookmarks_manager
/home/mcatanzaro/src/jhbuild/checkout/epiphany/src/ephy-shell.c:774
#13 0x7f03799f0d05 in ephy_bookmarks_popover_init
/home/mcatanzaro/src/jhbuild/checkout/epiphany/src/bookmarks/ephy-bookmarks-popover.c:485
#14 0x7f03691b5c55 in g_type_create_instance
/home/mcatanzaro/src/jhbuild/checkout/glib/gobject/gtype.c:1866
#15 0x7f036919c2aa in g_object_new_internal
/home/mcatanzaro/src/jhbuild/checkout/glib/gobject/gobject.c:1783
#16 0x7f036919cefe in g_object_new_valist
/home/mcatanzaro/src/jhbuild/checkout/glib/gobject/gobject.c:2042
#17 0x7f036919beaa in g_object_new
/home/mcatanzaro/src/jhbuild/checkout/glib/gobject/gobject.c:1626
#18 0x7f03799f13a4 in ephy_bookmarks_popover_new
/home/mcatanzaro/src/jhbuild/checkout/epiphany/src/bookmarks/ephy-bookmarks-popover.c:559
#19 0x7f03799f8dbe in ephy_header_bar_constructed
/home/mcatanzaro/src/jhbuild/checkout/epiphany/src/ephy-header-bar.c:701
#20 0x7f036919c3f5 in g_object_new_internal
/home/mcatanzaro/src/jhbuild/checkout/glib/gobject/gobject.c:1823
#21 0x7f036919cefe in g_object_new_valist
/home/mcatanzaro/src/jhbuild/checkout/glib/gobject/gobject.c:2042
#22 0x7f036919beaa in g_object_new
/home/mcatanzaro/src/jhbuild/checkout/glib/gobject/gobject.c:1626
#23 0x7f03799f9583 in ephy_header_bar_new
/home/mcatanzaro/src/jhbuild/checkout/epiphany/src/ephy-header-bar.c:793
#24 0x7f0379a15fcf in setup_header_bar
/home/mcatanzaro/src/jhbuild/checkout/epiphany/src/ephy-window.c:2835
#25 0x7f0379a16850 in ephy_window_constructed
/home/mcatanzaro/src/jhbuild/checkout/epiphany/src/ephy-window.c:3005
#26 0x7f036919c3f5 in g_object_new_internal
/home/mcatanzaro/src/jhbuild/checkout/glib/gobject/gobject.c:1823
#27 0x7f036919cefe in g_object_new_valist
/home/mcatanzaro/src/jhbuild/checkout/glib/gobject/gobject.c:2042
#28 0x7f036919beaa in g_object_new
/home/mcatanzaro/src/jhbuild/checkout/glib/gobject/gobject.c:1626
#29 0x7f0379a17200 in ephy_window_new
/home/mcatanzaro/src/jhbuild/checkout/epiphany/src/ephy-window.c:3134
src/bookmarks/ephy-bookmark.c | 1 +
1 file changed, 1 insertion(+)
commit ae04d88ad5fc66e4868dedcba971d24d914ce338
Author: Michael Catanzaro <mcatanzaro@gnome.org>
Date: Mon Nov 21 14:12:20 2016 -0600
sync-service: Fix leak in _init
Direct leak of 25 byte(s) in 1 object(s) allocated from:
#0 0x7fd43d6ade60 in malloc (/lib64/libasan.so.3+0xc6e60)
#1 0x7fd4291b88f6 in g_malloc
/home/mcatanzaro/src/jhbuild/checkout/glib/glib/gmem.c:94
#2 0x7fd4291b8bb3 in g_malloc_n
/home/mcatanzaro/src/jhbuild/checkout/glib/glib/gmem.c:331
#3 0x7fd4291d54d8 in g_strdup
/home/mcatanzaro/src/jhbuild/checkout/glib/glib/gstrfuncs.c:363
#4 0x7fd4291f3946 in g_variant_dup_string
/home/mcatanzaro/src/jhbuild/checkout/glib/glib/gvariant.c:1529
#5 0x7fd42cbaabea in g_settings_get_string
/home/mcatanzaro/src/jhbuild/checkout/glib/gio/gsettings.c:1791
#6 0x7fd43d0a0a35 in ephy_sync_service_init
/home/mcatanzaro/src/jhbuild/checkout/epiphany/src/sync/ephy-sync-service.c:621
#7 0x7fd42c82cc55 in g_type_create_instance
/home/mcatanzaro/src/jhbuild/checkout/glib/gobject/gtype.c:1866
#8 0x7fd42c8132aa in g_object_new_internal
/home/mcatanzaro/src/jhbuild/checkout/glib/gobject/gobject.c:1783
#9 0x7fd42c8137b9 in g_object_newv
/home/mcatanzaro/src/jhbuild/checkout/glib/gobject/gobject.c:1930
#10 0x7fd42c812e5b in g_object_new
/home/mcatanzaro/src/jhbuild/checkout/glib/gobject/gobject.c:1623
#11 0x7fd43d0a0a8d in ephy_sync_service_new
/home/mcatanzaro/src/jhbuild/checkout/epiphany/src/sync/ephy-sync-service.c:632
#12 0x7fd43d08086c in ephy_shell_startup
/home/mcatanzaro/src/jhbuild/checkout/epiphany/src/ephy-shell.c:325
#13 0x7fd42c80d9de in g_cclosure_marshal_VOID__VOID
/home/mcatanzaro/src/jhbuild/checkout/glib/gobject/gmarshal.c:875
#14 0x7fd42c80b01b in g_type_class_meta_marshal
/home/mcatanzaro/src/jhbuild/checkout/glib/gobject/gclosure.c:997
#15 0x7fd42c80a9c7 in g_closure_invoke
/home/mcatanzaro/src/jhbuild/checkout/glib/gobject/gclosure.c:804
#16 0x7fd42c827b7e in signal_emit_unlocked_R
/home/mcatanzaro/src/jhbuild/checkout/glib/gobject/gsignal.c:3565
#17 0x7fd42c8271b6 in g_signal_emit_valist
/home/mcatanzaro/src/jhbuild/checkout/glib/gobject/gsignal.c:3391
#18 0x7fd42c8276f8 in g_signal_emit
/home/mcatanzaro/src/jhbuild/checkout/glib/gobject/gsignal.c:3447
#19 0x7fd42cb17b91 in g_application_register
/home/mcatanzaro/src/jhbuild/checkout/glib/gio/gapplication.c:2049
#20 0x7fd42cb15db0 in g_application_real_local_command_line
/home/mcatanzaro/src/jhbuild/checkout/glib/gio/gapplication.c:1012
#21 0x7fd42e38b67c in gtk_application_local_command_line
/home/mcatanzaro/src/jhbuild/checkout/gtk+-3/gtk/gtkapplication.c:332
#22 0x7fd42cb182af in g_application_run
/home/mcatanzaro/src/jhbuild/checkout/glib/gio/gapplication.c:2350
#23 0x4032ab in main
/home/mcatanzaro/src/jhbuild/checkout/epiphany/src/ephy-main.c:432
#24 0x7fd428dba730 in __libc_start_main (/lib64/libc.so.6+0x20730)
src/sync/ephy-sync-service.c | 2 ++
1 file changed, 2 insertions(+)
commit 0dc4191bedcaac174ad5ac4eb785e4195a4450e9
Author: Michael Catanzaro <mcatanzaro@gnome.org>
Date: Mon Nov 21 14:11:25 2016 -0600
bookmarks-manager: Fix leaks in _load_from_file
Direct leak of 80 byte(s) in 1 object(s) allocated from:
#0 0x7fd43d6ae020 in calloc (/lib64/libasan.so.3+0xc7020)
#1 0x7fd4291b895f in g_malloc0
/home/mcatanzaro/src/jhbuild/checkout/glib/glib/gmem.c:124
#2 0x7fd4291b8c27 in g_malloc0_n
/home/mcatanzaro/src/jhbuild/checkout/glib/glib/gmem.c:355
#3 0x7fd43d0da5e7 in gvdb_table_get_names
/home/mcatanzaro/src/jhbuild/checkout/epiphany/gvdb/gvdb/gvdb-reader.c:381
#4 0x7fd43d0653ed in ephy_bookmarks_manager_load_from_file
/home/mcatanzaro/src/jhbuild/checkout/epiphany/src/bookmarks/ephy-bookmarks-manager.c:577
#5 0x7fd43d06426a in ephy_bookmarks_manager_init
/home/mcatanzaro/src/jhbuild/checkout/epiphany/src/bookmarks/ephy-bookmarks-manager.c:223
#6 0x7fd42c82cc55 in g_type_create_instance
/home/mcatanzaro/src/jhbuild/checkout/glib/gobject/gtype.c:1866
#7 0x7fd42c8132aa in g_object_new_internal
/home/mcatanzaro/src/jhbuild/checkout/glib/gobject/gobject.c:1783
#8 0x7fd42c8137b9 in g_object_newv
/home/mcatanzaro/src/jhbuild/checkout/glib/gobject/gobject.c:1930
#9 0x7fd42c812e5b in g_object_new
/home/mcatanzaro/src/jhbuild/checkout/glib/gobject/gobject.c:1623
#10 0x7fd43d0642fc in ephy_bookmarks_manager_new
/home/mcatanzaro/src/jhbuild/checkout/epiphany/src/bookmarks/ephy-bookmarks-manager.c:245
#11 0x7fd43d0823bf in ephy_shell_get_bookmarks_manager
/home/mcatanzaro/src/jhbuild/checkout/epiphany/src/ephy-shell.c:773
#12 0x7fd43d067ce7 in ephy_bookmarks_popover_init
/home/mcatanzaro/src/jhbuild/checkout/epiphany/src/bookmarks/ephy-bookmarks-popover.c:485
#13 0x7fd42c82cc55 in g_type_create_instance
/home/mcatanzaro/src/jhbuild/checkout/glib/gobject/gtype.c:1866
#14 0x7fd42c8132aa in g_object_new_internal
/home/mcatanzaro/src/jhbuild/checkout/glib/gobject/gobject.c:1783
#15 0x7fd42c813efe in g_object_new_valist
/home/mcatanzaro/src/jhbuild/checkout/glib/gobject/gobject.c:2042
#16 0x7fd42c812eaa in g_object_new
/home/mcatanzaro/src/jhbuild/checkout/glib/gobject/gobject.c:1626
#17 0x7fd43d068386 in ephy_bookmarks_popover_new
/home/mcatanzaro/src/jhbuild/checkout/epiphany/src/bookmarks/ephy-bookmarks-popover.c:559
#18 0x7fd43d06fda0 in ephy_header_bar_constructed
/home/mcatanzaro/src/jhbuild/checkout/epiphany/src/ephy-header-bar.c:701
#19 0x7fd42c8133f5 in g_object_new_internal
/home/mcatanzaro/src/jhbuild/checkout/glib/gobject/gobject.c:1823
#20 0x7fd42c813efe in g_object_new_valist
/home/mcatanzaro/src/jhbuild/checkout/glib/gobject/gobject.c:2042
#21 0x7fd42c812eaa in g_object_new
/home/mcatanzaro/src/jhbuild/checkout/glib/gobject/gobject.c:1626
#22 0x7fd43d070565 in ephy_header_bar_new
/home/mcatanzaro/src/jhbuild/checkout/epiphany/src/ephy-header-bar.c:793
#23 0x7fd43d08cf31 in setup_header_bar
/home/mcatanzaro/src/jhbuild/checkout/epiphany/src/ephy-window.c:2835
#24 0x7fd43d08d7b2 in ephy_window_constructed
/home/mcatanzaro/src/jhbuild/checkout/epiphany/src/ephy-window.c:3005
#25 0x7fd42c8133f5 in g_object_new_internal
/home/mcatanzaro/src/jhbuild/checkout/glib/gobject/gobject.c:1823
#26 0x7fd42c813efe in g_object_new_valist
/home/mcatanzaro/src/jhbuild/checkout/glib/gobject/gobject.c:2042
#27 0x7fd42c812eaa in g_object_new
/home/mcatanzaro/src/jhbuild/checkout/glib/gobject/gobject.c:1626
#28 0x7fd43d08e162 in ephy_window_new
/home/mcatanzaro/src/jhbuild/checkout/epiphany/src/ephy-window.c:3134
#29 0x7fd43d07d58d in session_parse_window
/home/mcatanzaro/src/jhbuild/checkout/epiphany/src/ephy-session.c:1082
src/bookmarks/ephy-bookmarks-manager.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
commit 554bedef320f4a65be0f9441846a2b608b4ac215
Author: Michael Catanzaro <mcatanzaro@gnome.org>
Date: Mon Nov 21 14:04:16 2016 -0600
shell: Fix leak of bookmarks manager
Direct leak of 2362 byte(s) in 56 object(s) allocated from:
#0 0x7fd43d6ade60 in malloc (/lib64/libasan.so.3+0xc6e60)
#1 0x7fd4291b88f6 in g_malloc
/home/mcatanzaro/src/jhbuild/checkout/glib/glib/gmem.c:94
#2 0x7fd4291b8bb3 in g_malloc_n
/home/mcatanzaro/src/jhbuild/checkout/glib/glib/gmem.c:331
#3 0x7fd4291d54d8 in g_strdup
/home/mcatanzaro/src/jhbuild/checkout/glib/glib/gstrfuncs.c:363
#4 0x7fd43d05e0af in ephy_bookmark_new
/home/mcatanzaro/src/jhbuild/checkout/epiphany/src/bookmarks/ephy-bookmark.c:283
#5 0x7fd43d06567d in ephy_bookmarks_manager_load_from_file
/home/mcatanzaro/src/jhbuild/checkout/epiphany/src/bookmarks/ephy-bookmarks-manager.c:618
#6 0x7fd43d06426a in ephy_bookmarks_manager_init
/home/mcatanzaro/src/jhbuild/checkout/epiphany/src/bookmarks/ephy-bookmarks-manager.c:223
#7 0x7fd42c82cc55 in g_type_create_instance
/home/mcatanzaro/src/jhbuild/checkout/glib/gobject/gtype.c:1866
#8 0x7fd42c8132aa in g_object_new_internal
/home/mcatanzaro/src/jhbuild/checkout/glib/gobject/gobject.c:1783
#9 0x7fd42c8137b9 in g_object_newv
/home/mcatanzaro/src/jhbuild/checkout/glib/gobject/gobject.c:1930
#10 0x7fd42c812e5b in g_object_new
/home/mcatanzaro/src/jhbuild/checkout/glib/gobject/gobject.c:1623
#11 0x7fd43d0642fc in ephy_bookmarks_manager_new
/home/mcatanzaro/src/jhbuild/checkout/epiphany/src/bookmarks/ephy-bookmarks-manager.c:245
#12 0x7fd43d0823bf in ephy_shell_get_bookmarks_manager
/home/mcatanzaro/src/jhbuild/checkout/epiphany/src/ephy-shell.c:773
#13 0x7fd43d067ce7 in ephy_bookmarks_popover_init
/home/mcatanzaro/src/jhbuild/checkout/epiphany/src/bookmarks/ephy-bookmarks-popover.c:485
#14 0x7fd42c82cc55 in g_type_create_instance
/home/mcatanzaro/src/jhbuild/checkout/glib/gobject/gtype.c:1866
#15 0x7fd42c8132aa in g_object_new_internal
/home/mcatanzaro/src/jhbuild/checkout/glib/gobject/gobject.c:1783
#16 0x7fd42c813efe in g_object_new_valist
/home/mcatanzaro/src/jhbuild/checkout/glib/gobject/gobject.c:2042
#17 0x7fd42c812eaa in g_object_new
/home/mcatanzaro/src/jhbuild/checkout/glib/gobject/gobject.c:1626
#18 0x7fd43d068386 in ephy_bookmarks_popover_new
/home/mcatanzaro/src/jhbuild/checkout/epiphany/src/bookmarks/ephy-bookmarks-popover.c:559
#19 0x7fd43d06fda0 in ephy_header_bar_constructed
/home/mcatanzaro/src/jhbuild/checkout/epiphany/src/ephy-header-bar.c:701
#20 0x7fd42c8133f5 in g_object_new_internal
/home/mcatanzaro/src/jhbuild/checkout/glib/gobject/gobject.c:1823
#21 0x7fd42c813efe in g_object_new_valist
/home/mcatanzaro/src/jhbuild/checkout/glib/gobject/gobject.c:2042
#22 0x7fd42c812eaa in g_object_new
/home/mcatanzaro/src/jhbuild/checkout/glib/gobject/gobject.c:1626
#23 0x7fd43d070565 in ephy_header_bar_new
/home/mcatanzaro/src/jhbuild/checkout/epiphany/src/ephy-header-bar.c:793
#24 0x7fd43d08cf31 in setup_header_bar
/home/mcatanzaro/src/jhbuild/checkout/epiphany/src/ephy-window.c:2835
#25 0x7fd43d08d7b2 in ephy_window_constructed
/home/mcatanzaro/src/jhbuild/checkout/epiphany/src/ephy-window.c:3005
#26 0x7fd42c8133f5 in g_object_new_internal
/home/mcatanzaro/src/jhbuild/checkout/glib/gobject/gobject.c:1823
#27 0x7fd42c813efe in g_object_new_valist
/home/mcatanzaro/src/jhbuild/checkout/glib/gobject/gobject.c:2042
#28 0x7fd42c812eaa in g_object_new
/home/mcatanzaro/src/jhbuild/checkout/glib/gobject/gobject.c:1626
#29 0x7fd43d08e162 in ephy_window_new
/home/mcatanzaro/src/jhbuild/checkout/epiphany/src/ephy-window.c:3134
Notes:
Note this did not actually fix the asan trace in the commit
message. Really fixed in 4ab313b322cc5bca542dfc6d183438a4557db018.
src/ephy-shell.c | 1 +
1 file changed, 1 insertion(+)
commit 12cf6bb7a294e414a95a242ef50ebe1d5a0db266
Author: Michael Catanzaro <mcatanzaro@gnome.org>
Date: Mon Nov 21 14:02:05 2016 -0600
sync-crypto: Fix leak in ephy_sync_crypto_calculate_mac
Direct leak of 2475 byte(s) in 55 object(s) allocated from:
#0 0x7fd43d6ade60 in malloc (/lib64/libasan.so.3+0xc6e60)
#1 0x7fd4291b88f6 in g_malloc
/home/mcatanzaro/src/jhbuild/checkout/glib/glib/gmem.c:94
#2 0x7fd42917dafd in g_base64_encode
/home/mcatanzaro/src/jhbuild/checkout/glib/glib/gbase64.c:269
#3 0x7fd43d09a8ff in ephy_sync_crypto_calculate_mac
/home/mcatanzaro/src/jhbuild/checkout/epiphany/src/sync/ephy-sync-crypto.c:332
#4 0x7fd43d09c032 in ephy_sync_crypto_compute_hawk_header
/home/mcatanzaro/src/jhbuild/checkout/epiphany/src/sync/ephy-sync-crypto.c:698
#5 0x7fd43d09ef4c in ephy_sync_service_send_storage_request
/home/mcatanzaro/src/jhbuild/checkout/epiphany/src/sync/ephy-sync-service.c:276
#6 0x7fd43d0a0679 in ephy_sync_service_issue_storage_request
/home/mcatanzaro/src/jhbuild/checkout/epiphany/src/sync/ephy-sync-service.c:567
#7 0x7fd43d0a2e6b in
ephy_sync_service_release_next_storage_message
/home/mcatanzaro/src/jhbuild/checkout/epiphany/src/sync/ephy-sync-service.c:1047
#8 0x7fd43d0a38ef in delete_bookmark_conditional_response_cb
/home/mcatanzaro/src/jhbuild/checkout/epiphany/src/sync/ephy-sync-service.c:1196
#9 0x7fd42cec3984 in soup_session_process_queue_item
/home/mcatanzaro/src/jhbuild/checkout/libsoup/libsoup/soup-session.c:2038
#10 0x7fd42cec3afe in async_run_queue
/home/mcatanzaro/src/jhbuild/checkout/libsoup/libsoup/soup-session.c:2077
#11 0x7fd42cec3c25 in idle_run_queue
/home/mcatanzaro/src/jhbuild/checkout/libsoup/libsoup/soup-session.c:2111
#12 0x7fd4291b2cf4 in g_idle_dispatch
/home/mcatanzaro/src/jhbuild/checkout/glib/glib/gmain.c:5545
#13 0x7fd4291b02b4 in g_main_dispatch
/home/mcatanzaro/src/jhbuild/checkout/glib/glib/gmain.c:3203
#14 0x7fd4291b1136 in g_main_context_dispatch
/home/mcatanzaro/src/jhbuild/checkout/glib/glib/gmain.c:3856
#15 0x7fd4291b131a in g_main_context_iterate
/home/mcatanzaro/src/jhbuild/checkout/glib/glib/gmain.c:3929
#16 0x7fd4291b13de in g_main_context_iteration
/home/mcatanzaro/src/jhbuild/checkout/glib/glib/gmain.c:3990
#17 0x7fd42cb183bd in g_application_run
/home/mcatanzaro/src/jhbuild/checkout/glib/gio/gapplication.c:2381
#18 0x4032ab in main
/home/mcatanzaro/src/jhbuild/checkout/epiphany/src/ephy-main.c:432
#19 0x7fd428dba730 in __libc_start_main (/lib64/libc.so.6+0x20730)
src/sync/ephy-sync-crypto.c | 1 +
1 file changed, 1 insertion(+)
commit 15c52b192a31591ebc8d5bdc77907f67cc2be034
Author: Michael Catanzaro <mcatanzaro@gnome.org>
Date: Mon Nov 21 11:40:02 2016 -0600
sync-crypto: Clarify memory ownership
We were sometimes leaking hash; this fixes that. Also, we had a
use-after-free here using the SoupURI after it had already been freed.
https://bugzilla.gnome.org/show_bug.cgi?id=774804
src/sync/ephy-sync-crypto.c | 22 ++++++++++------------
1 file changed, 10 insertions(+), 12 deletions(-)
commit a5dadf8970eb350762f26f4b8df1855dae159bc6
Author: Michael Catanzaro <mcatanzaro@gnome.org>
Date: Mon Nov 21 13:48:17 2016 -0600
uri-tester: Fix uninitialized memory use when DNT mode is disabled
embed/ephy-uri-tester.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
commit dc2e8c4fdee3767f9b23569837c23b1583294ae2
Author: Michael Catanzaro <mcatanzaro@gnome.org>
Date: Mon Nov 21 13:13:13 2016 -0600
uri-tester: Fix criticals before libhttpseverywhere is initialized
I added a performance optimization to short-circuit the deferred
request
system for non-http:// URIs, since there's no reason to wait for
libhttpseverywhere to be ready before processing them. But I forgot to
actually not use libhttpseverywhere in that case, and changed
libhttpseverywhere to emit the critical immediately instead of after
checking the URI scheme.
embed/ephy-uri-tester.c | 10 +++++++---
1 file changed, 7 insertions(+), 3 deletions(-)
commit c27e7004142ae0f736330c074893fb0f22ccf5db
Author: Michael Catanzaro <mcatanzaro@gnome.org>
Date: Mon Nov 21 12:17:26 2016 -0600
uri-tester: Fix criticals when libhttpseverywhere init is cancelled
embed/ephy-uri-tester.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
commit 86fd75de53ba32726e46a3409e0ec2465e6e0181
Author: Carlos Garcia Campos <cgarcia@igalia.com>
Date: Mon Nov 21 12:23:53 2016 +0100
Fix bookmarks migration
EphyBookmarksManager always creates an empty bookmarks.gvdb on
its init
method, and migrate_bookmarks() checks whether bookmarks.gvdb already
exists to avoid migrating the bookmarks twice. Since
migrate_bookmarks()
creates the EphyBookmarksManager before checking for bookmarks.gvdb,
it
always exists and bookmarks are never migrated. This is a regression
introduced in commit 54006df8dba31a5a58686e7d2473d64f3e454683.
This patch creates the manager after the initial checks, so that
we also
avoid creating the manager and all the sync IO involved if we are not
going to use it.
https://bugzilla.gnome.org/show_bug.cgi?id=774785
src/profile-migrator/ephy-profile-migrator.c | 20 ++++++++++++--------
1 file changed, 12 insertions(+), 8 deletions(-)
commit cd011c46341d0d9a10b1118a09781394e47e746e
Author: Carlos Garcia Campos <cgarcia@igalia.com>
Date: Mon Nov 21 12:07:20 2016 +0100
bookmarks: Add ephy_bookmarks_manager_new()
And use it instead of g_object_new().
src/bookmarks/ephy-bookmarks-manager.c | 6 ++++++
src/bookmarks/ephy-bookmarks-manager.h | 2 ++
src/ephy-shell.c | 2 +-
src/profile-migrator/ephy-profile-migrator.c | 3 +--
src/search-provider/ephy-search-provider.c | 2 +-
5 files changed, 11 insertions(+), 4 deletions(-)