commit a5201060f0f9bfaa86338711e0beaeb0b5660482 Author: Travis Reitter Date: Thu Nov 10 15:35:30 2011 -0800 Release version 0.6.5 backends/eds/lib/edsf-persona.vala | 4 ++-- configure.ac | 10 +++++----- folks/abstract-field-details.vala | 8 ++++---- folks/note-details.vala | 2 +- folks/postal-address-details.vala | 2 +- folks/role-details.vala | 2 +- 6 files changed, 14 insertions(+), 14 deletions(-) commit 26ec5da44de6fbde5f168eaa04a2bfb5c9067043 Author: Travis Reitter Date: Thu Nov 10 14:51:58 2011 -0800 Fix comment syntax to unbreak documentation generation. folks/abstract-field-details.vala | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) commit 2e45c0e8a06a72ad25b87b8b58a7dfeb29263d20 Author: Philip Withnall Date: Wed Sep 21 20:37:30 2011 +0100 telepathy: Fix finalisation of Tpf.Logger if it hasn't been prepared Closes: bgo#659585 NEWS | 2 ++ backends/telepathy/lib/tpf-logger.vala | 6 +++++- 2 files changed, 7 insertions(+), 1 deletions(-) commit 0719b657cacd96edfc2a7159c3228b5fc3e7969f Author: Travis Reitter Date: Thu Nov 3 14:05:45 2011 -0700 Add AbstractFieldDetails.value_type. This allows generic handling of collections of derived objects of mixed concrete classes. Helps: bgo#663798 - Add AbstractFieldDetails.value_type NEWS | 2 + folks/abstract-field-details.vala | 14 ++++++++++ tests/folks/abstract-field-details.vala | 44 +++++++++++++++++++++++++++++++ 3 files changed, 60 insertions(+), 0 deletions(-) commit a36c377652ea2e71319ef2fede2a4d47a6251806 Author: Matej Urbančič Date: Thu Nov 10 21:26:56 2011 +0100 Updated Slovenian translation po/sl.po | 106 ++++++++++++++++++++++++++++++++------------------------------ 1 files changed, 55 insertions(+), 51 deletions(-) commit 7539d6182295bfcaff921a4050a04980d109954c Author: Travis Reitter Date: Wed Nov 9 16:34:22 2011 -0800 Properly serialize AFD values for the Tp cache. We were previously writing serialized Telepathy AbstractFieldDetails values over each other in the final array, which was generally bad and specifically crashed Gnome Shell. This affects AFD-derived structures: phone numbers, email addresses, and URLs. Closes: bgo#662314 - Gnome-shell restarts if I change my user status to disconnected/unavailable NEWS | 2 ++ .../telepathy/lib/tpf-persona-store-cache.vala | 4 ++-- 2 files changed, 4 insertions(+), 2 deletions(-) commit 7abd82627d2f0f089cab8a399cfcff4698ef8b35 Author: Marek Černocký Date: Mon Oct 31 00:29:03 2011 +0100 Updated Czech translation po/cs.po | 169 +++++++++++++++++++++++++++++++++---------------------------- 1 files changed, 91 insertions(+), 78 deletions(-) commit 6b72179a47c6d6ae647897c46743d6739175c912 Author: Daniel Mustieles Date: Mon Oct 31 00:04:31 2011 +0100 Updated Spanish translation po/es.po | 131 +++++++++++++++++++++++++++++-------------------------------- 1 files changed, 62 insertions(+), 69 deletions(-) commit b15f6e0efb4b0191e8f516609e11369afce08b3c Author: Travis Reitter Date: Wed Oct 26 17:30:37 2011 -0700 Generate the same C code whether the eds backend is enabled or not. Previously, the configure options used would alter the release tarball. This would cause problems for anyone building from the shipped C files (specifically, if they also disabled the eds backend, as the Debian packagers did). Closes: bgo#662274 - Failed to link personas: Can't link personas with no primary store. NEWS | 2 ++ folks/individual-aggregator.vala | 17 ++++++++++------- 2 files changed, 12 insertions(+), 7 deletions(-) commit 7e20483ebc830438fc5d377e90e9017e4befead2 Author: Travis Reitter Date: Thu Oct 27 16:44:18 2011 -0700 Warn if the primary store is not found. This includes steps for the user to fix the problem. Helps: bgo#662274 - Failed to link personas: Can't link personas with no primary store. folks/individual-aggregator.vala | 14 ++++++++++++++ 1 files changed, 14 insertions(+), 0 deletions(-) commit f48cf529d06ced6bcb2b597ce1ff57602f886d38 Author: Travis Reitter Date: Fri Oct 28 08:08:54 2011 -0700 Properly set primary stores for tests to exactly what's used. Helps: bgo#662274 - Failed to link personas: Can't link personas with no primary store. tests/eds/add-contacts-stress-test.vala | 7 +++++-- tests/eds/add-persona.vala | 7 +++++-- tests/eds/avatar-details.vala | 7 +++++-- tests/eds/email-details.vala | 7 +++++-- tests/eds/im-details.vala | 7 +++++-- tests/eds/individual-retrieval.vala | 7 +++++-- tests/eds/name-details.vala | 7 +++++-- tests/eds/phone-details.vala | 7 +++++-- tests/eds/postal-address-details.vala | 7 +++++-- tests/eds/remove-persona.vala | 7 +++++-- tests/eds/removing-contacts.vala | 7 +++++-- tests/eds/set-avatar.vala | 7 +++++-- tests/eds/set-birthday.vala | 7 +++++-- tests/eds/set-emails.vala | 7 +++++-- tests/eds/set-gender.vala | 7 +++++-- tests/eds/set-im-addresses.vala | 7 +++++-- tests/eds/set-is-favourite.vala | 7 +++++-- tests/eds/set-names.vala | 7 +++++-- tests/eds/set-notes.vala | 7 +++++-- tests/eds/set-phones.vala | 7 +++++-- tests/eds/set-postal-addresses.vala | 7 +++++-- tests/eds/set-properties-race.vala | 7 +++++-- tests/eds/set-roles.vala | 7 +++++-- tests/eds/set-structured-name.vala | 7 +++++-- tests/eds/set-urls.vala | 7 +++++-- tests/eds/store-removed.vala | 7 +++++-- tests/eds/updating-contacts.vala | 7 +++++-- tests/key-file/Makefile.am | 1 + tests/libsocialweb/Makefile.am | 2 +- tests/libsocialweb/aggregation.vala | 3 +++ tests/telepathy/Makefile.am | 2 +- 31 files changed, 141 insertions(+), 56 deletions(-) commit 1432a353880ad1d1784b20f5edb90fc6179558cd Author: Travis Reitter Date: Wed Oct 26 17:28:56 2011 -0700 Expose the details of which backends are enabled to libfolks. Helps: bgo#662274 - Failed to link personas: Can't link personas with no primary store. configure.ac | 20 +++++++++++++++++++- folks/build-conf.vapi | 9 +++++++++ 2 files changed, 28 insertions(+), 1 deletions(-) commit fc5d0617564c77ed7e48c9a40b05930bb05aff59 Author: Raul Gutierrez Segales Date: Wed Oct 26 16:16:23 2011 +0100 e-d-s: set content type on ContactPhotos Fixes: https://bugzilla.gnome.org/show_bug.cgi?id=662616 NEWS | 1 + backends/eds/lib/edsf-persona-store.vala | 9 +++++++++ 2 files changed, 10 insertions(+), 0 deletions(-) commit aa50fcfa896f9102411f1f5b6772e17129f1decc Author: Raul Gutierrez Segales Date: Wed Oct 26 15:26:07 2011 +0100 e-d-s: load icon regardless of the mime type being available Also, allow Edsf.MemoryIcon to be instantiated with a null image type. The notion of the image type not being available was half there (some comments mentioned the possibility), but it wasn't contemplated in the constructor and in the instance variable. Fixes: https://bugzilla.gnome.org/show_bug.cgi?id=662770 NEWS | 1 + backends/eds/lib/edsf-persona.vala | 2 +- backends/eds/lib/memory-icon.vala | 6 +++--- 3 files changed, 5 insertions(+), 4 deletions(-) commit 56d0a5512cb3163345a1d7fb7dc8a36d118fa43c Author: Travis Reitter Date: Wed Oct 26 12:15:21 2011 -0700 docs: Add description for Folks.Utils class. folks/utils.vala | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-) commit 3dfc0d6c6a2e46f35948ce24bc0a3b60c9fd9ffb Author: Travis Reitter Date: Wed Oct 26 11:36:53 2011 -0700 docs: Add @since for MaybeBool. folks/types.vala | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) commit e79fb69cf1602b31790d4749993ab2edd1fe05fa Author: Travis Reitter Date: Wed Oct 26 11:35:06 2011 -0700 docs: Add a description block for the new types. Note, however, that this is obscured in the final docs due to bgo#662793 (valadoc ignores comment blocks on namespaces). folks/types.vala | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-) commit 4adc85ac3a4c6bcbf6907fee64147eae868c7c46 Author: Travis Reitter Date: Wed Oct 26 11:23:25 2011 -0700 docs: Don't build empty docs for libfolks-internal. docs/Makefile.am | 13 ++++++++++++- 1 files changed, 12 insertions(+), 1 deletions(-) commit 091231c3131c3c65755e4e9152c9d1f85ee981c1 Author: Piotr Drąg Date: Wed Oct 26 20:19:02 2011 +0200 Updated Polish translation po/pl.po | 104 ++++++++++++++++++++++++++++++++------------------------------ 1 files changed, 54 insertions(+), 50 deletions(-) commit 880d9c53c693029a494a259b28a5744b328210ef Author: Travis Reitter Date: Wed Oct 26 09:58:53 2011 -0700 docs: Work around a valadoc comment-parsing issue. folks/abstract-field-details.vala | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-) commit 66a18236c6a0c94c12f86a649633d665aca3fdbc Author: Raul Gutierrez Segales Date: Tue Oct 25 17:18:41 2011 +0100 e-d-s: test setting is-favourite property Helps: https://bugzilla.gnome.org/show_bug.cgi?id=660908 tests/eds/Makefile.am | 6 ++ tests/eds/set-is-favourite.vala | 160 +++++++++++++++++++++++++++++++++++++++ 2 files changed, 166 insertions(+), 0 deletions(-) commit d7ecae8905572e7cc7f9a3f90e3e411ec15552ac Author: Raul Gutierrez Segales Date: Tue Oct 25 17:09:01 2011 +0100 e-d-s: extend add-persona test to check for is-favourite Helps: https://bugzilla.gnome.org/show_bug.cgi?id=660908 tests/eds/add-persona.vala | 14 ++++++++++++++ 1 files changed, 14 insertions(+), 0 deletions(-) commit 35e425903dff408fc4da4fa6577cb6f8ae4caf17 Author: Raul Gutierrez Segales Date: Tue Oct 25 16:49:14 2011 +0100 e-d-s: add favourites support to EDS backend Fixes: https://bugzilla.gnome.org/show_bug.cgi?id=660908 NEWS | 2 + backends/eds/lib/edsf-persona-store.vala | 44 +++++++++++++++++++++++- backends/eds/lib/edsf-persona.vala | 53 ++++++++++++++++++++++++++++++ 3 files changed, 97 insertions(+), 2 deletions(-) commit c832a3a0c787c534a792a8ffb511b72fdc51dc3a Author: Philip Withnall Date: Mon Oct 24 20:20:00 2011 +0100 core: Add extra debug for primary store configuration folks/individual-aggregator.vala | 27 ++++++++++++++++++++++++++- 1 files changed, 26 insertions(+), 1 deletions(-) commit aefe543c31a3802b4c5c033b2b45a3744e7dc151 Author: Travis Reitter Date: Fri Oct 21 16:05:30 2011 -0700 Simplify NoteFieldDetails.equal() folks/note-details.vala | 9 +-------- 1 files changed, 1 insertions(+), 8 deletions(-) commit 49110792cc3de8d7aa7dbab9d7453d26cf3b4f60 Author: Travis Reitter Date: Fri Oct 21 16:05:16 2011 -0700 Simplify PhoneFieldDetails.equal() folks/phone-details.vala | 9 +-------- 1 files changed, 1 insertions(+), 8 deletions(-) commit f9af4cbcb3a378bc375f406ff0336f293bd2bf92 Author: Travis Reitter Date: Fri Oct 21 15:54:07 2011 -0700 Check the GLib.Type of both elements for AbstractFieldDetails.equal() This simplifies the code for overridden equal() functions. folks/abstract-field-details.vala | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) commit 8b991be5f2ab4fd8d81956c973c656479f899144 Author: Travis Reitter Date: Fri Oct 21 09:37:26 2011 -0700 Add AbstractFieldDetails.values_equal(). This function is lets subclasses to provide "smart" value comparisons without needing to factor in the parameters. This is particularly important for uses like PotententialMatches. This clarifies the roles of AbstractFieldDetails.equal() and parameters_equal() (both in form and documentation). Closes: bgo#662433 - AbstractFieldDetails.equal() is ambiguous about checking parameters. NEWS | 3 + folks/abstract-field-details.vala | 78 +++++++++++++++++++++++++++++-------- folks/phone-details.vala | 12 ++++++ folks/potential-match.vala | 2 +- 4 files changed, 77 insertions(+), 18 deletions(-) commit 144583fd56fcbb9325e54ee6ded5d5005a3d3b62 Author: Travis Reitter Date: Fri Oct 21 08:17:41 2011 -0700 Migrate PhoneDetails to using AbstractFieldDetails.id Helps: bgo#662433 - AbstractFieldDetails.equal() is ambiguous about checking parameters. backends/tracker/lib/trf-persona.vala | 9 ++++----- folks/phone-details.vala | 10 ++++++++++ 2 files changed, 14 insertions(+), 5 deletions(-) commit ba233588b1208c761e4512054626f6ddb6db8647 Author: Travis Reitter Date: Thu Oct 20 10:24:14 2011 -0700 Migrate RoleDetails to AbstractFieldDetails.id Deprecate Role.uid in favor of AbstractFieldDetails.id Helps: bgo#662433 - AbstractFieldDetails.equal() is ambiguous about checking parameters. NEWS | 1 + backends/tracker/lib/trf-persona.vala | 8 +++++--- folks/role-details.vala | 29 +++++++++++++++++++++++++++++ tests/tracker/role-details-interface.vala | 18 ++++++++++++++++++ 4 files changed, 53 insertions(+), 3 deletions(-) commit 99e18f7bc15a793768b8a32b4bdb769a2c68ca04 Author: Travis Reitter Date: Thu Oct 20 17:11:45 2011 -0700 Guarantee all Role members are non-null. Helps: bgo#662433 - AbstractFieldDetails.equal() is ambiguous about checking parameters. folks/role-details.vala | 42 +++++++++++++++++++++++------------------- 1 files changed, 23 insertions(+), 19 deletions(-) commit 35e99dc1a1d2f1f5d60e14b321ba8ed10b829a1b Author: Travis Reitter Date: Thu Oct 20 10:23:51 2011 -0700 Migrate NoteDetails to AbstractFieldDetails.id Deprecate NoteFieldDetails.uid in favor of AbstractFieldDetails.id NoteFieldDetails.equal() now ignores NoteFieldDetails.uid Helps: bgo#662433 - AbstractFieldDetails.equal() is ambiguous about checking parameters. NEWS | 2 ++ folks/note-details.vala | 27 +++++++++++++++++++-------- tests/tracker/note-details-interface.vala | 20 ++++++++++++++++++-- 3 files changed, 39 insertions(+), 10 deletions(-) commit 25a17b0ca731ce8f9140e2c09ff60003cc5f1b9e Author: Travis Reitter Date: Fri Oct 21 10:11:55 2011 -0700 Guarantee all NoteFieldDetails members are non-null. Helps: bgo#662433 - AbstractFieldDetails.equal() is ambiguous about checking parameters. folks/note-details.vala | 8 +++++++- 1 files changed, 7 insertions(+), 1 deletions(-) commit ece9fa3f9baf1d0e0bdc5f68287d1aefa7ae5ccc Author: Travis Reitter Date: Thu Oct 20 10:24:40 2011 -0700 Use the most-parent equal() function when comparing postal addresses. Helps: bgo#662433 - AbstractFieldDetails.equal() is ambiguous about checking parameters. tests/tracker/set-postal-addresses.vala | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) commit cb4f43fc84f359589467543136e43302950959d0 Author: Travis Reitter Date: Thu Oct 20 10:23:08 2011 -0700 Migrate PostalAddressDetails to using AbstractFieldDetails.id Deprecate PostalAddress.uid in favor of AbstractFieldDetails.id PostalAddress.equal() now ignores PostalAddress.uid Helps: bgo#662433 - AbstractFieldDetails.equal() is ambiguous about checking parameters. NEWS | 4 ++ backends/tracker/lib/trf-persona.vala | 5 ++- folks/postal-address-details.vala | 33 ++++++++++++++++++- tests/eds/add-persona.vala | 2 +- tests/eds/postal-address-details.vala | 2 +- tests/eds/set-postal-addresses.vala | 2 +- tests/eds/set-properties-race.vala | 2 +- tests/tracker/add-persona.vala | 4 +- .../tracker/postal-address-details-interface.vala | 19 +++++++++++- tests/tracker/set-postal-addresses.vala | 2 +- 10 files changed, 63 insertions(+), 12 deletions(-) commit 5de6a7d202ad70d9a9f22e031c01267cbd8374b3 Author: Travis Reitter Date: Thu Oct 20 10:19:28 2011 -0700 Add AbstractFieldDetails.id to identify instances of details. This will unify the way we handle IDs for the various classes that derive from AbstractFieldDetails for eccentric data stores (I'm looking at you, Tracker). Helps: bgo#662433 - AbstractFieldDetails.equal() is ambiguous about checking parameters. NEWS | 3 +++ folks/abstract-field-details.vala | 19 +++++++++++++++++++ 2 files changed, 22 insertions(+), 0 deletions(-) commit ff098f0adbfbfc91545b07ae632833929c897d9c Author: Travis Reitter Date: Wed Oct 19 22:42:51 2011 -0700 Only add non-empty Role components to Edsf.Personas. The EDS test "set-roles" was failing because some empty parameters were getting added to Edsf.Personas, thus failing parameter equality checks. Helps: bgo#662433 - AbstractFieldDetails.equal() is ambiguous about checking parameters. backends/eds/lib/edsf-persona.vala | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-) commit 9bb9f634a128052356e320c903a172a9cbe837c8 Author: Travis Reitter Date: Wed Oct 19 22:50:15 2011 -0700 Properly set the parameters for the eds/set-phones test Helps: bgo#662433 - AbstractFieldDetails.equal() is ambiguous about checking parameters. tests/eds/set-phones.vala | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) commit d40b76da12299674e178ed72f5a654ba3f253ab1 Author: Travis Reitter Date: Wed Oct 19 19:45:29 2011 -0700 Fix eds test add-persona for param matching Helps: bgo#662433 - AbstractFieldDetails.equal() is ambiguous about checking parameters. tests/eds/add-persona.vala | 27 ++++++++++++++++++++------- 1 files changed, 20 insertions(+), 7 deletions(-) commit 099063f11036158c55bd3f1bd613905099b5f0ed Author: Travis Reitter Date: Wed Oct 19 19:30:33 2011 -0700 Fix the params used for the postal-address-details eds test Helps: bgo#662433 - AbstractFieldDetails.equal() is ambiguous about checking parameters. tests/eds/postal-address-details.vala | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) commit e66fba36c1ef69674aca7b631debbc47928952b1 Author: Travis Reitter Date: Wed Oct 19 14:18:23 2011 -0700 Always include parameters in AFD-derived subclass equal() functions. Helps: bgo#662433 - AbstractFieldDetails.equal() is ambiguous about checking parameters. folks/abstract-field-details.vala | 19 +++++++++++++++++++ folks/note-details.vala | 4 +++- folks/phone-details.vala | 4 +++- folks/postal-address-details.vala | 3 +++ folks/role-details.vala | 4 +++- 5 files changed, 31 insertions(+), 3 deletions(-) commit 67bd5f4e8b8a1b59354b08b8945ed5201b8a3eb4 Author: Travis Reitter Date: Wed Oct 19 15:48:28 2011 -0700 Factor out AFD parameter equality (for use in derived classes) Helps: bgo#662433 - AbstractFieldDetails.equal() is ambiguous about checking parameters. folks/abstract-field-details.vala | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-) commit 8d86791dfb9595a1e220292fc6b20650e1f1d1b1 Author: Travis Reitter Date: Wed Oct 19 14:23:41 2011 -0700 Fix the signature of RoleFieldDetails.equal() Helps: bgo#662433 - AbstractFieldDetails.equal() is ambiguous about checking parameters. folks/role-details.vala | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) commit 544e02ff34ec5f40dc5dadabb2ebd16177bca67b Author: Travis Reitter Date: Wed Oct 19 15:30:40 2011 -0700 Add test for RoleFieldDetails. Helps: bgo#662433 - AbstractFieldDetails.equal() is ambiguous about checking parameters. tests/folks/abstract-field-details.vala | 16 ++++++++++++++++ 1 files changed, 16 insertions(+), 0 deletions(-) commit 91ea24e24ce8a8a135ccee3ef9355b0f997b0a72 Author: Travis Reitter Date: Thu Oct 20 10:13:35 2011 -0700 Fix trivial spacing issues. tests/tracker/set-postal-addresses.vala | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) commit cf255636136aab4cd6673b2d963641607fe059c9 Author: Alexander Larsson Date: Thu Oct 20 13:58:01 2011 +0200 Correctly update email based im addresses during contact changes When we have already read a contact, but are updating it e.g. due to a property change there is a problem in Edsf.Persons._update_im_addressess(). Its looking at the existing personas im_addresses for already existing im addresses before adding new ones. However, they were already added there based on the email addresses last time, which means we don't add them now. The fix is simple, just look in new_im_addressess for existing im_addresses. https://bugzilla.gnome.org/show_bug.cgi?id=662285 NEWS | 1 + backends/eds/lib/edsf-persona.vala | 2 +- 2 files changed, 2 insertions(+), 1 deletions(-) commit 965b4b47aefe8aaa62b1f8a76d1b60e8f5c1c9a8 Author: Travis Reitter Date: Tue Oct 18 10:51:55 2011 -0700 Post-release version bump. NEWS | 4 ++++ configure.ac | 4 ++-- 2 files changed, 6 insertions(+), 2 deletions(-)