2007-07-09 Brian Cameron <brian.cameron@sun.com> * Release 2.19.4: * configure.ac: Updated to new release version * NEWS: Updated. * Makefile.am: Add icon-theme.cache file to distuninstallcheck_listfiles so "make distcheck" works. 2007-07-09 Brian Cameron <brian.cameron@sun.com> * daemon/slave.c: Fix MAXPATHLEN check so it works when MAXPATHLEN is defined. 2007-07-09 Brian Cameron <brian.cameron@sun.com> * gui/greeter/Makefile.am, gui/greeter/greeter.c, gui/greeter/greeter_canvas_item.c, gui/greeter/greeter_system.c: Add icons to the gdmgreeter menu. * configure.ac, pixmaps/Makefile.am: Add new 24x24 directory. * pixmaps/24x24/*: New directory with pixmaps to show in the gdmgreeter menu. This addresses enhancement request #360984. Patch by myself at Michael Terry. 2007-07-09 Brian Cameron <brian.cameron@sun.com> * daemon/slave.c: Define MAXPATHLEN to PATH_MAX if MAXPATHLEN does not exist on the system. Fixes bug #454777. Patch by Laurent Goujon <laurent.goujon@online.fr>. 2007-07-05 Brian Cameron <brian.cameron@sun.com> * daemon/verify-pam.c: Add logindevperm debug messages, so it is easier to tell when it is working. * config/Makefile.am: Fix typo that was causing the UtmpLineAttached and UtmpLineRemote values to not get filled with proper defaults. 2007-07-02 Brian Cameron <brian.cameron@sun.com> * acconfig.h, configure.ac, config/Makefile.am, config/gdm.conf.in, daemon/gdm-daemon-config-entries.h, daemon/gdm-daemon-config-keys.c, daemon/gdm-daemon-config.c, daemon/slave.c: Set UtmpLineAttached, UtmpLineRemote, and UtmpPseudoDevice based on OS. On Solaris set to dtlocal, dtremote, and true. On Linux set to "/dev/console", NULL, and false. * daemon/verify-pam.c: Fix logindevperm logic so that we only call logindevperm for VT devices and for the "/dev/console" device. 2007-07-02 Brian Cameron <brian.cameron@sun.com> * daemon/gdm.c daemon/display.[ch], daemon/verify-pam.c, daemon/slave.[ch], daemon/gdm-daemon-config-entries.h, daemon/gdm-daemon-config-keys.h, daemon/gdm-daemon-config.c daemon/server.h, config/gdm.conf.in: Improve configurability of how ut_line is set when doing utmp/wtmp processing. Now GDM supports the ability to specify the device in the [servers] section and also to define default local/remote values via the new UtmpLineAttached and UtmpLineRemote configuration options. The new UtmpPseudoDevice configuration option allows you to specify if pseudo devices should be created. * daemon/slave.c: Now support a new gdm_slave_parse_enriched_string function used by new device logic. 2007-07-01 Lukasz Zalewski <lukas@dcs.qmul.ac.uk> * gui/greeter/greeter.c: when getting the theme file added a check if the file is readable (the check was only for the file existance previously) + some error messages. Fixes issues raised in bug #451989 2007-06-28 Lo\357c Minier <lool@dooz.org> * gui/gdmlanguages.c, gui/gdmcommon,c, gui/gdmchooser,c, gui/modules/dwellmouselistener.c, gui/modules/keymouselistener.c, daemon/gdm-xdmcp-manager.c, daemon/auth.c, daemon/slave.c, daemon/gdm-daemon-config.c: Fix warnings. Patch by Lo\357c Minier <lool@dooz.org>. 2007-06-28 Lo\357c Minier <lool@dooz.org> * gui/gdmlanguages.c: (gdm_lang_read_locale_file): Remove the default locale selection logic and let the system default to C. Fixes bug #436811. 2007-06-28 Brian Cameron <brian.cameron@sun.com> * gui/gdmlogin.c: Now allow focus to move into the OK and Cancel buttons. Fix the sensitivity of the OK button so it is insensitive when gdmlogin first starts (since it should only be sensitive when there is some string entered in the entry field). This addresses the security issue raised in bug #433495. 2007-06-26 Michael Terry <mike@mterry.name> * gui/login-photo.png, pixmaps/48x48/gdm-login-photo.png, gui/Makefile.am, pixmaps/48x48/Makefile.am: Rename and move login-photo.png to be properly namespaced and with the rest of the installed icons. Followup to #450786. 2007-06-25 Brian Cameron <brian.cameron@sun.com> * gui/gdmchooser.c: Call gdm_common_atspi_launch so that users can launch AT programs when gdmchooser is running. * acconfig.h, configure.ac, daemon/display.[ch], daemon/verify-pam.c, daemon/gdm-xdmcp-manager.c, daemon/getvt.[ch], daemon/slave.[ch]: Fix utmp logic so it works on Linux and improved the logic a bit, fixing bug #450453. Patch by Ray Strode. <rstrode@redhat.com>. Also, I changed the way the XFree86_VT atom is accessed so it is only checked once after X starts and before the gdmgreeter starts, and then the value is cached. This is better because the Atom can be changed by the user, so we do not want to access the Atom after the user session starts. * daemon/slave.c: Fix calls to setfacl so they work in Solaris specific block of code. 2007-06-25 Brian Cameron <brian.cameron@sun.com> * pixmaps/48x48/Makefile.am, pixmaps/32x32/Makefile.am, pixmaps/16x16/Makefile.am, gui/gdmphotosetup.desktop.in, gui/gdmsetup.c, gui/Makefile.am, gui/gdmchooser.c: Install 48x48 icons to the hicolor theme and uses the correct GTK call to grab application icons from the theme, not pixmaps. Fixes enhancement request #450786. Patch by Michael Terry <mike@mterry.name> 2007-06-25 Brian Cameron <brian.cameron@sun.com> * daemon/slave.c: Fix some warnings. 2007-06-21 Brian Cameron <brian.cameron@sun.com> * daemon/slave.[ch]: Add functions to support utmp and wtmp processing. Modified the gdm_window_path function to use the new gdm_get_current_vtnum funtion. This fixes enhancement request #347871. I did modify the patch provided by Ray Strode <rstrode@redhat.com> quite a bit. Biggest changes were to make it use utmpx rather than utmp functions, add utmp handling in addition to wtmp/btmp which was in his original patch, move function from verify-pam.c to slave.c so it also works when PAM isn't being used. Other changes include using the device name for ut_line on Solaris instead of DISPLAY, setting ut_type to DEAD_PROCESS on logout, and adding better error handling and debugging messages. * daemon/getvt.[ch]: Add function gdm_get_current_vtnum which checks the XFree86_VT atom and returns the VT number used by current display. This function used to be a part of the windowpath code. Also added the gdm_get_vt_device and gdm_get_current_vt_device access functions to get the right VT device name. * daemon/verify-pam.[ch]: Now Solaris audit, PAM_TTY, and di_devperm functions pass proper VT device names, not just hardcoded to /dev/console. * daemon/verify-pam.c, daemon/verify-crypt.c, daemon-verify-shadow.c: Cleaned up the gdm_verify_user and gdm_verify_setup_user functions so they do not take the display and local arguments. Since these values are already in the GdmDisplay structure that is passed in, the code is cleaner just to access the values directly from the GdmDisplay structure. * daemon/gdm.c: If gdm_get_current_vt returns -1, return error message, not OK. * daemon/gdm.c, daemon/slave.c: No longer use di_devperm functions to set device ownership to the gdm user. Instead use setfacl to do the same with ACL. This is cleaner and now that VT's are working on Solaris, the di_devperm functions are not an appropriate way to get this behavior. 2007-06-18 Juerg Billeter <j@bitron.ch> * daemon/gdm-daemon-config.c: Initialize lang variable to avoid accessing a random chunk of memory. Fixes bug #448689.