1.19.19: 2011-11-08 Murray Cumming Use escape_sql_id() for privileges SQL queries. * glom/base_db.cc: * glom/libglom/db_utils.cc: * glom/libglom/privs.cc: * glom/mode_design/users/dialog_groups_list.cc: * glom/mode_design/users/dialog_users_list.cc: Use DbUtils::escape_sql_id() instead of manually adding quotes with no escaping. This seems to be the right thing to do for these queries. 2011-11-08 Murray Cumming More use of escape_sql_id(). * glom/base_db.cc: * glom/libglom/db_utils.cc: * glom/libglom/privs.cc: * glom/mode_design/users/dialog_groups_list.cc: * glom/mode_design/users/dialog_users_list.cc: Use escape_sql_id() instead of manually adding quotes with no escaping. However, I have not yet done this for group and user names. 2011-11-08 Murray Cumming libglom: Remove LayoutItem_Field::get_sql_name(). * glom/libglom/utils.cc: build_sql_select_add_fields_to_get(): Use SqlBuilder::add_field_id() instead of LayoutItemField::get_sql_name(). * glom/libglom/data_structure/layout/layoutitem_field.[h|cc]: Remove the now unused get_sql_name() method. 2011-11-08 Murray Cumming libglom: Use escape_sql_id() for column add/crop/change. * glom/libglom/connectionpool.cc: add_column(), drop_column(), * glom/libglom/connectionpool_backends/backend.[h|cc]: * glom/libglom/connectionpool_backends/postgres.cc * glom/libglom/connectionpool_backends/sqlite.[h|cc]: add_column(), drop_column(): Return a bool to indicate failure. change_columns(): Report false return values from these. * Makefile_tests.am * tests/test_selfhosting_new_then_change_columns.cc: Add a simple test, though we do not yet test that the expected change really happened. 2011-11-08 Murray Cumming libglom: Add escape_sql_id() and use it for table add/drop/rename. * glom/libglom/db_utils.[h|cc]: Add escape_sql_id(), using gda_connection_quote_sql_identifier(). create_table(), rename_table(), drop_table(): Use it instead of manually adding quotes with no escaping. * tests/test_selfhosting_new_then_alter_table.cc: Mention that the commented-out test still fails because of libgda bug #663608 . 2011-11-08 Murray Cumming libglom: Add DbUtils::rename_table() and drop_table() and test them. * glom/navigation/box_tables.c: Move query-building code to * glom/libglom/db_utils.[h|cc]: rename_table() and drop_table(). * Makefile_tests.am * tests/test_selfhosting_new_then_alter_table.cc: Add a test of these functions, and of table creation. This shows that we need to escape SQL identifiers to allow characters such as " in table names. 2011-11-07 Murray Cumming Require the latest libgdamm. * configure.ac: We use a new Gnome::Gda::Connection::statement_to_sql() method overload.