commit ec1c807ae0a3d1f2f5ca12c3147e053d1f0bddd1 Author: Victor Toso Date: Fri Aug 25 10:52:14 2017 +0200 Release 0.3.5 NEWS | 41 +++++++++++++++++++++++++++++++++++++++++ 1 file changed, 41 insertions(+) commit 53a2bccb6a623c985cf5a7e558fe52a7c5fbb0d8 Author: Bastien Nocera Date: Thu Aug 24 19:14:27 2017 +0200 Revert "tests: fix url for mocked content in thegamesdb" This reverts commit a93945beb7da8b9334855e67a3f8610c665d26a3. The test is supposed to lookup a Game Gear game, as can be seen from the contents of the results file. Not remembering the original reason for that test case (probably accents :), make it be a test for Game Gear mime-type support in the Games DB code. src/lua-factory/sources/grl-thegamesdb.lua | 3 ++- tests/games/data/network-data.ini | 2 +- tests/games/test_games.c | 2 +- 3 files changed, 4 insertions(+), 3 deletions(-) commit 8f80b1dcf749d2197aed89064465faf5a098813f Author: Carlos Garnacho Date: Tue Aug 22 11:53:21 2017 +0200 tracker: Use standard Sparql1.1 syntax The "AS var" syntax was non-standard, the Sparql1.1 spec defines this syntax as "AS ?var", which Tracker 1.x has also accepted for a very long time. Tracker 2.x is dropping the non-standard syntax, so switch the Tracker plugin to using the Sparql1.1 syntax, which shall work with Tracker 1.x and 2.x. https://bugzilla.gnome.org/show_bug.cgi?id=786602 src/tracker/grl-tracker-source-api.c | 6 +++--- src/tracker/grl-tracker-utils.c | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) commit 95f3e1b9afd86e7ea9d281dab6b99c823f99d993 Author: Pawan Chitrakar Date: Wed Aug 16 08:55:03 2017 +0000 Add Nepali translation po/LINGUAS | 1 + po/ne.po | 648 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 649 insertions(+) commit 152c31cdcce5ac2b25f953fa4f4298a490f8f583 Author: Carlos Garnacho Date: Tue Aug 8 14:24:47 2017 +0200 build: Detect libtracker-sparql-2.0 in meson build Commit fce20295 only added support for autotools, also allow the meson build to detect and use libtracker-sparql-2.0 if found. meson.build | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) commit fce20295baa23a44f1c6263eeaacf255bc85d02b Author: Carlos Garnacho Date: Wed Jun 28 23:42:24 2017 +0200 build: Add libtracker-sparql-2.0 to checks It remains API compatible wrt the previous versions, as far as current usage in the tracker plugin goes. configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 891bd77d569d2b7e7c9d7a9b2c049228ed01684f Author: Bastien Nocera Date: Thu Jun 29 17:27:02 2017 +0200 lua-factory: Fix compile-time warning with GCC7 duplicate ‘const’ declaration specifier [-Wduplicate-decl-specifier] The warning was added in: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=43651 just for this purpose. " int foo(const char const *data); ^~~~~~ 1 warning generated. [...] In that case it was clearly a mistake, because the author meant 'const char *const data' [...] " src/lua-factory/grl-lua-factory.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 40a9efd76b77427ed12b78213961482d1b975093 Author: Rafael Fonseca Date: Fri Jun 17 17:16:10 2016 +0200 flickr: Add EXIF tags to grilo keys https://bugzilla.gnome.org/show_bug.cgi?id=707643 src/flickr/grl-flickr.c | 105 ++++++++++++++++++++++++++++++++++++++++++++++-- 1 file changed, 101 insertions(+), 4 deletions(-) commit 387d9d2a3e671107f4e373b3ff79e852f00680c2 Author: Rafael Fonseca Date: Fri Jun 17 15:40:00 2016 +0200 flickr: Add parsing of EXIF data https://bugzilla.gnome.org/show_bug.cgi?id=707643 src/flickr/gflickr.c | 105 +++++++++++++++++++++++++++++++++++++++++++++++++++ src/flickr/gflickr.h | 6 +++ 2 files changed, 111 insertions(+) commit ff95957114b081cafd3940f79720c7ef665f77cb Author: Rafael Fonseca Date: Tue Jun 14 15:52:30 2016 +0200 flickr: Fix possible crashes with invalid network responses Check whether we fail to parse the XML sent back by the server. For example, if we were behind a captive portal, we'd try to parse garbage as though it came from the Flickr servers. https://bugzilla.gnome.org/show_bug.cgi?id=707643 src/flickr/gflickr.c | 175 +++++++++++++++++++++++++++++---------------------- 1 file changed, 99 insertions(+), 76 deletions(-) commit 9b13d140d22aab001bccfd6246f70872abcdae0d Author: Rafael Fonseca Date: Wed Jun 15 15:31:31 2016 +0200 flickr: Move g_strconcat() to its own line https://bugzilla.gnome.org/show_bug.cgi?id=707643 src/flickr/gflickr.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) commit 91e35e4b6c289d6c63036eac34a5b5e50d9da594 Author: Rafael Fonseca Date: Wed Jun 15 15:30:19 2016 +0200 flickr: Check return of xml*Get() functions That way we make sure the property exists and was properly parsed. https://bugzilla.gnome.org/show_bug.cgi?id=707643 src/flickr/gflickr.c | 46 +++++++++++++++++++++++++++------------------- 1 file changed, 27 insertions(+), 19 deletions(-) commit 91516f6469d6cba506ef93a81e84a7443d1c07f4 Author: Rafael Fonseca Date: Tue Jun 14 16:05:00 2016 +0200 flickr: Don't mix declaration and code https://bugzilla.gnome.org/show_bug.cgi?id=707643 src/flickr/gflickr.c | 63 ++++++++++++++++++++++++++++++++-------------------- 1 file changed, 39 insertions(+), 24 deletions(-) commit 2e25e54611009489db7582cd090e4a3a9c703e09 Author: Rafael Fonseca Date: Tue Jun 14 16:16:58 2016 +0200 flickr: Don't mix xmlChar and gchar inside hash_table Mixing both types can be potentially bad since they use different allocators. Instead, use the proper function for freeing memory from a xmlChar. https://bugzilla.gnome.org/show_bug.cgi?id=707643 src/flickr/gflickr.c | 28 ++++++++++++++++++++++------ 1 file changed, 22 insertions(+), 6 deletions(-) commit d9708fd5e3fc234e119f2ad33fb87c54c085882b Author: Rafael Fonseca Date: Tue Jun 14 16:31:15 2016 +0200 flickr: Fix variable leaking when response != 'ok' This variable was only being freed if the response was 'ok'. https://bugzilla.gnome.org/show_bug.cgi?id=707643 src/flickr/gflickr.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) commit 88d674aaa46bc16ebc7d17ed13043e180a236e40 Author: Felipe Borges Date: Tue May 2 11:28:02 2017 +0200 lastfm-cover: Use HTTPS rather than insecure HTTP To avoid leaking (potentially uniquely identifiable) user data over plain text, use HTTPS whenever possible. https://bugzilla.gnome.org/show_bug.cgi?id=766789 src/lua-factory/sources/grl-lastfm-cover.lua | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit 24e12ef1cb1a855b7b0d2e88ec244d8e2ab83470 Author: Bastien Nocera Date: Fri Apr 14 16:21:29 2017 +0200 lua-factory: Fix lua sources path with Meson lua-factory was trying to find lua sources in: ~/.local/share/share/grilo-plugins/grl-lua-factory amongst other directories with duplicated "share" components. luafactorydir is used to pass "LUA_FACTORY_SOURCE_LOCATION" as a define, but it has a value of "grilo-plugins/${LUA_FACTORY_PLUGIN_ID}" when using autotools, without a "datadir" component. https://bugzilla.gnome.org/show_bug.cgi?id=781318 src/lua-factory/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit c56808c1914b6433f45078b01df507e20926b200 Author: Bastien Nocera Date: Fri Apr 14 16:20:37 2017 +0200 lua-factory: Better debug in get_lua_sources() So we can know which directories it's trying to read sources from, and whether it succeeded in opening those directories. https://bugzilla.gnome.org/show_bug.cgi?id=781318 src/lua-factory/grl-lua-factory.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) commit 39a15bc911cc3c3af92181fefc5d59fe40d68ec4 Author: Bastien Nocera Date: Thu Apr 13 17:17:59 2017 +0200 meson: Fix DPAP/DAAP plugin names Both had their ID set to the same value (DMAP_PLUGIN_ID), instead to their own ID, meaning that one of them always failed to load as a duplicate. https://bugzilla.gnome.org/show_bug.cgi?id=781278 meson.build | 7 ++++++- src/dmap/meson.build | 2 -- 2 files changed, 6 insertions(+), 3 deletions(-) commit 275659ae7ffe0799f601c9a96d0f52dcd4180b19 Author: Bastien Nocera Date: Thu Apr 13 17:14:34 2017 +0200 dmap: Rename the DAAP plugin to DAAP DAAP is its name, let's name it its name. https://bugzilla.gnome.org/show_bug.cgi?id=781278 src/dmap/grl-daap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit ce3e62476cc4c2bfdb63e6779e75e4c7153db0aa Author: Emmanuele Bassi Date: Thu Apr 13 10:07:47 2017 +0100 build: Support gmime 3.0, Part II Commit f460a00bea4dcb91c6da9dd79caba463bc57b56a only updated the autotools build, but Continuous uses the Meson one. meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 4329dda2c53f9a7bd2a3f6dd9334d4eb5207e9fd Author: Michael Catanzaro Date: Wed Apr 12 21:27:58 2017 -0500 Fix build with latest gmime3 This has been broken for weeks.... Also, drop support for older gmime since we're early in the release cycle and there's not really any compelling reason not to. Obviously this means there must be no more grilo-plugins releases until the next gmime release. If this is undesired then grilo-plugins could grow conditional support for both versions of gmime, but it seem pointless. configure.ac | 8 ++------ src/podcasts/grl-podcasts.c | 10 +++++----- 2 files changed, 7 insertions(+), 11 deletions(-) commit f460a00bea4dcb91c6da9dd79caba463bc57b56a Author: Bastien Nocera Date: Tue Mar 7 15:09:30 2017 +0100 build: Support gmime 3.0 And remove support for gmime 2.4 from 2012. configure.ac | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit b3ab9d059227169e1d57f3157880548f2d33109c Author: Victor Toso Date: Wed Feb 22 22:46:47 2017 +0100 lua-factory: Don't leak list in xml parser We were calling g_list_free() in the pointer that is the last element of the list due g_list_reverse() that was called previously. 1,176 (336 direct, 840 indirect) bytes in 14 blocks are definitely lost in loss record 3,289 of 3,315 at 0x4C2DB9D: malloc (vg_replace_malloc.c:299) by 0x4E895B8: g_malloc (in /usr/lib64/libglib-2.0.so.0.5000.3) by 0x4EA1B12: g_slice_alloc (in /usr/lib64/libglib-2.0.so.0.5000.3) by 0x4E7F9E5: g_list_prepend (in /usr/lib64/libglib-2.0.so.0.5000.3) by 0x9377E69: build_table_recursively (lua-xml.c:64) by 0x9377FAF: build_table_recursively (lua-xml.c:81) by 0x9377FAF: build_table_recursively (lua-xml.c:81) by 0x9377FAF: build_table_recursively (lua-xml.c:81) by 0x9378182: build_table_from_xml_reader (lua-xml.c:121) https://bugzilla.gnome.org/show_bug.cgi?id=779444 src/lua-factory/lua-library/lua-xml.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) commit 475044bb54e36b5f91d657423a3da7934ad71423 Author: Victor Toso Date: Wed Mar 1 22:36:45 2017 +0100 metadata-store: set finalize function to clean up 514,040 (80 direct, 513,960 indirect) bytes in 1 blocks are definitely lost in loss record 19,311 of 19,314 at 0x4C2DB9D: malloc (vg_replace_malloc.c:299) by 0x222277D6: sqlite3MemMalloc (sqlite3.c:20398) by 0x22202967: mallocWithAlarm (sqlite3.c:24067) by 0x22202967: sqlite3Malloc (sqlite3.c:24098) by 0x22202A0D: sqlite3MallocZero (sqlite3.c:24398) by 0x222499F5: sqlite3BtreeOpen (sqlite3.c:60320) by 0x22297786: openDatabase (sqlite3.c:139437) by 0x2662D0B0: grl_metadata_store_source_init (grl-metadata-store.c:237) by 0x53C07FA: g_type_create_instance (gtype.c:1866) by 0x53A269A: g_object_new_internal (gobject.c:1783) by 0x53A45AD: g_object_new_valist (gobject.c:2042) by 0x53A4850: g_object_new (gobject.c:1626) by 0x2662CF9E: grl_metadata_store_source_new (grl-metadata-store.c:194) by 0x2662CF9E: grl_metadata_store_source_plugin_init (grl-metadata-store.c:167) https://bugzilla.gnome.org/show_bug.cgi?id=779444 src/metadata-store/grl-metadata-store.c | 20 ++++++++++++++++---- 1 file changed, 16 insertions(+), 4 deletions(-) commit 83b76e0d2c6172e297d8bb402650d6ce5ab76290 Author: Victor Toso Date: Wed Mar 1 21:42:24 2017 +0100 metadata-store: ignore error on backwards compatibility query Failure happens due the fact that sql table already has those columns. This fixes the following leak. 40 bytes in 1 blocks are definitely lost in loss record 10,094 of 20,529 at 0x4C2DB9D: malloc (vg_replace_malloc.c:299) by 0x217107D6: sqlite3MemMalloc (sqlite3.c:20398) by 0x216EB967: mallocWithAlarm (sqlite3.c:24067) by 0x216EB967: sqlite3Malloc (sqlite3.c:24098) by 0x2175382B: sqlite3_exec (sqlite3.c:108798) by 0x2624FD1B: grl_metadata_store_source_init (grl-metadata-store.c:271) by 0x53C07FA: g_type_create_instance (gtype.c:1866) by 0x53A269A: g_object_new_internal (gobject.c:1783) by 0x53A45AD: g_object_new_valist (gobject.c:2042) by 0x53A4850: g_object_new (gobject.c:1626) by 0x2624F93C: grl_metadata_store_source_new (grl-metadata-store.c:194) by 0x2624F874: grl_metadata_store_source_plugin_init (grl-metadata-store.c:167) by 0x4E48615: grl_plugin_load (grl-plugin.c:243) https://bugzilla.gnome.org/show_bug.cgi?id=779444 src/metadata-store/grl-metadata-store.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit d3e7fedf1d0a55c1c8441af647b13db80cb32395 Author: Victor Toso Date: Thu Feb 23 21:19:19 2017 +0100 lua-factory: fix leak from grl_config_get_string() As it uses g_key_file_get_string() which returns newly allocated. 27 bytes in 1 blocks are definitely lost in loss record 1,825 of 4,702 at 0x4C2DB9D: malloc (vg_replace_malloc.c:299) by 0x4E895B8: g_malloc (in /usr/lib64/libglib-2.0.so.0.5000.3) by 0x4E7B24A: ??? (in /usr/lib64/libglib-2.0.so.0.5000.3) by 0x4E7CA27: g_key_file_get_string (in /usr/lib64/libglib-2.0.so.0.5000.3) by 0x53D0514: grl_config_get_string (grl-config.c:278) by 0xA0A5BDD: all_mandatory_options_has_value (grl-lua-factory.c:1133) by 0xA0A5BDD: grl_lua_factory_source_new (grl-lua-factory.c:467) by 0xA0A68CB: grl_lua_factory_plugin_init (grl-lua-factory.c:235) by 0x53AD615: grl_plugin_load (grl-plugin.c:243) by 0x53AF3BF: activate_plugin (grl-registry.c:483) by 0x53B2584: grl_registry_activate_plugin_by_id (grl-registry.c:1382) by 0x40206C: test_lua_factory_setup (test_lua_factory_utils.c:60) by 0x40193E: test_acoustid_setup (test_lua_acoustid.c:194) by 0x40193E: main (test_lua_acoustid.c:200) 27 bytes in 1 blocks are definitely lost in loss record 1,839 of 4,775 at 0x4C2DB9D: malloc (vg_replace_malloc.c:299) by 0x4E895B8: g_malloc (in /usr/lib64/libglib-2.0.so.0.5000.3) by 0x4E7B24A: ??? (in /usr/lib64/libglib-2.0.so.0.5000.3) by 0x4E7CA27: g_key_file_get_string (in /usr/lib64/libglib-2.0.so.0.5000.3) by 0x53D0514: grl_config_get_string (grl-config.c:278) by 0xA0A5F06: lua_plugin_source_init (grl-lua-factory.c:580) by 0xA0A5F06: grl_lua_factory_source_new (grl-lua-factory.c:477) by 0xA0A68DB: grl_lua_factory_plugin_init (grl-lua-factory.c:235) by 0x53AD615: grl_plugin_load (grl-plugin.c:243) by 0x53AF3BF: activate_plugin (grl-registry.c:483) by 0x53B2584: grl_registry_activate_plugin_by_id (grl-registry.c:1382) by 0x40206C: test_lua_factory_setup (test_lua_factory_utils.c:60) by 0x40193E: test_acoustid_setup (test_lua_acoustid.c:194) by 0x40193E: main (test_lua_acoustid.c:200) https://bugzilla.gnome.org/show_bug.cgi?id=779444 src/lua-factory/grl-lua-factory.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) commit 85ac986410cd54d8985c943b5c94aa80579b0e66 Author: Victor Toso Date: Wed Feb 22 23:02:24 2017 +0100 tests: Do not leak missing keys in spotify 24 bytes in 1 blocks are definitely lost in loss record 1,235 of 3,381 at 0x4C2DB9D: malloc (vg_replace_malloc.c:299) by 0x4E895B8: g_malloc (in /usr/lib64/libglib-2.0.so.0.5000.3) by 0x4EA1B12: g_slice_alloc (in /usr/lib64/libglib-2.0.so.0.5000.3) by 0x4E7F9E5: g_list_prepend (in /usr/lib64/libglib-2.0.so.0.5000.3) by 0x9372497: grl_lua_factory_source_may_resolve (grl-lua-factory.c:1717) by 0x53BBC13: grl_source_may_resolve (grl-source.c:3464) by 0x401C00: test_may_resolve_missing_key (test_spotify_cover.c:112) 48 (24 direct, 24 indirect) bytes in 1 blocks are definitely lost in loss record 2,010 of 3,381 at 0x4C2DB9D: malloc (vg_replace_malloc.c:299) by 0x4E895B8: g_malloc (in /usr/lib64/libglib-2.0.so.0.5000.3) by 0x4EA1B12: g_slice_alloc (in /usr/lib64/libglib-2.0.so.0.5000.3) by 0x4E7FE19: g_list_copy_deep (in /usr/lib64/libglib-2.0.so.0.5000.3) by 0x93724D4: grl_lua_factory_source_may_resolve (grl-lua-factory.c:1696) by 0x53BBC13: grl_source_may_resolve (grl-source.c:3464) by 0x401A7B: test_may_resolve_missing_media (test_spotify_cover.c:133) https://bugzilla.gnome.org/show_bug.cgi?id=779444 tests/spotify-cover/test_spotify_cover.c | 2 ++ 1 file changed, 2 insertions(+) commit 0238bc5e203c5f77638ea3ea24441e3de6b1cad3 Author: Victor Toso Date: Tue Feb 28 12:02:41 2017 +0100 meson: do not use absolute path This patch fixes the build with meson v0.39+ Running meson without this patch fails with: > Meson encountered an error in file src/dleyna/meson.build, line 38, > column 0: Tried to form an absolute path to a source dir. You should > not do that but use relative paths instead. > > To get include path to any directory relative to the current dir do > incdir = include_directories(dirname) meson.build | 2 ++ src/dleyna/meson.build | 4 +--- 2 files changed, 3 insertions(+), 3 deletions(-) commit 380aaf699eaa5a6f5debb361682e133336464df3 Author: Chao-Hsiung Liao Date: Tue Feb 28 06:37:43 2017 +0000 Update Chinese (Taiwan) translation po/zh_TW.po | 266 ++++++++++++++++++++++++++++++------------------------------ 1 file changed, 135 insertions(+), 131 deletions(-) commit 3c61220469dbeb9b40d0a9866bf5aa8444b271f6 Author: Jan Alexander Steffens (heftig) Date: Tue Feb 21 17:57:28 2017 +0100 lua-factory: Sanitize code generation Now that gperf is required to build this plugin, the generated htmlentity.c should be removed from the source. Otherwise, it will be used iff builddir == srcdir. Add some further adjustments to make sure out-of-tree builds don't break. gperf 3.1 changes the type of the len argument for the generated function to size_t, causing a conflict. Replace the prototype with pragmas to make GCC ignore -Werror=missing-prototypes. Tested with "make distcheck" and meson, with gcc and clang. https://bugzilla.gnome.org/show_bug.cgi?id=778857 src/lua-factory/Makefile.am | 11 +- src/lua-factory/lua-library/htmlentity.c | 876 --------------------------- src/lua-factory/lua-library/htmlentity.gperf | 14 +- src/lua-factory/meson.build | 10 +- 4 files changed, 20 insertions(+), 891 deletions(-) commit 90b3f9f3e0f4ec40fe39d6095d913ba30892dd64 Author: Jan Alexander Steffens (heftig) Date: Sun Feb 19 10:46:16 2017 +0100 build: Fix library name of optical-media plugin https://bugzilla.gnome.org/show_bug.cgi?id=778858 src/optical-media/Makefile.am | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) commit 8fa25828f89da5ee8fe40824656179369463ab35 Author: Kjartan Maraas Date: Sat Feb 18 11:52:42 2017 +0100 Updated Norwegian bokmål translation. po/nb.po | 23 ++++++++++++----------- 1 file changed, 12 insertions(+), 11 deletions(-) commit c3ee50c23981ea0debfc6ee60ce23d5dc4ecd2e2 Author: Juan A. Suarez Romero Date: Wed Feb 15 18:04:07 2017 +0100 meson: remove "-Wl,--no-undefined" from link args Meson already adds this by default. src/bookmarks/meson.build | 3 --- src/chromaprint/meson.build | 3 --- src/dleyna/meson.build | 3 --- src/dmap/meson.build | 6 ------ src/filesystem/meson.build | 3 --- src/flickr/meson.build | 3 --- src/freebox/meson.build | 3 --- src/gravatar/meson.build | 3 --- src/jamendo/meson.build | 3 --- src/local-metadata/meson.build | 3 --- src/lua-factory/meson.build | 3 --- src/magnatune/meson.build | 3 --- src/metadata-store/meson.build | 3 --- src/opensubtitles/meson.build | 3 --- src/optical-media/meson.build | 3 --- src/podcasts/meson.build | 3 --- src/raitv/meson.build | 3 --- src/shoutcast/meson.build | 3 --- src/thetvdb/meson.build | 3 --- src/tmdb/meson.build | 3 --- src/tracker/meson.build | 3 --- src/vimeo/meson.build | 3 --- src/youtube/meson.build | 3 --- 23 files changed, 72 deletions(-) commit 34ff054ec58cf8c1f33f8689b508897dc6d0c0fb Author: Victor Toso Date: Tue Feb 14 15:30:19 2017 +0100 Post-release version bump to 0.3.5 configure.ac | 2 +- meson.build | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) commit 37811929314abfe14e132a206980acd3e5bba36d