2004-08-20 Jody Goldberg <jody@gnome.org> * Release 1.10.1 2004-08-17 Jon K Hellan <hellan@acm.org> * gsf/gsf-utils.c (gsf_base64_decode_simple): Revert base64 initialization change. 2004-08-16 Morten Welinder <terra@gnome.org> * gsf/gsf-utils.c (gsf_base64_encode_simple): Request line breaking. 2004-08-13 Jon K Hellan <hellan@acm.org> * gsf/gsf-utils.c (gsf_base64_decode_simple): Initialize during first use. 2004-08-10 Morten Welinder <terra@gnome.org> * gsf/gsf-input-textline.c (gsf_input_textline_utf8_gets): Fix off-by-one in buffer length check. 2004-08-08 Jon K Hellan <hellan@acm.org> * gsf/gsf-output-stdio.c (follow_symlinks, gsf_output_stdio_new): Use g_error_new_literal, not g_error_new on strings which we do not control. 2004-07-30 Christopher James Lahey <clahey@ximian.com> * gsf/gsf-input.c (gsf_input_class_init), gsf/gsf-output.c (gsf_output_class_init): Use correct types for properties here. 2004-07-30 Jody Goldberg <jody@gnome.org> * gsf/gsf-libxml.c (gsf_xml_out_class_init) : Init the parent_class here. (gsf_xml_out_init) : not here. 2004-07-27 Stepan Kasal <kasal@ucw.cz> * gsf/gsf-outfile-msole.c (gsf_outfile_msole_new_full): Fix a race condition with a static buffer. Write correct sb.shift to the header, even if it differs from the default. 2004-07-29 Jody Goldberg <jody@gnome.org> * gsf/gsf-outfile-msole.c (ole_bytes_left_in_block) : sigh. Pull my head out of my rearend. a one line function with two errors. I really shouldn't code when tired. (ole_pad_zero) : remove residual parm rename ole_ from bb_ (ole_pad_bat_unused) : add a residual parm. (gsf_outfile_msole_close_root) : pad metabat with BAT_UNUSED 2004-07-29 Morten Welinder <terra@gnome.org> * gsf/gsf-input-memory.c (gsf_input_mmap_new): Use NULL, not 0 for pointer. (gsf_input_memory_seek): Use G_GNUC_UNUSED instead of void-casting. * gsf/gsf-libxml.c (gsfXMLInParser): Ditto. (gsf_xml_in_get_entity, gsf_xml_in_warning, gsf_xml_in_error, gsf_xml_in_fatal_error): Use G_GNUC_UNUSED instead of void-casting. (gsf_xml_out_add_color): Make buffer size overflow safe. * gsf/gsf-utils.c: Always #define G_ARMFLOAT_ENDIAN. 2004-07-28 Stepan Kasal <kasal@ucw.cz> * gsf/gsf-outfile-msole.c (gsf_outfile_msole_close_root): Check for overflow of the size field of a regular file entry. 2004-07-28 Jody Goldberg <jody@gnome.org> * gsf/gsf-outfile-msole.c (bb_pad_zero) : add a residual param to not fill the entire block if desired and clarify that the current block is cur_size - HEADER not block_size. (gsf_outfile_msole_close_root) : Clarify the metabat writing logic a bit and just in case add a CHAIN_END to the last incomplete metabat (ole_bytes_left_in_block) : similar to Kasal's suggestion without the -1 % size + 1 (bb_pad_zero) : use it here to make this safe to use when not at the end of the file. (ole_pad_bat_unused) : and here to fix the mystery corruption when XL reads the file. 2004-07-27 Jody Goldberg <jody@gnome.org> * gsf/gsf-outfile-msole.c (gsf_outfile_msole_close_root) : the last xbat does not require a forwarding link 2004-07-27 Stepan Kasal <kasal@ucw.cz> * gsf/gsf-outfile-msole.c (metabat_size): Nuke; doesn't have to be an instance variable, it can be local ... (gsf_outfile_msole_close_root): ... here. (gsf_outfile_msole_set_block_shift): Don't set metabat_size. 2004-07-26 Jody Goldberg <jody@gnome.org> * gsf/gsf-outfile-msole.c (OLE_DEFAULT_METABAT_SIZE): delete (gsf_outfile_msole_close_root) : pull out of (gsf_outfile_msole_close) : here as a cleanup gesture. Per : Stepan Kasal <kasal@ucw.cz> * gsf/gsf-outfile-msole.c (gsf_outfile_msole_set_block_shift) : Use BAT_INDEX_SIZE, not hardwired shift of 2. (gsf_outfile_msole_close): Use the current sb.shift, not OLE_DEFAULT_SB_SHIFT. 2004-07-23 Stepan Kasal <kasal@ucw.cz> Replace various instances of local parent_class variables by a static ones, initialized by class_init. * gsf/gsf-*.c: (20 files touched) * gsf/gsf-output-transaction.c: A general cleanup. 2004-07-21 Stepan Kasal <kasal@ucw.cz> The gsf_ouput_printf method didn't correctly update cur_offset. The implementations of vprintf virtual method shouldn't touch cur_offset but they should return the number of bytes written; the dispatcher updates cur_offset accordingly. * gsf/gsf-output-impl.h (Vprintf): The virtual private method now returns number of bytes printed. * gsf/gsf-output.c (gsf_output_vprintf): Renamed to ... (gsf_output_ireal_vprintf): ... this. (gsf_output_printf): Collect the va_list and call ... (gsf_output_vprintf): ... this new function, which dispatches the Vprintf virtual method and takes care of updating cur_offset and cur_size, via ... (gsf_output_inc_cur_offset): ... a new static function, extracted from ... (gsf_output_write): ... there. (gsf_output_real_vprintf): In this fallback code, don't call gsf_output_write, but only dispatch to the Write virual method, so that gsf_output_inc_cur_offset is not called twice. * gsf/gsf-output.h (gsf_output_vprintf): New public method. * gsf/gsf-output-stdio.c (gsf_output_stdio_vprintf): Adapt. * gsf/gsf-output-transaction.c (gsf_output_trans_vprintf): Likewise. * gsf/gsf-outfile-msole.c (gsf_output_class): New static variable, which is set to point to GsfOutput class structure. (gsf_outfile_msole_vprintf): Adapt. If it's a MSOLE_BIG_FILE, call vprintf method of the underlaying file, else fall back to gsf_output_class->Vprintf. * gsf/gsf-output-memory.c (parent_class): New static variable. (gsf_output_memory_vprintf): Use it too. Adapt to the new prototype. 2004-07-21 Stepan Kasal <kasal@ucw.cz> Make the two fseek() wrappers more consistent. * gsf/gsf-input-stdio.c (gsf_input_stdio_seek): Fix the overflow checking. * gsf/gsf-output-stdio.c (gsf_output_stdio_seek): Set errno=0 before calling fseek(). 2004-07-21 Stepan Kasal <kasal@ucw.cz> Gnomish autogen.sh uses ACLOCAL_FLAGS, if some of the macros are in nonstandard places. If you touch configure.in then, aclocal.m4 is regenerated, but without ACLOCAL_FLAGS. This change ensures that ACLOCAL_FLAGS is propagated to the Makefile. * configure.in: AC_SUBST(ACLOCAL_FLAGS) * Makefile.am: ACLOCAL_AMFLAGS = @ACLOCAL_FLAGS@ 2004-07-20 Stepan Kasal <kasal@ucw.cz> * gsf/gsf-output-stdio.c: Check for overflow 2004-07-09 Stepan Kasal <kasal@ucw.cz> * gsf/gsf-infile-zip.c (zip_find_trailer): Remove the "overflow check"; it can never catch anything. * gsf/gsf-output-memory.c (MAX_STEP): Parenthesize. (gsf_output_memory_expand): Fix the overflow checking. (gsf_output_memory_seek): make use of G_GNUC_UNUSED, instead of void reference. 2004-07-12 Stepan Kasal <kasal@ucw.cz> * gsf/gsf-output-iochannel.c (GET_OUTPUT_CLASS): Remove unused macro. * gsf/gsf-structured-blob.c (GET_CLASS): Likewise. 2004-06-15 Jody Goldberg <jody@gnome.org> * gsf/gsf-utils.c (gsf_input_dump) : flush the stream when we're just using stdio. 2004-07-04 J.H.M. Dassen (Ray) <jdassen@debian.org> * configure.in: recheck all PKG_CHECK_MODULES for libgsf for libgsf-gnome as well, so as not to trip on unresolved symbols with a -Wl,-z,defs build. 2004-07-03 Jody Goldberg <jody@gnome.org> * configure.in : post release bump