2006-01-20 Elijah Newren <newren gmail com> * NEWS: 2.13.34 release 2006-01-20 Elijah Newren <newren gmail com> * src/constraints.c (setup_constraint_info): fixed_directions is only meant for explicit user interactions; disable it for everything else. There are other bugs and improvements that could be made with fixed_directions that I should be filing too, but at least put a FIXME there for now--I'm so lame. Fixes #327822. 2006-01-20 Elijah Newren <newren gmail com> Avoid flashing when closing a maximized window. Fixes #317254. * src/window.c (unmaximize_window_before_freeing): new function that just fixes the net_wm_state and sends a configure_notify, (meta_window_free): use unmaximize_window_before_freeing() instead of meta_window_unmaximize() to avoid flicker 2006-01-20 Elijah Newren <newren gmail com> Fix unitialized value problem when in raise-on-click mode. Søren, #327572. * src/display.c (meta_display_check_threshold_reached): make function be a no op if raise_on_click!=FALSE * src/display.h (struct MetaDisplay): point out that grab_initial_[xy] and grab_threshold_movement_reached are only for raise_on_click==FALSE mode. 2006-01-20 Elijah Newren <newren gmail com> Patch from Søren to fix some reading-from-free'd-data errors. #327575 * src/edge-resistance.c (meta_display_cleanup_edges): store the edges in a hash table so that we can still read their values within the loop from the other array they are stored in, then free them all at the end. 2006-01-20 Elijah Newren <newren gmail com> Fix various initialization and default issues, especially for --disable-gconf. Make --disable-gconf actually work. #326661. * configure.in: Fix compilation with --disable-gconf * src/metacity.schemas.in: Add a note that if any defaults are changed in this file, src/prefs.c may need to be updated to reflect the change * src/prefs.c: set various static global vars to the right default value, (meta_prefs_init): get the titlebar_font and current_theme handled better when not using gconf, (struct MetaSimpleKeyMapping, screen_string_bindings, window_string_bindings): helper vars to allow some keybindings to work even without gconf, (init_bindings): initialize bindings for the without-gconf case too, (init_commands): make sure these are all NULL for the non-gconf case so that we don't access random memory, (init_workspace_names): just give these all a default name for the non-gconf case, (meta_prefs_change_workspace_name): actually change the name for the non-gconf case too 2006-01-20 Elijah Newren <newren gmail com> More careful error handling of values returned by GConf. Fixes #326615. * src/prefs.c (get_bool): new helper function, (meta_prefs_init): use get_bool to handle the case of a gconf key not existing, (update_cursor_size): sanity check for sane values 2006-01-20 Elijah Newren <newren gmail com> Prevent rapidly repeated visual bells from hanging metacity. Fixes #322032. * src/display.h (struct MetaDisplay): add a last_bell_time field, (XSERVER_TIME_IS_BEFORE_ASSUMING_REAL_TIMESTAMPS macro, XERVER_TIME_IS_BEFORE macro): add parentheses around usage of macro parameter * src/display.c (meta_display_open): initialize last_bell_time, (event_callback): don't allow more than one bell per second 2006-01-20 Elijah Newren <newren gmail com> * src/async-getprop.c: * src/common.h: * src/display.c: * src/eggaccelerators.c: * src/frames.c: * src/gradient.c: * src/iconcache.c: * src/keybindings.c: * src/metaaccellabel.c: * src/place.c: * src/prefs.c: * src/preview-widget.c: * src/screen.c: * src/session.c: * src/stack.c: * src/tabpopup.c: * src/theme-viewer.c: * src/theme.c: * src/window-props.c: * src/window.c: * src/workspace.c: * src/tools/metacity-window-demo.c: * src/wm-tester/test-gravity.c: * src/wm-tester/test-resizing.c: * src/wm-tester/test-size-hints.c: Patch from Kjartan Maraas to fix a lot of tiny issues (unused variable removal, making unused variables used again, correction of types passed/declared for printf arguments, removal of unneeded breaks and returns, dead code removal, dead code revival, renaming to prevent shadowed variables, declaring unexported functions as static) spotted by the intel compiler. #321439 2006-01-20 Elijah Newren <newren gmail com> Patch from Björn Lindqvist to fix #98340. * src/screen.c (meta_screen_ensure_tab_popup): Make sure an outline border is shown even if a window frame's width is 0. Also, correctly handle window outlines in showing desktop mode. Fri Jan 20 16:42:25 2006 Søren Sandmann <sandmann@redhat.com> * src/compositor.c: Make minimize animation update again. Thu Jan 19 18:05:47 2006 Søren Sandmann <sandmann@redhat.com> * src/compositor.c (meta_compositor_manage_screen): g_object_unref() rather than ws_region_unref(). Thu Jan 19 16:50:50 2006 Søren Sandmann <sandmann@redhat.com> * src/compositor.c: Port to changes in libcm Tue Jan 17 17:25:29 2006 Søren Sandmann <sandmann@redhat.com> * src/compositor.c: Port to changes in libcm. 2006-01-16 Elijah Newren <newren gmail com> * src/window-props.c: manually define HOST_NAME_MAX if not already defined to fix Solaris compilation issue. Caught by Damien Carbery, patch from Havoc. #326745 2006-01-16 Elijah Newren <newren gmail.com> * configure.in: post-release version bump to 2.13.34 2006-01-16 Elijah Newren <newren gmail com>