2007-08-11 James Livingston <doclivingston@gmail.com> patch by: Eduardo Lima * plugins/rb-plugins-engine.c: (rb_plugins_engine_get_plugin_icon): emit warning rather than crashing if it gets passed NULL. Fixes #465400 2007-08-09 James Livingston <doclivingston@gmail.com> * MAINTAINERS: change the file to use the new format the we need to use (mentioned on desktop-devel-list) 2007-08-08 James Livingston <doclivingston@gmail.com> * plugins/coherence/upnp_coherence/__init__.py: be nicer if Coherence isn't present. * plugins/coherence/upnp_coherence/MediaStore.py: set the path so that local files will be server. Need a propert http server that can read from gnomevfs/gstreamer * plugins/magnatune/magnatune/MagnatuneSource.py: adapt to the change MagnaTune seems to have made to the location of the file in the zip file. 2007-08-07 Christophe Fergeau <cfergeau@gmail.com> * configure.ac: revert another bogus change in last.fm ipod commit :-/ 2007-08-07 Christophe Fergeau <cfergeau@gmail.com> * plugins/ipod/rb-ipod-db.c: make RbIpodDb creation more robust when the itdb->device is NULL 2007-08-07 Christophe Fergeau <cfergeau@gmail.com> * plugins/coherence/Makefile.am: revert bogus change in previous commit 2007-08-07 Christophe Fergeau <cfergeau@gmail.com> * configure.ac: * plugins/audioscrobbler/rb-audioscrobbler.c: * plugins/coherence/Makefile.am: * plugins/ipod/rb-ipod-source.c: notify last.fm about the songs played on the iPod while it wasn't connected to a computer. Fixes bug #334488. It doesn't handle songs played multiple times, and the last.fm will reject the submission if any songs were submitted to last.fm after the songs were played on the iPod 2007-08-07 Jonathan Matthew <jonathan@kaolin.wh9.net> patch by: Tim Retout <tim@retout.co.uk> * sources/rb-podcast-source.c: (rb_podcast_source_feeds_show_popup_cb): Make the 'update feed' action visible when appropriate. Fixes #462788. 2007-08-06 Jonathan Matthew <jonathan@kaolin.wh9.net> * widgets/rb-library-browser.c: (idle_rebuild_model), (destroy_idle_rebuild_model), (rb_library_browser_set_selection): Store data for child model rebuild idle handlers in a separate data structure, rather than in the browser object itself. Otherwise it trips on its own feet and breaks the browser. Fixes #452703 again. 2007-08-04 James Livingston <doclivingston@gmail.com> patch by: Tim Retout <tim@retout.co.uk> * bindings/python/rhythmdb.override: Fix handling of subqueries and disjunctions from python. Fixes #463208 2007-08-04 James Livingston <doclivingston@gmail.com> * shell/rb-play-order.c: * shell/rb-play-order.h: * shell/rb-shell-player.c: (rb_shell_player_init), (rb_shell_player_set_queue_source_internal), (rb_shell_player_finalize), (rb_shell_player_sync_play_order), (_play_order_description_free), (rb_play_order_new), (rb_shell_player_add_play_order), (rb_shell_player_remove_play_order): * shell/rb-shell-player.h: allow dynamic addition (and removal) of play orders, mostly interesting for plugins. Fixes #462470 * bindings/python/rb.defs: bind to python 2007-08-02 Jonathan Matthew <jonathan@kaolin.wh9.net> * remote/dbus/rb-client.c: (print_playing_song): Empty playing URI string means not playing. 2007-08-01 Jonathan Matthew <jonathan@kaolin.wh9.net> * plugins/generic-player/rb-generic-player-source.c: (set_playlist_formats): Fix build break from previous commit, bug #462245. 2007-07-31 Jonathan Matthew <jonathan@kaolin.wh9.net> * plugins/generic-player/rb-generic-player-source.c: (rb_generic_player_source_constructor), (get_is_audio_player_path), (set_playlist_path), (set_playlist_formats), (debug_device_info), (rb_generic_player_source_get_device_info), (rb_generic_player_is_volume_player), (load_playlist_file), (visit_playlist_dirs), (default_load_playlists): Read device info from the .is_audio_player file (a la Banshee) to override the information we get from HAL. Change our interpretation of playlist_path to be closer to what I think the HAL spec means. From bug #380960. 2007-07-31 Jonathan Matthew <jonathan@kaolin.wh9.net> * configure.ac: Enable warnings when we appear to be in a git tree * lib/Makefile.am: * plugins/Makefile.am: * plugins/audiocd/Makefile.am: * plugins/audioscrobbler/Makefile.am: * plugins/cd-recorder/Makefile.am: * plugins/daap/Makefile.am: * plugins/generic-player/Makefile.am: * plugins/ipod/Makefile.am: * plugins/iradio/Makefile.am: * plugins/lirc/Makefile.am: * plugins/mmkeys/Makefile.am: * plugins/mtpdevice/Makefile.am: * plugins/power-manager/Makefile.am: * plugins/sample-vala/Makefile.am: * plugins/sample/Makefile.am: * plugins/visualizer/Makefile.am: * remote/dbus/Makefile.am: * shell/Makefile.am: * sources/Makefile.am: * widgets/Makefile.am: Remove WARN_CFLAGS from all makefiles. It doesn't get substituted, and it's included in RHYTHMBOX_CFLAGS anyway. 2007-07-26 Jonathan Matthew <jonathan@kaolin.wh9.net> * plugins/iradio/rb-iradio-source.c: (rb_iradio_source_add_station): Ensure the strings we get from totem-plparser are valid utf8. Fixes #459093. 2007-07-25 James Livingston <doclivingston@gmail.com> * plugins/coherence/upnp_coherence/MediaStore.py: * plugins/coherence/upnp_coherence/UpnpSource.py: * plugins/coherence/upnp_coherence/__init__.py: fix assorted bits, and make the content directory (MediaStore) actually work. You can now chew large amounts of CPU while sending/receiving the track data, before not playing any of the tracks 2007-07-23 Jonathan Matthew <jonathan@kaolin.wh9.net> * widgets/rb-library-browser.c: (idle_rebuild_model), (destroy_idle_rebuild_model), (rb_library_browser_set_selection): When the browser selection changes, use an idle handler to rebuild the query models. Sometimes the selection change occurs while an entry property change is propagating through the query chain, and if we rebuild the query chain before it's done, property models can get out of sync, causing assertion failures. Should fix #452703. 2007-07-21 Jonathan Matthew <jonathan@kaolin.wh9.net> * plugins/mtpdevice/rb-mtp-source.c: (rb_mtp_source_class_init): Don't set source_class->impl_can_paste unless track transfer is enabled. Fixes #449286. 2007-07-20 Jonathan Matthew <jonathan@kaolin.wh9.net> * sources/rb-library-source.c: (rb_library_source_library_location_cb): Don't free the library location URI twice. Fixes #455232. 2007-07-18 Jonathan Matthew <jonathan@kaolin.wh9.net> * plugins/daap/rb-daap-source.c: (connection_auth_cb): Don't assume gnome-keyring actually gave us a password. Should fix #453897. 2007-07-11 Jonathan Matthew <jonathan@kaolin.wh9.net> patch by: Adam Zimmerman <adam_zimmerman@sfu.ca> * plugins/magnatune/magnatune-loading.glade: Prevent the text from being selected. Fixes #425408. 2007-07-10 Jonathan Matthew <jonathan@kaolin.wh9.net> * plugins/jamendo/jamendo/JamendoSaxHandler.py: * plugins/jamendo/jamendo/JamendoSource.py: Throw away data as early as possible, and abuse the musicbrainz album ID field to store jamendo album IDs. Reduces memory usage by about 30MB. From bug #424423. Also, emit cover art notifications in an idle handler, so they actually work. 2007-07-09 Alex Lancaster <alexl@users.sourceforge.net> * plugins/coherence/Makefile.am (plugindir): * plugins/coherence/upnp_coherence/Makefile.am (plugindir): Fix installation location to upnp_coherence. 2007-07-08 James Livingston <doclivingston@gmail.com> * plugins/coherence/coherence.rb-plugin.desktop.in: * plugins/coherence/upnp_coherence/Makefile.am: * plugins/coherence/upnp_coherence/MediaStore.py: * plugins/coherence/upnp_coherence/__init__.py: add start of support for sharing tracks over UPnP 2007-07-08 James Livingston <doclivingston@gmail.com> * bindings/python/rhythmdb.defs: * bindings/python/rhythmdb.override: * plugins/daap/rb-daap-share.c: (add_entry_to_mlcl): * rhythmdb/rhythmdb-tree.c: (_foreach_by_type_cb), (rhythmdb_tree_entry_foreach_by_type): * rhythmdb/rhythmdb.c: (rhythmdb_prop_type_get_type), (rhythmdb_entry_register_type): fix python bindings of the rhythmdb foreach methods. 2007-07-08 Jonathan Matthew <jonathan@kaolin.wh9.net> patch by: Tim Retout <tim@retout.co.uk> * bindings/python/Makefile.am: * bindings/python/rb.defs: * bindings/python/rb.override: Add python bindings for rb_utf_friendly_time(). Bug #453226. 2007-07-07 Luca Ferretti <elle.uca@libero.it> * plugins/lyrics/lyrics-prefs.glade: don't mark gtk-ok and gtk-cancel as translatable 2007-07-05 James Livingston <doclivingston@gmail.com> * plugins/coherence/upnp_coherence/Makefile.am: * plugins/coherence/upnp_coherence/UpnpSource.py: add missing file, and fix a typo 2007-07-05 Dennis Cranston <dennis_cranston@yahoo.com> * data/glade/playback-prefs.glade: HIG capitalization, mnemonic, and spacing fixes. Bug #452010. 2007-07-04 James Livingston <doclivingston@gmail.com> * plugins/rb-python-module.c: (rb_python_garbage_collect), (rb_python_shutdown): disable our manual python garbage collection for now, since it explodes if something imports twisted's gtk2 reactor. It doesn't make much of a difference anyway, since the python runtime runs GC itself. * configure.ac: * plugins/Makefile.am: * plugins/coherence/Makefile.am: * plugins/coherence/coherence.rb-plugin.desktop.in: * plugins/coherence/upnp_coherence/UpnpSource.py: * plugins/coherence/upnp_coherence/__init__.py: add the start of a UPnP A/V plugin, using Coherence. It currently adds entries for all audio items and can play them 2007-07-01 Jonathan Matthew <jonathan@kaolin.wh9.net> * podcast/rb-podcast-parse.c: (rb_podcast_parse_load_feed): Ignore the query string when checking if a podcast URL has a .rss or .xml extension. Fixes #437911, sort of. 2007-07-01 Jonathan Matthew <jonathan@kaolin.wh9.net> * plugins/ipod/rb-ipod-db.c: (rb_ipod_db_set_thumbnail_internal): Fix build with newer versions of libgpod. 2007-07-01 James Livingston <doclivingston@gmail.com> * shell/main.c: (main): * shell/rb-shell.c: (rb_shell_class_init), (rb_shell_set_property), (rb_shell_get_property), (rb_shell_new): * shell/rb-shell.h: remove the argc and argv properties from the shell, as they're not used. Fixes #448538 2007-06-30 Jürg Billeter <j@bitron.ch> * configure.ac: fix Vala version check 2007-06-30 Jonathan Matthew <jonathan@kaolin.wh9.net> * bindings/python/rb.defs: The argument to rb_shell_notebook_set_page can usefully be NULL, so allow python code to pass None here. 2007-06-30 Jonathan Matthew <jonathan@kaolin.wh9.net> * plugins/visualizer/rb-visualizer-plugin.c: (update_tee_visualizer): Remove mysterious unused variable. 2007-06-29 Jonathan Matthew <jonathan@kaolin.wh9.net> * plugins/visualizer/rb-visualizer-plugin.c: (update_playbin_visualizer), (tee_visualizer_inserted), (tee_visualizer_pre_remove), (update_tee_visualizer), (update_visualizer), (impl_activate): In tee mode, only start the video sink as necessary. If it refuses to start, disable visualization and report the error to the user. From bug #406807. 2007-06-28 Jonathan Matthew <jonathan@kaolin.wh9.net> * sources/rb-auto-playlist-source.c: (rb_auto_playlist_source_constructor): * sources/rb-static-playlist-source.c: (rb_static_playlist_source_constructor): Only add the search actions once. Fixes #451268. 2007-06-27 Bastien Nocera <hadess@hadess.net> * data/ui/rhythmbox-ui.xml: Moved the Play button to the left-most (Closes: #423117) 2007-06-27 Jonathan Matthew <jonathan@kaolin.wh9.net> * plugins/generic-player/rb-generic-player-source.c: (impl_build_dest_uri): For untagged files, replace the original file extension with that of the output format. Fixes #451455.